Re: [PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

2011-04-03 Thread Guennadi Liakhovetski
On Sun, 3 Apr 2011, Pawel Osciak wrote: > Drivers are now required to implement the stop_streaming() callback > to ensure that all ongoing hardware operations are finished and their > ownership of buffers is ceded. > Drivers do not have to call vb2_buffer_done() for each buffer they own > anymore.

Re: [PATCH 3/5] [media] s5p-fimc: remove stop_streaming() callback return

2011-04-03 Thread Hans Verkuil
On Monday, April 04, 2011 01:51:08 Pawel Osciak wrote: > The stop_streaming() callback does not return a value anymore. > > Signed-off-by: Pawel Osciak > --- > drivers/media/video/s5p-fimc/fimc-capture.c |4 ++-- > drivers/media/video/s5p-fimc/fimc-core.c|4 +--- > 2 files changed, 3

Re: [PATCH 1/3] [media] vb2: update and fix interface documentation

2011-04-03 Thread Hans Verkuil
On Monday, April 04, 2011 01:38:55 Pawel Osciak wrote: > Update documentation for videobuf2 driver callbacks and memory operations. > > Signed-off-by: Pawel Osciak Much improved, thank you! There is one thing that I would like to see, though, and that is from where these ops are called. E.g. it

Re: [PATCH 3/3] [media] vb2: prevent drivers from requesting too many buffers/planes.

2011-04-03 Thread Hans Verkuil
On Monday, April 04, 2011 01:38:57 Pawel Osciak wrote: > Add a sanity check to make sure drivers do not adjust the number of buffers > or planes above the supported limit on reqbufs. > > Signed-off-by: Pawel Osciak > --- > drivers/media/video/videobuf2-core.c |5 + > 1 files changed, 5 i

RE: [PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

2011-04-03 Thread Marek Szyprowski
Hello, On Monday, April 04, 2011 1:51 AM Pawel Osciak wrote: > Drivers are now required to implement the stop_streaming() callback > to ensure that all ongoing hardware operations are finished and their > ownership of buffers is ceded. > Drivers do not have to call vb2_buffer_done() for each buff

Re: [PATCH 3/3] [media] cx88: use a mutex to protect cx8802_devlist

2011-04-03 Thread Andreas Huber
I added some printk entries and finally got suspicious output after rmmod cx88_blackbird ; modprobe cx88_blackbird debug=true [...] cx88[0]/2: registered device video3 [mpeg] cx88[0]/2-bb: mpeg_open [cx88-blackbird.c,mpeg_open(),line 1059] mutex_lock(&dev->core->lock); cx88[0]/2-bb: Initialize c

[PATCH 2/5] [media] vivi: adapt to the new stop_streaming() callback behavior

2011-04-03 Thread Pawel Osciak
Drivers are no longer required to call vb2_buffer_done() for all buffers they have queued in stop_streaming(). The return value for stop_streaming() has also been removed. Signed-off-by: Pawel Osciak --- drivers/media/video/vivi.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-

[PATCH 3/5] [media] s5p-fimc: remove stop_streaming() callback return

2011-04-03 Thread Pawel Osciak
The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak --- drivers/media/video/s5p-fimc/fimc-capture.c |4 ++-- drivers/media/video/s5p-fimc/fimc-core.c|4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/s5p-

[PATCH 5/5] [media] mx3_camera: remove stop_streaming() callback return

2011-04-03 Thread Pawel Osciak
The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak --- drivers/media/video/mx3_camera.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mx3_camera.c b/drivers/media/video/mx3_camera.c index 8630c0c..1703b93 1

[PATCH 4/5] [media] sh_mobile_ceu_camera: remove stop_streaming() callback return

2011-04-03 Thread Pawel Osciak
The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak --- drivers/media/video/sh_mobile_ceu_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_ca

[PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

2011-04-03 Thread Pawel Osciak
Drivers are now required to implement the stop_streaming() callback to ensure that all ongoing hardware operations are finished and their ownership of buffers is ceded. Drivers do not have to call vb2_buffer_done() for each buffer they own anymore. Also remove the return value from the callback. S

vb2: stop_streaming() callback redesign

2011-04-03 Thread Pawel Osciak
Hi, This series implements a slight redesign of the stop_streaming() callback in vb2. The callback has been made obligatory. The drivers are expected to finish all hardware operations and cede ownership of all buffers before returning, but are not required to call vb2_buffer_done() for any of the

[PATCH 3/3] [media] vb2: prevent drivers from requesting too many buffers/planes.

2011-04-03 Thread Pawel Osciak
Add a sanity check to make sure drivers do not adjust the number of buffers or planes above the supported limit on reqbufs. Signed-off-by: Pawel Osciak --- drivers/media/video/videobuf2-core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/videob

[PATCH 2/3] [media] vb2: use unsigned int for the `mapped' bitfield

2011-04-03 Thread Pawel Osciak
Signed-off-by: Pawel Osciak Reported-by: David Alan Gilbert --- include/media/videobuf2-core.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index 4c1e91f..f3bdbb2 100644 --- a/include/media/videobuf2-cor

[PATCH 1/3] [media] vb2: update and fix interface documentation

2011-04-03 Thread Pawel Osciak
Update documentation for videobuf2 driver callbacks and memory operations. Signed-off-by: Pawel Osciak --- include/media/videobuf2-core.h | 146 +--- 1 files changed, 91 insertions(+), 55 deletions(-) diff --git a/include/media/videobuf2-core.h b/include/med

[PATCH 1/1] wl128x: Remove unused NO_OF_ENTRIES_IN_ARRAY macro.

2011-04-03 Thread Thiago Farina
Signed-off-by: Thiago Farina --- drivers/media/radio/wl128x/fmdrv.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/wl128x/fmdrv.h b/drivers/media/radio/wl128x/fmdrv.h index 5db6fd1..1a45a5d 100644 --- a/drivers/media/radio/wl128x/fmdrv.h +++ b/drive

DVB-T frequencies for Tenerife, Spain

2011-04-03 Thread Cédric Martínez Campos
Hi there, attached to this e-mail, you will find the DVB-T frequencies for my present region: Tenerife in Spain. It would be great if you could include it in the dvb-apps package together. Sincerely yours, Dr. Cédric M. Campos Dept. Matemática Fundamental Universidad de La Laguna, ULL Avda. Astr

[cron job] v4l-dvb daily build: ERRORS

2011-04-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Sun Apr 3 19:00:31 CEST 2011 git hash:28df73703e738d8ae7a958350f74b08b2e9fe9ed gcc version: i686-linux-gcc (GCC) 4.5

Re: Skystar 2 2.6 broken in kernel 2.6.38

2011-04-03 Thread Steffen Barszus
On Sun, 3 Apr 2011 17:41:42 +0200 Patrick Boettcher wrote: > Hi, > > On Saturday 02 April 2011 21:30:53 Steffen Barszus wrote: > > Hi > > > > I just installed natty and found that one of the drivers i use is > > broken. Is this a known issue ? > > > > > > [6.115925] [ cut here

dibusb device with lock problems

2011-04-03 Thread Mr Tux
hello Patrick, On Sunday 03 April 2011 17:37:00 Patrick Boettcher wrote: > >I think this line is not normal in your case: > > dibusb: This device has the Thomson Cable onboard. Which is default. > Here's the output of dmesg in Lenny (kernel 2.6.26-1) where the tuning was fine: usb 2-1: new ful

Re: [PATCH/RFC 2/4 v2] V4L: add videobuf2 helper functions to support multi-size video-buffers

2011-04-03 Thread Pawel Osciak
Hi Gueannadi, A preliminary quick scan over the patch while waiting for documentation. On Fri, Apr 1, 2011 at 07:06, Guennadi Liakhovetski wrote: > This patch extends the videobuf2 framework with new helper functions and > modifies existing ones to support multi-size video-buffers. > > Signed-off

Re: [PATCH/RFC 0/4] V4L: new ioctl()s to support multi-sized video-buffers

2011-04-03 Thread Pawel Osciak
Hi Guennadi, On Fri, Apr 1, 2011 at 01:12, Guennadi Liakhovetski wrote: > Hi all > > As discussed at the last V4L2 meeting in Warsaw, one of the prerequisites > to support fast switching between different image formats is an ability to > preallocate buffers of different sizes and handle them over

[PATCH 2/2] [media] dib0700: remove unused variable

2011-04-03 Thread Florian Mickler
This variable is never used. Signed-off-by: Florian Mickler --- drivers/media/dvb/dvb-usb/dib0700_core.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/dib0700_core.c b/drivers/media/dvb/dvb-usb/dib0700_core.c index ca80520..7f6f023 100644 -

[PATCH 1/2] [media] dib0700: get rid of on-stack dma buffers

2011-04-03 Thread Florian Mickler
usb_control_msg initiates (and waits for completion of) a dma transfer using the supplied buffer. That buffer thus has to be seperately allocated on the heap. In lib/dma_debug.c the function check_for_stack even warns about it: WARNING: at lib/dma-debug.c:866 check_for_stack Note: This ch

[media] dib0700: get rid of on-stack dma buffers

2011-04-03 Thread Florian Mickler
Hi, since I got no reaction[1] on the vp702x driver, I proceed with the dib0700. There are multiple drivers in drivers/media/dvb/dvb-usb/ which use usb_control_msg to perform dma to stack-allocated buffers. This is a bad idea because of cache-coherency issues and on some platforms the stack is

[2.6.39] fixes - pull request

2011-04-03 Thread Patrick Boettcher
Hi Mauro, I cleaned my mailbox and collected some small fixes for 2.6.39 and for other version (stable is Cc'd in that case). Please pull from (sorry for the wrong branch name) http://git.linuxtv.org/pb/media_tree.git staging/for_v2.6.39 for [PATCH] Fix dependencies for Technisat USB2.0 DVB-

Re: [PATCH] [media] dib0700: fix possible NULL pointer dereference

2011-04-03 Thread Patrick Boettcher
On Saturday 26 March 2011 19:23:56 Mariusz Kozlowski wrote: > Seems like 'adap->fe' test for NULL was meant to be before we dereference > that pointer. > > Signed-off-by: Mariusz Kozlowski Thanks, applied. -- Patrick Boettcher - KernelLabs http://www.kernellabs.com/ -- To unsubscribe from this

Re: vb2_plane 'mapped' signed bit field

2011-04-03 Thread Pawel Osciak
On Sat, Apr 2, 2011 at 17:18, Dr. David Alan Gilbert wrote: > Hi Pawel, >  'sparse' spotted that vb2_plane's mapped field is a signed > bitfield: > > include/media/videobuf2-core.h:78:41 1 bit signed int > > struct vb2_plane { >       void                    *mem_priv; >       int                

Re: Skystar 2 2.6 broken in kernel 2.6.38

2011-04-03 Thread Patrick Boettcher
Hi, On Saturday 02 April 2011 21:30:53 Steffen Barszus wrote: > Hi > > I just installed natty and found that one of the drivers i use is > broken. Is this a known issue ? > > > [6.115925] [ cut here ] > [6.115931] WARNING: at > /build/buildd/linux-2.6.38/fs/proc/

Re: dibusb device with lock problems

2011-04-03 Thread Patrick Boettcher
Hi Mr Tux, On Saturday 02 April 2011 15:45:22 Mr Tux wrote: > Hi list, hello Patrick, > > A locking problem with specific dib3000mb devices is still present in > kernel 2.6.38. > > Now people upgrading from lenny to squeeze are also affected - see: [1] > > Please have a look at my previous post

Re: Hauppauge Nova-S remote control broken in 2.6.38

2011-04-03 Thread Lawrence Rust
On Sun, 2011-04-03 at 11:25 -0300, Mauro Carvalho Chehab wrote: > Em 03-04-2011 08:41, Lawrence Rust escreveu: > > I just installed a new 2.6.38.2 kernel and found that the remote control > > on my Hauppauge Nova-S plus is no longer working. dmesg shows that > > everything initialised OK: > > > >

Re: Hauppauge Nova-S remote control broken in 2.6.38

2011-04-03 Thread Mauro Carvalho Chehab
Em 03-04-2011 08:41, Lawrence Rust escreveu: > I just installed a new 2.6.38.2 kernel and found that the remote control > on my Hauppauge Nova-S plus is no longer working. dmesg shows that > everything initialised OK: > > [8.002874] cx88/0: cx2388x v4l2 driver version 0.0.8 loaded > [8.100

Re: Debug code in HG repositories

2011-04-03 Thread Mauro Carvalho Chehab
Em 10-01-2011 23:10, Oliver Endriss escreveu: > On Monday 10 January 2011 13:04:54 Mauro Carvalho Chehab wrote: >> Em 07-01-2011 21:56, Oliver Endriss escreveu: >>> ... >>> There are large pieces of driver code which are currently unused, and >>> nobody can tell whether they will ever be needed. >>

Re: [patch] Fix AF9015 Dual tuner i2c write failures

2011-04-03 Thread adq
2011/4/2 Antti Palosaari : > On 04/02/2011 04:45 PM, adq wrote: >> >> 2011/4/2 Antti Palosaari: >>> >>> On 04/02/2011 02:06 PM, adq wrote: 2011/4/2 Antti Palosaari: > > On 04/02/2011 04:24 AM, adq wrote: >> >> Hi, just been trying it out, with no success. On my test machin

Hauppauge Nova-S remote control broken in 2.6.38

2011-04-03 Thread Lawrence Rust
I just installed a new 2.6.38.2 kernel and found that the remote control on my Hauppauge Nova-S plus is no longer working. dmesg shows that everything initialised OK: [8.002874] cx88/0: cx2388x v4l2 driver version 0.0.8 loaded [8.100260] IR NEC protocol handler initialized [8.132843] t