This fix the following warning:
drivers/media/video/v4l2-compat-ioctl32.c: In function ‘get_microcode32’:
drivers/media/video/v4l2-compat-ioctl32.c:209: warning: ignoring return value
of ‘copy_to_user’, declared with attribute warn_unused_result
Signed-off-by: Thiago Farina
---
drivers/media/vi
On Sat, Dec 18, 2010 at 6:31 AM, Hans Verkuil wrote:
> Hi all,
>
> Now that the BKL patch series has been merged in 2.6.37 it is time to work
> on replacing .ioctl by .unlocked_ioctl in all v4l drivers.
>
> I've made an inventory of all drivers that still use .ioctl and I am looking
> for voluntee
Hi Hans,
Thanks for this quick albeit helpful review.
I had no objections to your comments so they all
are considered in the patch version 3.
On 12/20/2010 02:01 PM, Hans Verkuil wrote:
Hi Sylwester,
Here is a quick review of this second patch version.
Reviewed-by: Hans Verkuil
On Monday, D
Remove BKL ioctl and use unlocked_ioctl with core-assisted locking instead.
Signed-off-by: Pete Eberlein
diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c
index f5a46c4..a216d62 100644
--- a/drivers/media/video/s2255drv.c
+++ b/drivers/media/video/s2255drv.c
@@ -269,7
On Mon, Dec 20, 2010 at 1:54 PM, Theodore Kilgore
wrote:
>
>
> On Mon, 20 Dec 2010, Alex Deucher wrote:
>
>> On Sun, Dec 19, 2010 at 6:56 PM, Theodore Kilgore
>> wrote:
>> >
>> > Hans,
>> >
>> > Thanks for the helpful advice about how to set up a git tree for current
>> > development so that I ca
This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.
Results of the daily build of v4l-dvb:
date:Mon Dec 20 19:01:11 CET 2010
git master: 59365d136d205cc20fe666ca7f89b1c5001b0d5a
git media-master: gcc version: i6
Hi Linus,
Please pull from:
ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git
v4l_for_linus
For a series of fixes at v4l2 drivers. They fix an OOPS at bttv due to BKL
patches, a series of regressions that happened at gspca sonixj driver,
affecting most of the sonix Jpeg c
On Mon, 20 Dec 2010, Alex Deucher wrote:
> On Sun, Dec 19, 2010 at 6:56 PM, Theodore Kilgore
> wrote:
> >
> > Hans,
> >
> > Thanks for the helpful advice about how to set up a git tree for current
> > development so that I can get back into things.
> >
> > However, there is a problem with that
On Sat, 2010-12-18 at 12:31 +0100, Hans Verkuil wrote:
> Hi all,
>
> Now that the BKL patch series has been merged in 2.6.37 it is time to work
> on replacing .ioctl by .unlocked_ioctl in all v4l drivers.
>
> I've made an inventory of all drivers that still use .ioctl and I am looking
> for volun
Hello,
"crope" on #linuxtv irc helped me to understand the stuff in my
previous mail. So for other people who might want to understand that
also:
dvbsnoop reports snr without lock/antenna:
If there is no Lock, unc, ber and snr _aren't_ valid. So check
first whether you have a loc
Remove usage of BKL by usign per-device mutex.
Signed-off-by: Marek Szyprowski
CC: Pawel Osciak
---
drivers/media/video/mem2mem_testdev.c | 21 +
1 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/media/video/mem2mem_testdev.c
b/drivers/media/video/me
Add ID for NOON010PC30 camera chip and reserve ID range for
Siliconfile sensors.
Signed-off-by: Sylwester Nawrocki
Signed-off-by: Kyungmin Park
---
include/media/v4l2-chip-ident.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/media/v4l2-chip-ident.h b/includ
Add I2C/V4L2 subdev driver for Siliconfile NOON010PC30 CIF camera.
The driver implements basic functionality, i.e. CIF/QCIF/QQCIF
resolution and color format selection, automatic/manual color
balance control. Other functions like cropping, rotation/flip,
exposure etc. can be easily implemented if n
Hi all,
following is a third version of patches adding the I2C/subdev driver
for Siliconfile NOON010PC30 camera sensor with integrated ISP.
It includes mostly corrections after the review by Hans. Hopefully
it can be merged into 2.6.38 in the current form.
Changes since v1:
- reworked to new v4l
Please refer to this file for detailed documentation of
davinci vpbe v4l2 driver
Signed-off-by: Manjunath Hadli
Acked-by: Muralidharan Karicheri
Acked-by: Hans Verkuil
---
Documentation/video4linux/README.davinci-vpbe | 93 +
1 files changed, 93 insertions(+), 0 delet
This patch adds the build infra-structure for Davinci
VPBE dislay driver
Signed-off-by: Manjunath Hadli
Acked-by: Muralidharan Karicheri
Acked-by: Hans Verkuil
---
drivers/media/video/davinci/Kconfig | 22 ++
drivers/media/video/davinci/Makefile |2 ++
2 files change
This patch implements the overall device creation for the Video
display driver
Signed-off-by: Manjunath Hadli
Acked-by: Muralidharan Karicheri
Acked-by: Hans Verkuil
---
arch/arm/mach-davinci/dm644x.c | 164 ++-
arch/arm/mach-davinci/include/mach/dm644x.h
This patch implements tables for display timings,outputs and
other board related functionalities.
Signed-off-by: Manjunath Hadli
Acked-by: Muralidharan Karicheri
Acked-by: Hans Verkuil
---
arch/arm/mach-davinci/board-dm644x-evm.c | 79 +-
1 files changed, 66 inser
This patch adds the VENC or the Video encoder, whichis responsible
for the blending of al source planes and timing generation for Video
modes like NTSC, PAL and other digital outputs. the VENC implementation
currently supports COMPOSITE and COMPONENT outputs and NTSC and PAL
resolutions through the
This patch implements the coe functionality of the dislay driver,
mainly controlling the VENC and other encoders, and acting as
the one point interface for the man V4L2 driver.This implements
the cre of each of the V4L2 IOCTLs.
Signed-off-by: Manjunath Hadli
Acked-by: Muralidharan Karicheri
Acke
This patch implements the functionality of the OSD block
of the VPBE.The OSD in total supports 4 planes or Video
sources - 2 mainly RGB and 2 Video. The patch implements general
handling of all the planes, with specific emphasis on the Video
plane capabilities as the Video planes are supported thro
version8 : addressed on Sergei's comments
on:
1.Interchanged platform and board specific patches due to dependencies.
Manjunath Hadli (8):
davinci vpbe: V4L2 display driver for DM644X SoC
davinci vpbe: VPBE display driver
davinci vpbe: OSD(On Screen Display) block
davinci vpbe: VENC( Video
On Fri, Dec 17, 2010 at 21:59:23, Sergei Shtylyov wrote:
> Hello.
>
> Manjunath Hadli wrote:
>
> > This patch implements tables for display timings,outputs and other
> > board related functionalities.
>
> > Signed-off-by: Manjunath Hadli
> > Acked-by: Muralidharan Karicheri
> > Acked-by: Hans
Hans,
I can take a look at this (DM6467)conversion unless your colleague has
already started working on t.
-Manju
On Sun, Dec 19, 2010 at 02:48:05, Hans Verkuil wrote:
> On Saturday, December 18, 2010 16:38:29 Muralidharan Karicheri wrote:
> > Hans,
> >
> > For davinci drivers, I will be able
On Monday, December 20, 2010 13:48:51 Laurent Pinchart wrote:
> Hi Hans,
>
> On Monday 20 December 2010 13:45:45 Hans Verkuil wrote:
> > On Monday, December 20, 2010 13:35:28 Laurent Pinchart wrote:
> > > On Monday 20 December 2010 13:28:06 Hans Verkuil wrote:
> > > > On Monday, December 20, 2010
Hi Sylwester,
Here is a quick review of this second patch version.
Reviewed-by: Hans Verkuil
On Monday, December 06, 2010 13:24:58 Sylwester Nawrocki wrote:
> Add I2C/V4L2 subdev driver for Siliconfile NOON010PC30 CIF camera.
> The driver implements basic functionality, i.e. CIF/QCIF/QQCIF
> re
This is a copy and paste error. It should be using sizeof(cap->driver)
instead of sizeof(cap->card).
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/timblogiw.c b/drivers/media/video/timblogiw.c
index cf48aa9..ef1b7a5 100644
--- a/drivers/media/video/timblogiw.c
+++ b/drivers/medi
Hi Hans,
On Monday 20 December 2010 13:45:45 Hans Verkuil wrote:
> On Monday, December 20, 2010 13:35:28 Laurent Pinchart wrote:
> > On Monday 20 December 2010 13:28:06 Hans Verkuil wrote:
> > > On Monday, December 20, 2010 13:10:32 Mauro Carvalho Chehab wrote:
> > > > Em 18-12-2010 08:45, Hans Ve
On Monday, December 20, 2010 13:35:28 Laurent Pinchart wrote:
> Hi Hans,
>
> On Monday 20 December 2010 13:28:06 Hans Verkuil wrote:
> > On Monday, December 20, 2010 13:10:32 Mauro Carvalho Chehab wrote:
> > > Em 18-12-2010 08:45, Hans Verkuil escreveu:
> > > > On Saturday, December 18, 2010 01:54
Hi Hans,
On Friday 17 December 2010 20:57:32 Hans Verkuil wrote:
> On Friday, December 17, 2010 20:52:25 Hans Verkuil wrote:
> > On Friday, December 17, 2010 17:17:05 Laurent Pinchart wrote:
> > > Hi Hans,
> > >
> > > I've recently run into an issue when porting a sensor driver to the
> > > contr
Hi Hans,
On Monday 20 December 2010 13:28:06 Hans Verkuil wrote:
> On Monday, December 20, 2010 13:10:32 Mauro Carvalho Chehab wrote:
> > Em 18-12-2010 08:45, Hans Verkuil escreveu:
> > > On Saturday, December 18, 2010 01:54:41 Laurent Pinchart wrote:
> > >> On Friday 17 December 2010 18:09:39 Mau
On Monday, December 20, 2010 13:10:32 Mauro Carvalho Chehab wrote:
> Em 18-12-2010 08:45, Hans Verkuil escreveu:
> > On Saturday, December 18, 2010 01:54:41 Laurent Pinchart wrote:
> >> Hi Mauro,
> >>
> >> On Friday 17 December 2010 18:09:39 Mauro Carvalho Chehab wrote:
> >>> Em 14-12-2010 08:55, L
Em 18-12-2010 08:45, Hans Verkuil escreveu:
> On Saturday, December 18, 2010 01:54:41 Laurent Pinchart wrote:
>> Hi Mauro,
>>
>> On Friday 17 December 2010 18:09:39 Mauro Carvalho Chehab wrote:
>>> Em 14-12-2010 08:55, Laurent Pinchart escreveu:
Hi Mauro,
Please don't forget this pul
The media_devnode structure provides support for registering and
unregistering character devices using a dynamic major number. Reference
counting is handled internally, making device drivers easier to write
without having to solve the open/disconnect race condition issue over
and over again.
The c
As video hardware pipelines become increasingly complex and
configurable, the current hardware description through v4l2 subdevices
reaches its limits. In addition to enumerating and configuring
subdevices, video camera drivers need a way to discover and modify at
runtime how those subdevices are co
Drivers often need to associate pipeline objects to entities, and to
take stream state into account when configuring entities and links. The
pipeline API helps drivers manage that information.
When starting streaming, drivers call media_entity_pipeline_start(). The
function marks all entities conn
Create the following two ioctls and implement them at the media device
level to enumerate entities, pads and links.
- MEDIA_IOC_ENUM_ENTITIES: Enumerate entities and their properties
- MEDIA_IOC_ENUM_LINKS: Enumerate all pads and links for a given entity
Entity IDs can be non-contiguous. Userspac
Create the following ioctl and implement it at the media device level to
query device information.
- MEDIA_IOC_DEVICE_INFO: Query media device information
The ioctl and its data structure are defined in the new kernel header
linux/media.h available to userspace applications.
Signed-off-by: Laure
Hi everybody,
Here's the fourth version of the OMAP3 ISP driver patches, updated to
2.6.37-rc6 and the latest changes in the media controller and sub-device APIs.
You can find the patches in http://git.linuxtv.org/pinchartl/media.git as
usual (media-0004-omap3isp).
The "v4l: Fix a use-before-set
Instead of returning an error when receiving an ioctl call with an
unsupported command, forward the call to the subdev core::ioctl handler.
Signed-off-by: Laurent Pinchart
---
Documentation/video4linux/v4l2-framework.txt |5 +
drivers/media/video/v4l2-subdev.c|2 +-
2 fil
The later makes extensive use of structures defined in the former.
Signed-off-by: Laurent Pinchart
---
include/media/v4l2-ctrls.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
index 9b7bea9..3b133b7 100644
--- a/i
v4l2_queryctrl sets the step value based on the control type. That would
be fine if it used the control type stored in the V4L2 kernel control
object, not the one stored in the userspace ioctl structure that has
just been memset to 0. Fix this.
Signed-off-by: Laurent Pinchart
Acked-by: Hans Verku
From: Tuukka Toivonen
Add new/changed base address definitions and resources for
OMAP3630 ISP.
The OMAP3430 CSI2PHY block is same as the OMAP3630 CSIPHY2
block. But the later name is chosen as it gives more symmetry
to the names.
Signed-off-by: Tuukka Toivonen
Signed-off-by: Vimarsh Zutshi
Ac
From: Antti Koskipaa
This patch adds the VIDIOC_SUBDEV_S_CROP and G_CROP ioctls to the
userland API. CROPCAP is not implemented because it's redundant.
Signed-off-by: Antti Koskipaa
Signed-off-by: Laurent Pinchart
---
Documentation/DocBook/media-entities.tmpl |4 +
Documentation/
Some buggy sensors generate corrupt frames when the stream is started.
This new operation return the number of corrupt frames to skip when
starting the stream.
Signed-off-by: Laurent Pinchart
---
include/media/v4l2-subdev.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --gi
The omap3isp platform device requires platform data. Instead of
registering the device in omap2_init_devices(), export an
omap3_init_camera() function to fill the device structure with the
platform data pointer and register the device.
Signed-off-by: Laurent Pinchart
Acked-by: Tony Lindgren
---
For consistency with the V4L2_MBUS_FMT_Y10_1X10 format.
Signed-off-by: Laurent Pinchart
---
drivers/media/video/mt9m001.c|2 +-
drivers/media/video/mt9v022.c|4 ++--
drivers/media/video/ov6650.c | 10 +-
drivers/media/video/sh_mobile_csi2.c |6 +++---
V4L2 devices are media entities. As such they need to inherit from
(include) the media_entity structure.
When registering/unregistering the device, the media entity is
automatically registered/unregistered. The entity is acquired on device
open and released on device close.
Signed-off-by: Laurent
The three new ioctl VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL,
VIDIOC_SUBDEV_G_FRAME_INTERVAL and VIDIOC_SUBDEV_S_FRAME_INTERVAL can be
used to enumerate and configure a subdev's frame rate from userspace.
Two new video::g/s_frame_interval subdev operations are introduced to
support those ioctls. The exis
Add a v4l2_subdev_pad_ops structure for the operations that need to be
performed at the pad level such as format-related operations.
Pad format-related operations use v4l2_mbus_framefmt instead of
v4l2_format.
Signed-off-by: Laurent Pinchart
---
include/media/v4l2-subdev.h |5 +
1 files
Adding new pixel codes at the end of the enumeration will soon create a
mess, so group the pixel codes by type and sort them by bus_width, bits
per component, samples per pixel and order of subsamples.
As the codes are part of the kernel ABI their value can't change when a
new code is inserted in
From: Stanimir Varbanov
Used for storing subdev information per file handle and hold V4L2 file
handle.
Signed-off-by: Stanimir Varbanov
Signed-off-by: Antti Koskipaa
Signed-off-by: Laurent Pinchart
---
drivers/media/Kconfig |9
drivers/media/video/v4l2-subdev.c | 85 ++
This adds following formats:
- V4L2_MBUS_FMT_SRGGB10_1X10
- V4L2_MBUS_FMT_SGBRG10_1X10
- V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8
- V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8
- V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8
Signed-off-by: Sergio Aguirre
Signed-off-by: Laurent Pinchart
---
include/linux/v4l2-mediabus.h |7 +++
Add the following media bus format code definitions:
- V4L2_MBUS_FMT_SGRBG10_1X10 for 10-bit GRBG Bayer
- V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8 for 10-bit DPCM compressed GRBG Bayer
- V4L2_MBUS_FMT_YUYV16_1X16 for 8-bit YUYV on 16-bit bus
- V4L2_MBUS_FMT_UYVY16_1X16 for 8-bit UYVY on 16-bit bus
- V4L2_M
V4L2 sub-devices store pad formats and crop settings in the file handle.
To let drivers initialize those settings properly, add a file::open
operation that is called when the subdev is opened as well as a
corresponding file::close operation.
Signed-off-by: Laurent Pinchart
---
drivers/media/vide
The header defines the v4l2_mbus_framefmt structure which will be used
by the V4L2 subdevs userspace API.
Change the type of the v4l2_mbus_framefmt::code field to __u32, as enum
sizes can differ between different ABIs on the same architectures.
Signed-off-by: Laurent Pinchart
---
include/linux/
The v4l2_mbus_framefmt structure will be part of the public userspace
API and used (albeit indirectly) as an ioctl argument. As such, its size
must be fixed across userspace ABIs.
Replace the v4l2_field and v4l2_colorspace enums by __u32 fields.
Signed-off-by: Laurent Pinchart
---
include/linux
Hi everybody,
Here's the fifth version of the sub-device pad-level operations patches.
Nothing new under the sun, the patches are just rebased on top of 2.6.36-rc7
and the latest media controller API.
Antti Koskipaa (1):
v4l: v4l2_subdev userspace crop API
Laurent Pinchart (11):
v4l: Move th
The pointer will later be used to register/unregister media entities
when registering/unregistering a v4l2_subdev or a video_device.
With the introduction of media devices, device drivers need to store a
pointer to a driver-specific structure in the device's drvdata.
v4l2_device can't claim owners
V4L2 subdevices are media entities. As such they need to inherit from
(include) the media_entity structure.
When registering/unregistering the subdevice, the media entity is
automatically registered/unregistered. The entity is acquired on device
open and released on device close.
Signed-off-by: L
From: Sakari Ailus
Basically these are the interface functions:
media_entity_get() - acquire entity
media_entity_put() - release entity
If the entity is of node type, the power change is distributed to all
connected entities. For non-nodes it only affects that very node. A
mutex is used to seri
Create the following ioctl and implement it at the media device level to
setup links.
- MEDIA_IOC_SETUP_LINK: Modify the properties of a given link
The only property that can currently be modified is the ENABLED link
flag to enable/disable a link. Links marked with the IMMUTABLE link flag
can not
The media_device structure abstracts functions common to all kind of
media devices (v4l2, dvb, alsa, ...). It manages media entities and
offers a userspace API to discover and configure the media device
internal topology.
Signed-off-by: Laurent Pinchart
---
Documentation/DocBook/media-entities.t
From: Sakari Ailus
Add media entity graph traversal. The traversal follows enabled links by
depth first. Traversing graph backwards is prevented by comparing the next
possible entity in the graph with the previous one. Multiply connected
graphs are thus not supported.
Signed-off-by: Sakari Ailus
Hi everybody,
Here is the seventh version of the media controller core and V4L2 patches.
the first one to be sent outside of the linux-media mailing list.
Quick reminder for those who missed the previous version. let me quote the
documentation (Documentation/DocBook/v4l/media-controller.xml).
"D
The function isn't small or performance sensitive enough to be inlined.
Signed-off-by: Laurent Pinchart
---
drivers/media/video/v4l2-subdev.c | 42 +---
include/media/v4l2-subdev.h | 16 +
2 files changed, 31 insertions(+), 27 deletions(-)
d
From: Sakari Ailus
Provide v4l2_subdevs with v4l2_event support. Subdev drivers only need very
little to support events.
Signed-off-by: Sakari Ailus
Signed-off-by: David Cohen
Signed-off-by: Laurent Pinchart
---
Documentation/video4linux/v4l2-framework.txt | 18 ++
drivers/media/video/
Create a device node named subdevX for every registered subdev.
As the device node is registered before the subdev core::s_config
function is called, return -EGAIN on open until initialization
completes.
Signed-off-by: Laurent Pinchart
Signed-off-by: Vimarsh Zutshi
---
Documentation/video4linu
v4l2_i2c_new_subdev is a thin wrapper around v4l2_i2c_new_subdev_cfg,
which is itself a wrapper around v4l2_i2c_new_subdev_board.
The intermediate v4l2_i2c_new_subdev_cfg function is called directly by
the ivtv and cafe-ccic drivers only. Merge it with v4l2_i2c_new_subdev
and use v4l2_i2c_new_subd
Pass the control-related ioctls to the subdev driver through the control
framework.
Signed-off-by: Laurent Pinchart
---
Documentation/video4linux/v4l2-framework.txt | 16
drivers/media/video/v4l2-subdev.c| 25 +
2 files changed, 41 inserti
There's no reason to require subdevices to implement the core
operations. Remove the check for non-NULL core operations when
initializing the subdev.
Signed-off-by: Laurent Pinchart
---
include/media/v4l2-subdev.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/include
Hi everybody,
Here's the fifth version of the V4L2 subdev userspace API patches. Nothing
new under the sun, the patches have just been rebased on top of 2.6.37-rc6.
You can find them as usual in http://git.linuxtv.org/pinchartl/media.git
(media-0001-subdev-devnode branch).
Laurent Pinchart (6):
The two functions are mostly identical. They handle the copy_from_user
and copy_to_user operations related with V4L2 ioctls and call the real
ioctl handler.
Create a __video_usercopy function that implements the core of
video_usercopy and video_ioctl2, and call that function from both.
Signed-off
Hi Sergio,
Em 27-08-2010 11:57, Aguirre, Sergio escreveu:
> Hi,
>
> I see that in current videobuf library, for DMA SG code, these functions fail
> when
> Detecting a page in Highmem region:
>
> - videobuf_pages_to_sg
> - videobuf_vmalloc_to_sg
>
> Now, what's the real reason to not allow hand
74 matches
Mail list logo
