[RESEND: GIT PATCHES FOR 2.6.36] cx23885, cx25840, v4l2_subdev: I/O pin config and CX23885 chip IR Rx

2010-07-31 Thread Andy Walls
Mauro, This is a resend of my previous pull request, because I have added 4 new patches. Please pull these changes for 2.6.36. They are based off of the v4l-dvb/other branch from a few weeks ago, IIRC. These changes implement CX23885 chip IR Rx support, which different people seem to bug me abo

[PATCH 0/7] Port dvb-usb to ir-core

2010-07-31 Thread Mauro Carvalho Chehab
This patch series starts the proccess of moving dvb-usb drivers to use the new Remote Controller core. It adds support for rc-core at dvb-usb core, while keeping support for the legacy mode. One driver (dib0700) were ported to the new rc-core mode, as an example for the low-level driver maintainer

[PATCH 7/7] V4L/DVB: dib0700: avoid bad repeat

2010-07-31 Thread Mauro Carvalho Chehab
a 250ms delay is too low for this device. It ends by producing false repeat events. Increase the delay time to 500 ms to avoid troubles. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb/dvb-usb/dib0700_core.c b/drivers/media/dvb/dvb-usb/dib0700_core.c index 164fa9c..a05d955 1

[PATCH 6/7] V4L/DVB: Port dib0700 to rc-core

2010-07-31 Thread Mauro Carvalho Chehab
Use the new rc-core handler at dvb-usb-remote for dib0700 driver. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb/dvb-usb/dib0700_core.c b/drivers/media/dvb/dvb-usb/dib0700_core.c index 527b1e6..164fa9c 100644 --- a/drivers/media/dvb/dvb-usb/dib0700_core.c +++ b/drivers/medi

[PATCH 5/7] V4L/DVB: Add a keymap file with dib0700 table

2010-07-31 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab create mode 100644 drivers/media/IR/keymaps/rc-dib0700-big.c diff --git a/drivers/media/IR/keymaps/Makefile b/drivers/media/IR/keymaps/Makefile index 86d3d1f..85330d1 100644 --- a/drivers/media/IR/keymaps/Makefile +++ b/drivers/media/IR/keymaps/Makefile @@

[PATCH 4/7] V4L/DVB: dvb-usb: add support for rc-core mode

2010-07-31 Thread Mauro Carvalho Chehab
Allows dvb-usb drivers to use rc-core, instead of the legacy implementation. No driver were ported yet to rc-core, so, some small adjustments may be needed, when starting to migrate the drivers. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-remote.c b/driv

[PATCH 3/7] V4L/DVB: dvb-usb: prepare drivers for using rc-core

2010-07-31 Thread Mauro Carvalho Chehab
This is a big patch, yet trivial. It just move the RC properties to a separate struct, in order to prepare the dvb-usb drivers to use rc-core. There's no change on the behavior of the drivers. With this change, it is possible to have both legacy and rc-core based code inside the dvb-usb-remote, al

[PATCH 2/7] V4L/DVB: dvb-usb: get rid of struct dvb_usb_rc_key

2010-07-31 Thread Mauro Carvalho Chehab
dvb-usb has its own IR handle code. Now that we have a Remote Controller subsystem, we should start using it. So, remove this struct, in favor of the similar struct defined at the RC subsystem. This is a big, but trivial patch. It is a 3 line delect, plus lots of rename on several dvb-usb files.

[PATCH 1/7] V4L/DVB: Partially revert commit da7251dd0bca6c17571be2bd4434b9779dea72d8

2010-07-31 Thread Mauro Carvalho Chehab
By mistake, changeset da7251dd0bca6c17571be2bd4434b9779dea72d8 reverted the following commits: commit 6795f9a1ac9e85deb96a49e46b29c809214bf5ea commit d69861a25a54ef1cd6ee92f5ceb6ff2c01d84803 commit 1ba30538e2d125ce821622ac1f5e7ef31d856077 This patch partially reverts the or

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 17:53 -0400, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 2:51 PM, Andy Walls wrote: > > On Sat, 2010-07-31 at 14:14 -0400, Jon Smirl wrote: > >> On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus > >> wrote: > >> > Hi Jon, > >> > > >> > on 31 Jul 10 at 12:25, Jon Smirl wr

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Jon Smirl
On Sat, Jul 31, 2010 at 2:51 PM, Andy Walls wrote: > On Sat, 2010-07-31 at 14:14 -0400, Jon Smirl wrote: >> On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus >> wrote: >> > Hi Jon, >> > >> > on 31 Jul 10 at 12:25, Jon Smirl wrote: >> >> On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls >> >> wrot

Re: [PATCH 06/20] mt9m111: changed MAX_{HEIGHT,WIDTH} values to silicon pixelcount

2010-07-31 Thread Robert Jarzmik
Michael Grzeschik writes: > Signed-off-by: Philipp Wiesner > Signed-off-by: Michael Grzeschik > --- > drivers/media/video/mt9m111.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c > index 5f0c55e..20

Re: [PATCH 04/20] mt9m111: added new bit offset defines

2010-07-31 Thread Robert Jarzmik
Michael Grzeschik writes: > Signed-off-by: Philipp Wiesner > Signed-off-by: Michael Grzeschik OK for me. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

[PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

2010-07-31 Thread Steven Toth
Mauro, Analog Encoder and VBI support in the SAA7164 tree, for the HVR2200 and HVR2250 cards. Please pull from http://www.kernellabs.com/hg/~stoth/saa7164-v4l - saa7164: basic definitions for -encoder.c - saa7164: Add some encoder firmwares message types and structs - saa7164: conver

Re: [PATCH 03/20] mt9m111: register cleanup hex to dec bitoffset

2010-07-31 Thread Robert Jarzmik
Michael Grzeschik writes: > Signed-off-by: Philipp Wiesner > Signed-off-by: Michael Grzeschik OK for me (the formal ack will be once we finish the review). Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.k

Re: [PATCH 02/20] mt9m111: init chip after read CHIP_VERSION

2010-07-31 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > On Fri, 30 Jul 2010, Michael Grzeschik wrote: > >> Moved mt9m111_init after the chip version detection passage: I >> don't like the idea of writing on a device we haven't identified >> yet. > > In principle it's correct, but what do you do, if a chip cannot be prob

Re: [PATCH 01/20] mt9m111: Added indication that MT9M131 is supported by this driver

2010-07-31 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> Why this one ? It signals a sensor was successfully detected. Maybe a >> replacement from MT9M11x to MT9M1xx would be better ? Or if your real >> intention >> is to remove the message, then transform it to dev_dbg(), and say why you >> did it >> in the commit me

Re: [PATCH 05/20] mt9m111: added default row/col/width/height values

2010-07-31 Thread Guennadi Liakhovetski
On Fri, 30 Jul 2010, Michael Grzeschik wrote: > Signed-off-by: Philipp Wiesner > Signed-off-by: Michael Grzeschik > --- > drivers/media/video/mt9m111.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c

Re: [PATCH 01/20] mt9m111: Added indication that MT9M131 is supported by this driver

2010-07-31 Thread Guennadi Liakhovetski
On Sat, 31 Jul 2010, Robert Jarzmik wrote: > Michael Grzeschik writes: > > > From: Philipp Wiesner > > > > Added this info to Kconfig and mt9m111.c, some comment cleanup, > > replaced 'mt9m11x'-statements by clarifications or driver name. > > Driver is fully compatible to mt9m131 which has only

Re: [PATCH 01/20] mt9m111: Added indication that MT9M131 is supported by this driver

2010-07-31 Thread Robert Jarzmik
Michael Grzeschik writes: > From: Philipp Wiesner > > Added this info to Kconfig and mt9m111.c, some comment cleanup, > replaced 'mt9m11x'-statements by clarifications or driver name. > Driver is fully compatible to mt9m131 which has only additional functions > compared to mt9m111. Those aren't

Re: [PATCH 02/20] mt9m111: init chip after read CHIP_VERSION

2010-07-31 Thread Guennadi Liakhovetski
On Fri, 30 Jul 2010, Michael Grzeschik wrote: > Moved mt9m111_init after the chip version detection passage: I > don't like the idea of writing on a device we haven't identified > yet. In principle it's correct, but what do you do, if a chip cannot be probed, before it is initialised / enabled?

Re: [PATCH 01/20] mt9m111: Added indication that MT9M131 is supported by this driver

2010-07-31 Thread Guennadi Liakhovetski
On Fri, 30 Jul 2010, Michael Grzeschik wrote: > From: Philipp Wiesner > > Added this info to Kconfig and mt9m111.c, some comment cleanup, > replaced 'mt9m11x'-statements by clarifications or driver name. > Driver is fully compatible to mt9m131 which has only additional functions > compared to mt

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-07-31 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Sat Jul 31 19:00:17 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14993:9652f85e688a git master:

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Andy Walls
On Sat, 2010-07-31 at 14:14 -0400, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus > wrote: > > Hi Jon, > > > > on 31 Jul 10 at 12:25, Jon Smirl wrote: > >> On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls > >> wrote: > >>> I think you won't be able to fix the problem conclus

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Jon Smirl
On Sat, Jul 31, 2010 at 2:14 PM, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus > wrote: >> Hi Jon, >> >> on 31 Jul 10 at 12:25, Jon Smirl wrote: >>> On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls >>> wrote: I think you won't be able to fix the problem conclusively e

Re: [PULL] http://www.kernellabs.com/hg/~stoth/cx23885-mpx

2010-07-31 Thread Andy Walls
On Sat, 2010-07-31 at 12:31 -0400, Steven Toth wrote: > Mauro, > > Please pull from http://www.kernellabs.com/hg/~stoth/cx23885-mpx > >- cx23885: prepare the cx23885 makefile for alsa support >- cx23885: merge mijhail's header changes for alsa >- cx23885: ALSA support >- cx238

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Jon Smirl
On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus wrote: > Hi Jon, > > on 31 Jul 10 at 12:25, Jon Smirl wrote: >> On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls >> wrote: >>> I think you won't be able to fix the problem conclusively either way.  A >>> lot of how the chip's clocks should be progr

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Christoph Bartelmus
Hi Jon, on 31 Jul 10 at 12:25, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls > wrote: >> I think you won't be able to fix the problem conclusively either way.  A >> lot of how the chip's clocks should be programmed depends on how the >> GPIOs are used and what crystal is used. >

[PATCH] IR keymap: Add print button for HP OEM version of MCE remote

2010-07-31 Thread Andy Walls
This patch adds a defintion for the "Print" button found on HP OEM versions of the MCE remote. All of the other keys found on the HP OEM version of the remote match the other keys as already defined. Because, who doesn't need "remote printing", while one is sitting on the couch across from one's

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 12:25 -0400, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls wrote: > > I think you won't be able to fix the problem conclusively either way. A > > lot of how the chip's clocks should be programmed depends on how the > > GPIOs are used and what crystal is us

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 12:25 -0400, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls wrote: > > I think you won't be able to fix the problem conclusively either way. A > > lot of how the chip's clocks should be programmed depends on how the > > GPIOs are used and what crystal is us

[PULL] http://www.kernellabs.com/hg/~stoth/cx23885-mpx

2010-07-31 Thread Steven Toth
Mauro, Please pull from http://www.kernellabs.com/hg/~stoth/cx23885-mpx - cx23885: prepare the cx23885 makefile for alsa support - cx23885: merge mijhail's header changes for alsa - cx23885: ALSA support - cx23885: core changes requireed for ALSA - cx23885: add definitions for

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Jon Smirl
On Sat, Jul 31, 2010 at 11:12 AM, Andy Walls wrote: > I think you won't be able to fix the problem conclusively either way.  A > lot of how the chip's clocks should be programmed depends on how the > GPIOs are used and what crystal is used. > > I suspect many designers will use some reference desi

Re: [PATCH] Fix module dependency selection for Mantis driver

2010-07-31 Thread VDR User
On Fri, Jun 11, 2010 at 8:11 PM, VDR User wrote: > This patch adds missing module dependencies to the Mantis Kconfig file > so that they are selected automatically when the user enables Mantis. > > Signed-off-by: Derek Kelly > -- > > --- v4l-dvb.orig/linux/drivers/media/dvb/mantis/Kconfig

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Andy Walls
On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: > On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: > > On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl wrote: > > >>> > > > >>> > > >>> Should that be a <= or >= instead of !=? > > >>> + if (pll_freq != 1000) > > >> > > >> This is how

[PATCH 08/13] IR: Allow not to compile keymaps in.

2010-07-31 Thread Maxim Levitsky
Currently, ir device registration fails if keymap requested by driver is not found. Fix that by always compiling in the empty keymap, and using it as a failback. Signed-off-by: Maxim Levitsky Acked-by: Jarod Wilson --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

2010-07-31 Thread Maxim Levitsky
Some ir input devices have small buffer, and interrupt the host each time it is full (or half full) Add a helper that automaticly handles timeouts, and also automaticly merges samples of same time (space-space) Such samples might be placed by hardware because size of sample in the buffer is small

[PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- MAINTAINERS |6 + drivers/media/IR/Kconfig | 14 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 595 + drivers/media/IR/ene_ir.h | 51 ++--- 5 files changed, 265 insertions(+),

[PATCH 10/13] IR: extend interfaces to support more device settings

2010-07-31 Thread Maxim Levitsky
LIRC: add new IOCTL that enables learning mode (wide band receiver) Still missing features: carrier report & timeout reports. Will need to pack these into ir_raw_event Signed-off-by: Maxim Levitsky --- .../DocBook/v4l/lirc_device_interface.xml | 16 +++ drivers/media/IR/ir-core-priv.

[PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found.

2010-07-31 Thread Maxim Levitsky
This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-keytable.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 34b9c0

[PATCH 07/13] IR: NECX: support repeat

2010-07-31 Thread Maxim Levitsky
This adds support for repeat detecting for NECX variant Tested with uneversal remote Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |2 ++ drivers/media/IR/ir-nec-decoder.c | 23 +-- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH 06/13] IR: nec decoder: fix repeat.

2010-07-31 Thread Maxim Levitsky
Repeat space is 4 units, not 8. Current code would never trigger a repeat. However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky Reviewed-by: Andy Walls --- drivers/media/IR/ir-nec-decoder.c |2 +- 1 files changed, 1 insertions(+), 1 d

[PATCH 05/13] IR: JVC: make repeat work

2010-07-31 Thread Maxim Levitsky
Currently, jvc decoder will attempt misdetect next press as a repeat of last keypress, therefore second keypress isn't detected. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-jvc-decoder.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/drivers/medi

[PATCH 03/13] IR: replace spinlock with mutex.

2010-07-31 Thread Maxim Levitsky
Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1 files changed, 14 inser

[PATCH 04/13] IR: replace workqueue with kthread

2010-07-31 Thread Maxim Levitsky
It is perfectly possible to have ir_raw_event_work running concurently on two cpus, thus we must protect it from that situation. This stems from the fact that if hardware sends short packets of samples we might end up queueing the work item more times that nessesary. Such job isn't well suited fo

[PATCH 02/13] IR: minor fixes:

2010-07-31 Thread Maxim Levitsky
* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |4 +--- drivers/media/IR/ir-lirc-codec.c

[PATCH 01/13] IR: Kconfig fixes

2010-07-31 Thread Maxim Levitsky
Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR/Kconfig index e557ae0..fc

[PATCH 0/9 v4] IR: few fixes, additions and ENE driver

2010-07-31 Thread Maxim Levitsky
Hi, 4th revision of my patches below: Changes: * more carefull repeat support in NECX protocol * added documentation for wide band mode ioctl * fix for 64 bit divide * updated summary of patches, and preserved few * Acked/Reviewed by tags you gave me. Best regards, Maxim Levitsky -- T

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 10:37 -0400, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 10:28 AM, Maxim Levitsky > wrote: > > On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: > >> On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: > >> > On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: > >> >

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Jon Smirl
On Sat, Jul 31, 2010 at 10:28 AM, Maxim Levitsky wrote: > On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: >> On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: >> > On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: >> > > On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl wrote: >> > > > On

[PATCH] Nova-S-Plus audio line input

2010-07-31 Thread lawrence rust
Hi everyone, This patch adds audio DMA capture and ALSA mixer elements for the line input jack of the Hauppauge Nova-S-plus DVB-S PCI card. I'm using a Hauppauge Nova-S-plus PCI card to watch sat TV and it's been very robust - thanks to everyone here. I have one minor niggle - when I use it with

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: > On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: > > On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: > > > On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl wrote: > > > > On Fri, Jul 30, 2010 at 7:54 AM, Maxim Levitsky > > > > wrote:

Re: [PULL] soc-camera, sh-vou, v4l2 for 2.6.36

2010-07-31 Thread Guennadi Liakhovetski
Hi Mauro On Fri, 30 Jul 2010, Mauro Carvalho Chehab wrote: > Em 29-07-2010 06:31, Guennadi Liakhovetski escreveu: > > Hi Mauro > > > > The following changes since commit c57fd88318988f17731e446fe1d8498f506fdd44: > > > > V4L/DVB: uvcvideo: Add support for Manta MM-353 Plako (2010-07-05 > > 19

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Andy Walls
On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: > On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: > > On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl wrote: > > > On Fri, Jul 30, 2010 at 7:54 AM, Maxim Levitsky > > > wrote: > > > > > > > + pll_freq = (ene_hw_read_reg(dev, ENE_PL

Re: Handling of large keycodes

2010-07-31 Thread Mauro Carvalho Chehab
Hi Dmitry, Em 31-07-2010 06:19, Dmitry Torokhov escreveu: > Hi Mauro, > > I finally got a chance to review the patches adding handling of large > scancodes to input core and there are a few things with this approach > that I do not like. Thanks for the review! > First of all I do not think that

Re: Handling of large keycodes

2010-07-31 Thread Stefan Richter
Stefan Richter wrote: > - I take it from your description that scan codes are fundamentally > variable-length data. How about defining it as __u8 scancode[0]? Forget this; that would make it difficult to extend the ABI later by adding more struct members. -- Stefan Richter -=-==-=- -==

Re: Handling of large keycodes

2010-07-31 Thread Stefan Richter
Dmitry Torokhov wrote: > --- a/include/linux/input.h > +++ b/include/linux/input.h > @@ -56,22 +56,35 @@ struct input_absinfo { > __s32 resolution; > }; > > -struct keycode_table_entry { > - __u32 keycode; /* e.g. KEY_A */ > - __u32 index;/* Index for the given

Re: [PATCH 00/20] MT9M111/MT9M131

2010-07-31 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Michael > > Thanks for the patches, and for taking care about my holiday - now I will > definitely not have to be bored, while lying around on tropical beaches of > Denmark;) Same thing in here, if my wife lets me play with my computer :) I'll review them as

Re: [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 10:10 +0200, Christoph Bartelmus wrote: > Hi Maxim, > > on 31 Jul 10 at 01:01, Maxim Levitsky wrote: > > On Fri, 2010-07-30 at 23:22 +0200, Christoph Bartelmus wrote: > [...] > >>> +#define LIRC_SET_WIDEBAND_RECEIVER _IOW('i', 0x0023, __u32) > >> > >> If you really w

Handling of large keycodes

2010-07-31 Thread Dmitry Torokhov
Hi Mauro, I finally got a chance to review the patches adding handling of large scancodes to input core and there are a few things with this approach that I do not like. First of all I do not think that we should be working with scancode via a pointer as it requires additional compat handling whe

Re: [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

2010-07-31 Thread Christoph Bartelmus
Hi Maxim, on 31 Jul 10 at 01:01, Maxim Levitsky wrote: > On Fri, 2010-07-30 at 23:22 +0200, Christoph Bartelmus wrote: [...] >>> +#define LIRC_SET_WIDEBAND_RECEIVER _IOW('i', 0x0023, __u32) >> >> If you really want this new ioctl, then it should be clarified how it >> behaves in relation t