[no subject]

2010-04-01 Thread Richard Smith
http://rapidshare.com/files/370883117/new14.0.exe -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/15] ir-core: Several improvements to allow adding LIRC and decoder plugins

2010-04-01 Thread Jon Smirl
On Thu, Apr 1, 2010 at 1:56 PM, Mauro Carvalho Chehab wrote: > This series of 15 patches improves support for IR, as discussed at the > "What are the goals for the architecture of an in-kernel IR system?" > thread. > > It basically adds a raw decoder layer at ir-core, allowing decoders to plug > i

[PATCH 2/2] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-04-01 Thread Wolfram Sang
Made necessary by 6992f5334995af474c2b58d010d08bc597f0f2fe. Prevents further "key xxx not in .data" bug-reports. Although some attributes could probably be converted to static ones, this is left for people having hardware to test. Found by this semantic patch: @ init @ type T; identifier A; @@

Aw: Re: V4L-DVB drivers and BKL

2010-04-01 Thread hermann-pitton
Hi! - Original Nachricht Von: Mauro Carvalho Chehab An: Devin Heitmueller Datum: 02.04.2010 01:10 Betreff: Re: V4L-DVB drivers and BKL > Devin Heitmueller wrote: > > On Thu, Apr 1, 2010 at 5:07 PM, Mauro Carvalho Chehab > > wrote: > >>> Most i2c locks typically are only h

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: > On Thu, Apr 1, 2010 at 5:07 PM, Mauro Carvalho Chehab > wrote: >>> Most i2c locks typically are only held for the duration of a single >>> i2c transaction. What you are proposing would likely result in just >>> about every function having to explicitly lock/unlock, whic

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Devin Heitmueller
On Thu, Apr 1, 2010 at 5:07 PM, Mauro Carvalho Chehab wrote: >> Most i2c locks typically are only held for the duration of a single >> i2c transaction.  What you are proposing would likely result in just >> about every function having to explicitly lock/unlock, which just >> seems bound to be erro

Re: [RFC] Serialization flag example

2010-04-01 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: >> Maybe a better alternative would be to pass to the V4L2 core, optionally, >> some lock, >> used internally on the driver. This approach will still be pedantic, as all >> ioctls will >> keep being serialized, but at least the driver will need to explicitly >> handle the loc

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Devin Heitmueller
On Thu, Apr 1, 2010 at 5:16 PM, Mauro Carvalho Chehab >> What was the reason behind the asynchronous loading? In general it simplifies >> things a lot if you load modules up front. > > The reason is to avoid a dead lock: driver A depends on symbols on B (the > other driver init code) that depends

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: > On Thursday 01 April 2010 20:29:52 Devin Heitmueller wrote: >> On Thu, Apr 1, 2010 at 1:36 PM, Mauro Carvalho Chehab >> wrote: >>> If you take a look at em28xx-dvb, it is not lock-protected. If the bug is >>> due >>> to the async load, we'll need to add the same locking at *

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Hans Verkuil
On Thursday 01 April 2010 20:56:19 Devin Heitmueller wrote: > On Thu, Apr 1, 2010 at 2:42 PM, Mauro Carvalho Chehab > wrote: > > If the i2c lock was toggled to digital mode, then it means that the i2c > > code is being in use simultaneously by analog and digital mode. It also > > means that an i2c

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: > On Thu, Apr 1, 2010 at 2:42 PM, Mauro Carvalho Chehab > wrote: >> If the i2c lock was toggled to digital mode, then it means that the i2c >> code is being in use simultaneously by analog and digital mode. It also >> means that an i2c IR device, or alsa will have troubles

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Hans Verkuil
On Thursday 01 April 2010 20:29:52 Devin Heitmueller wrote: > On Thu, Apr 1, 2010 at 1:36 PM, Mauro Carvalho Chehab > wrote: > > If you take a look at em28xx-dvb, it is not lock-protected. If the bug is > > due > > to the async load, we'll need to add the same locking at *alsa and *dvb > > parts

Re: [RFC] Serialization flag example

2010-04-01 Thread Hans Verkuil
On Thursday 01 April 2010 20:24:12 Mauro Carvalho Chehab wrote: > Hans, > > > Hans Verkuil wrote: > > I made a quick implementation which is available here: > > > > http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-serialize > > > > It's pretty easy to use and it also gives you a very simple way to b

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: WARNINGS

2010-04-01 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu Apr 1 19:00:20 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14536:a539e5b68945 git master:

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Devin Heitmueller
On Thu, Apr 1, 2010 at 2:42 PM, Mauro Carvalho Chehab wrote: > If the i2c lock was toggled to digital mode, then it means that the i2c > code is being in use simultaneously by analog and digital mode. It also > means that an i2c IR device, or alsa will have troubles also. So, we > really need one

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: > On Thu, Apr 1, 2010 at 1:36 PM, Mauro Carvalho Chehab > wrote: >> If you take a look at em28xx-dvb, it is not lock-protected. If the bug is due >> to the async load, we'll need to add the same locking at *alsa and *dvb >> parts of em28xx. > > Yes, that is correct. The

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Devin Heitmueller
On Thu, Apr 1, 2010 at 1:36 PM, Mauro Carvalho Chehab wrote: > If you take a look at em28xx-dvb, it is not lock-protected. If the bug is due > to the async load, we'll need to add the same locking at *alsa and *dvb > parts of em28xx. Yes, that is correct. The problem effects both dvb and alsa, a

Re: [RFC] Serialization flag example

2010-04-01 Thread Mauro Carvalho Chehab
Hans, Hans Verkuil wrote: > I made a quick implementation which is available here: > > http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-serialize > > It's pretty easy to use and it also gives you a very simple way to block > access to the video device nodes until all have been allocated by simply >

[PATCH 06/15] V4L/DVB: ir-core/saa7134: Move ir keyup/keydown code to the ir-core

2010-04-01 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/IR/ir-nec-decoder.c b/drivers/media/IR/ir-nec-decoder.c index 16360eb..a58c717 100644 --- a/drivers/media/IR/ir-nec-decoder.c +++ b/drivers/media/IR/ir-nec-decoder.c @@ -30,37 +30,35 @@ #define MIN_BIT0_TIME 36 #define MAX_BI

[PATCH 05/15] V4L/DVB: ir-core: add two functions to report keyup/keydown events

2010-04-01 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 2d9ba84..ab60730 100644 --- a/drivers/media/IR/ir-keytable.c +++ b/drivers/media/IR/ir-keytable.c @@ -364,7 +364,7 @@ static int ir_setkeycode(struct input_dev *dev, * * Thi

[PATCH 14/15] V4L/DVB: cx88: Only start IR if the input device is opened

2010-04-01 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/video/cx88/cx88-input.c b/drivers/media/video/cx88/cx88-input.c index 8f1b846..a7214d0 100644 --- a/drivers/media/video/cx88/cx88-input.c +++ b/drivers/media/video/cx88/cx88-input.c @@ -39,6 +39,10 @@ struct cx88_IR { struct

[PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-01 Thread Mauro Carvalho Chehab
Adds a method to pass IR raw pulse/code events into ir-core. This is needed in order to support LIRC. It also helps to move common code from the drivers into the core. In order to allow testing, it implements a simple NEC protocol decoder at ir-nec-decoder.c file. The logic is about the same used

[PATCH 12/15] V4L/DVB: ir-core: rename sysfs remote controller class from ir to rc

2010-04-01 Thread Mauro Carvalho Chehab
IR is an alias for Infrared Remote, while RC is an alias for Remote Controller. While currently all implementations are with Infrared Remote Controller, this subsystem is not meant to be used only by IR type of RC's. So, as discussed on both linux-media and linux-input, the better is to rename the

[PATCH 01/15] V4L/DVB: ir-core: be less pedantic with RC protocol name

2010-04-01 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/IR/ir-sysfs.c b/drivers/media/IR/ir-sysfs.c index bbddf2f..ee6b36d 100644 --- a/drivers/media/IR/ir-sysfs.c +++ b/drivers/media/IR/ir-sysfs.c @@ -92,7 +92,7 @@ static ssize_t store_protocol(struct device *d, buf = strsep((c

[PATCH 02/15] V4L/DVB: saa7134: use a full scancode table for M135A

2010-04-01 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/IR/ir-keymaps.c b/drivers/media/IR/ir-keymaps.c index dfc777b..55e7acd 100644 --- a/drivers/media/IR/ir-keymaps.c +++ b/drivers/media/IR/ir-keymaps.c @@ -122,55 +122,57 @@ static struct ir_scancode ir_codes_avermedia_dvbt[] = { };

[PATCH 15/15] V4L/DVB: input: Add support for EVIO[CS]GKEYCODEBIG

2010-04-01 Thread Mauro Carvalho Chehab
Several devices use a high number of bits for scancodes. One important group is the Remote Controllers. Some new protocols like RC-6 define a scancode space of 64 bits. The current EVIO[CS]GKEYCODE ioctls allow replace the scancode/keycode translation tables, but it is limited to up to 32 bits for

[PATCH 03/15] V4L/DVB: saa7134: add code to allow changing IR protocol

2010-04-01 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c index d7e73de..8187928 100644 --- a/drivers/media/video/saa7134/saa7134-input.c +++ b/drivers/media/video/saa7134/saa7134-input.c @@ -420,6 +420,10 @@ stati

[PATCH 13/15] V4L/DVB: ir-core: Add callbacks for input/evdev open/close on IR core

2010-04-01 Thread Mauro Carvalho Chehab
Especially when IR needs to do polling, it generates lots of wakeups per second. This makes no sense, if the input event device is closed. Adds a callback handler to the IR hardware driver, to allow registering an open/close ops. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/I

[PATCH 07/15] V4L/DVB: saa7134: don't wait too much to generate an IR event on raw_decode

2010-04-01 Thread Mauro Carvalho Chehab
At raw_decode mode, the key is processed after the end of a timer. The previous code resets the timer every time something is received at the IR port. While this works fine with IR's that don't implement repeat, like Avermedia RM-JX IR, it keeps waiting until keydown, on IR's that implement NEC rep

[PATCH 08/15] V4L/DVB: ir-core: dynamically load the compiled IR protocols

2010-04-01 Thread Mauro Carvalho Chehab
Instead of hardcoding the protocols into ir-core, add a register interface for the IR protocol decoders, and convert ir-nec-decoder into a client of ir-core. With this approach, it is possible to dynamically load the needed IR protocols, and to add a RAW IR interface module, registered as one IR r

[PATCH 09/15] V4L/DVB: ir-core: prepare to add more operations for ir decoders

2010-04-01 Thread Mauro Carvalho Chehab
Some decoders and a lirc_dev interface may need some other operations to work. For example: IR device register/unregister and ir_keydown events may need to be tracked. As some operations can occur in interrupt time, and a lock is needed to prevent un-registering a decode while decoding a key, the

[PATCH 10/15] V4L/DVB: ir-nec-decoder: Add sysfs node to enable/disable per irrcv

2010-04-01 Thread Mauro Carvalho Chehab
With the help of raw_register/raw_unregister, adds a sysfs group associated with the decoder, inside the corresponding irrcv node. Writing 1 to nec_decoder/enabled enables the decoder, while writing 0 disables it. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/IR/ir-nec-decoder

[PATCH 00/15] ir-core: Several improvements to allow adding LIRC and decoder plugins

2010-04-01 Thread Mauro Carvalho Chehab
This series of 15 patches improves support for IR, as discussed at the "What are the goals for the architecture of an in-kernel IR system?" thread. It basically adds a raw decoder layer at ir-core, allowing decoders to plug into IR core, and preparing for the addition of a lirc_dev driver that wil

[PATCH 11/15] V4L/DVB: saa7134: clear warning noise

2010-04-01 Thread Mauro Carvalho Chehab
drivers/media/video/saa7134/saa7134-input.c: In function ‘saa7134_raw_decode_irq’: drivers/media/video/saa7134/saa7134-input.c:957: warning: unused variable ‘oldpulse’ drivers/media/video/saa7134/saa7134-input.c:957: warning: unused variable ‘count’ Signed-off-by: Mauro Carvalho Chehab diff -

[RFC] Serialization flag example

2010-04-01 Thread Hans Verkuil
I made a quick implementation which is available here: http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-serialize It's pretty easy to use and it also gives you a very simple way to block access to the video device nodes until all have been allocated by simply taking the serialization lock and holding

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: > On Thu, Apr 1, 2010 at 11:02 AM, Mauro Carvalho Chehab > wrote: >> I remember I had to do it on em28xx: >> >> This is the init code for it: >>... >>mutex_init(&dev->lock); >>mutex_lock(&dev->lock); >>em28xx_init_dev(&dev, udev, interface,

Re: webcam problem after suspend/hibernate

2010-04-01 Thread Philippe Troin
Pavel Machek writes: > > Do you mean the dmesg output ? > > A full dmesg is included in this address : > > http://pastebin.com/8XU619Uk > > Not in all suspend/hibernate the problem comes, only in some of them > > and this included dmesg output is just after a non working case of > > webcam fault.

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Devin Heitmueller
On Thu, Apr 1, 2010 at 11:02 AM, Mauro Carvalho Chehab wrote: > I remember I had to do it on em28xx: > > This is the init code for it: >        ... >        mutex_init(&dev->lock); >        mutex_lock(&dev->lock); >        em28xx_init_dev(&dev, udev, interface, nr); >        ... >        request_m

Re: webcam problem after suspend/hibernate

2010-04-01 Thread Pavel Machek
Hi! > Do you mean the dmesg output ? > A full dmesg is included in this address : > http://pastebin.com/8XU619Uk > Not in all suspend/hibernate the problem comes, only in some of them > and this included dmesg output is just after a non working case of > webcam fault. > > > I also have found thi

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Laurent Pinchart wrote: > Hi Hans, > > On Thursday 01 April 2010 13:11:51 Hans Verkuil wrote: >> On Thursday 01 April 2010 11:23:30 Laurent Pinchart wrote: >>> On Thursday 01 April 2010 10:01:10 Hans Verkuil wrote: Hi all, I just read on LWN that the core kernel guys are putting mor

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: > What to do if we have multiple device nodes? E.g. video0 and vbi0? Should we > allow access to video0 when vbi0 is not yet registered? Or should we block > access until all video nodes are registered? It will depend on the driver implementation, but, as new udev implementati

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Laurent Pinchart wrote: >> One typical problem that I see is that some drivers register too soon: they >> first register, then initialize some things. I've seen (and fixed) some >> race conditions due to that. Just moving the register to the end solves >> this issue. > > That's right, devices sho

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: > Hi all, > > I just read on LWN that the core kernel guys are putting more effort into > removing the BKL. We are still using it in our own drivers, mostly V4L. > > I added a BKL column to my driver list: > > http://www.linuxtv.org/wiki/index.php/V4L_framework_progress#Bridg

Re: [GIT FIX for 2.6.34] V4L - vpfe capture - fix for kernel crash on DM365

2010-04-01 Thread Mauro Carvalho Chehab
Karicheri, Muralidharan wrote: > Mauro, > > Thanks a lot for your support. > > Do you plan to merge my pull request for 2.6.35 anytime soon? It were already merged locally. I'm running a compilation of the tree with the merged patches. If all compile ok, your pull request (and others) will be at

RE: [GIT FIX for 2.6.34] V4L - vpfe capture - fix for kernel crash on DM365

2010-04-01 Thread Karicheri, Muralidharan
Mauro, Thanks a lot for your support. Do you plan to merge my pull request for 2.6.35 anytime soon? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com >-Original Message- >From: Mauro Carvalho Chehab [mail

Re: [GIT FIX for 2.6.34] V4L - vpfe capture - fix for kernel crash on DM365

2010-04-01 Thread Mauro Carvalho Chehab
Muralidharan Karicheri wrote: > Mauro, > > When I had last replied to your email, I didn't check if the patch is > actually applied to your v4l_for_linux branch of fixes.git tree. But > Today I checked and I can't find the patch merged to this tree as you > had mentioned.. > > So if you haven't m

[patch] ir-keytable: avoid double lock

2010-04-01 Thread Dan Carpenter
It's possible that we wanted to resize to a smaller size but we didn't have enough memory to create the new table. We need to test for that here so we don't try to lock twice and dead lock. Also we free the "oldkeymap" on that path and that would be bad. Signed-off-by: Dan Carpenter --- I don't

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Hans Verkuil
On Thursday 01 April 2010 17:02:01 Mauro Carvalho Chehab wrote: > Hans Verkuil wrote: > > > What to do if we have multiple device nodes? E.g. video0 and vbi0? Should we > > allow access to video0 when vbi0 is not yet registered? Or should we block > > access until all video nodes are registered? >

[RFC] Non-FIFO waiting on buffers in videobuf

2010-04-01 Thread Pawel Osciak
Hello, we would like to propose a change to how videobuf handles the process of waking up buffers, to allow returning them to userspace in a different order than FIFO, if a driver (device) so requires. Currently, when poll() or dqbuf() is called, videobuf takes the first (i.e. first qbuf()-ed) bu

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Hans Verkuil
On Thursday 01 April 2010 16:12:50 Mauro Carvalho Chehab wrote: > Laurent Pinchart wrote: > > Hi Hans, > > > > On Thursday 01 April 2010 13:11:51 Hans Verkuil wrote: > >> On Thursday 01 April 2010 11:23:30 Laurent Pinchart wrote: > >>> On Thursday 01 April 2010 10:01:10 Hans Verkuil wrote: >

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Laurent Pinchart
Hi Mauro, On Thursday 01 April 2010 16:12:50 Mauro Carvalho Chehab wrote: > Laurent Pinchart wrote: > > On Thursday 01 April 2010 13:11:51 Hans Verkuil wrote: > >> On Thursday 01 April 2010 11:23:30 Laurent Pinchart wrote: > >>> On Thursday 01 April 2010 10:01:10 Hans Verkuil wrote: > Hi all,

Re: terratec grabby sound problem

2010-04-01 Thread moebius
Bonjour, No progress at all I've tried to download last version from mercurial repository (compilation problem with firedtv module -> I've disabled it) succeded and installed it but with no change dmesg : [ 42.660031] usb 1-3: new high speed USB device using ehci_hcd and address 4 [ 42

RE: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf.

2010-04-01 Thread Pawel Osciak
>Pawel Osciak [mailto:p.osc...@samsung.com] wrote: >>> +unsigned int v4l2_m2m_poll(struct file *file, struct v4l2_m2m_ctx *m2m_ctx, >>> + struct poll_table_struct *wait) >>> +{ >>> + struct videobuf_queue *dst_q; >>> + struct videobuf_buffer *vb = NULL; >>> + unsigned int

RE: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf.

2010-04-01 Thread Pawel Osciak
Hi Hans, thank you for the review. My comments below. > Hans Verkuil [mailto:hverk...@xs4all.nl] wrote: >Here is my review... > [...] >> +/** >> + * v4l2_m2m_next_src_buf() - return next source buffer from the list of >> ready >> + * buffers >> + */ >> +inline void *v4l2_m2m_next_src_buf(struc

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
Hans Verkuil wrote: > I just read on LWN that the core kernel guys are putting more effort into > removing the BKL. We are still using it in our own drivers, mostly V4L. > > I added a BKL column to my driver list: > > http://www.linuxtv.org/wiki/index.php/V4L_framework_progress#Bridge_Drivers >

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
Stefan Richter wrote: >> linux/drivers/media/dvb/dvb-core/dvbdev.c: lock_kernel(); >> linux/drivers/media/dvb/dvb-core/dvbdev.c: unlock_kernel(); >> linux/drivers/media/dvb/dvb-core/dvbdev.c: unlock_kernel(); > > This is from when the BKL was pushed down into drivers' open()

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Hans Verkuil
On Thursday 01 April 2010 13:57:13 Stefan Richter wrote: > Hans Verkuil wrote: > > I just read on LWN that the core kernel guys are putting more effort into > > removing the BKL. We are still using it in our own drivers, mostly V4L. > > > > I added a BKL column to my driver list: > > > > http://w

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Laurent Pinchart
Hi Hans, On Thursday 01 April 2010 13:11:51 Hans Verkuil wrote: > On Thursday 01 April 2010 11:23:30 Laurent Pinchart wrote: > > On Thursday 01 April 2010 10:01:10 Hans Verkuil wrote: > > > Hi all, > > > > > > I just read on LWN that the core kernel guys are putting more effort > > > into removin

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
Hans Verkuil wrote: > On the DVB side there seem to be only two sources that use the BKL: > > linux/drivers/media/dvb/bt8xx/dst_ca.c: lock_kernel(); > linux/drivers/media/dvb/bt8xx/dst_ca.c: unlock_kernel(); This is from an incomplete conversion from .ioctl to .unlocked_ioctl (no conversion reall

[PATCH] drivers/media/IR - improve keyup/keydown logic

2010-04-01 Thread David Härdeman
The attached patch rewrites the keyup/keydown logic in drivers/media/IR/ir-keytable.c. (applies to http://git.linuxtv.org/mchehab/ir.git) All knowledge of keystates etc is now internal to ir-keytable.c and not scattered around ir-raw-event.c and ir-nec-decoder.c (where it doesn't belong). In add

Re: adv7180 as SoC camera device

2010-04-01 Thread Rodolfo Giometti
On Tue, Mar 30, 2010 at 04:06:11PM +0200, Rodolfo Giometti wrote: > On Tue, Feb 23, 2010 at 12:19:13AM +0100, Richard Röjfors wrote: > > > > We use it as a subdev to a driver not yet committed from us. So I think > > you should extend it, not move it. > > Finally I got something functional... but

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Hans Verkuil
On Thursday 01 April 2010 11:23:30 Laurent Pinchart wrote: > Hi Hans, > > On Thursday 01 April 2010 10:01:10 Hans Verkuil wrote: > > Hi all, > > > > I just read on LWN that the core kernel guys are putting more effort into > > removing the BKL. We are still using it in our own drivers, mostly V4L

RE: [PATCH 2/2] mem2mem_testdev: Code cleanup

2010-04-01 Thread Hiremath, Vaibhav
> -Original Message- > From: Pawel Osciak [mailto:p.osc...@samsung.com] > Sent: Thursday, April 01, 2010 3:39 PM > To: Hiremath, Vaibhav > Cc: linux-media@vger.kernel.org; Marek Szyprowski; kyungmin.p...@samsung.com > Subject: RE: [PATCH 2/2] mem2mem_testdev: Code cleanup > > Hi again, >

RE: [PATCH 2/2] mem2mem_testdev: Code cleanup

2010-04-01 Thread Pawel Osciak
Hi again, > Vaibhav Hiremath wrote: >From: Vaibhav Hiremath > > >Signed-off-by: Vaibhav Hiremath >--- > drivers/media/video/mem2mem_testdev.c | 58 ++-- > 1 files changed, 25 insertions(+), 33 deletions(-) > >diff --git a/drivers/media/video/mem2mem_testdev.c >b/dr

[PATCH 2/2] OMAP2/3: Add V4L2 DSS driver support in device.c

2010-04-01 Thread hvaibhav
From: Vaibhav Hiremath Signed-off-by: Vaibhav Hiremath --- arch/arm/mach-omap2/devices.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 18ad931..7aaffe7 100644 --- a/arch/a

[RESEND: PATCH-V6 0/2] OMAP2/3: Add V4L2 display driver support

2010-04-01 Thread hvaibhav
From: Vaibhav Hiremath The previous patch submission had a dependancy on "ti-media" directory patch, and since we were not having any conclusion on that patch, I have created "omap" directory (device specific name) and moved V4L2 driver (as of now applicable to OMAP2/3 devices) to this new direct

RE: [PATCH 1/2] v4l2-mem2mem: Code cleanup

2010-04-01 Thread Pawel Osciak
Hi, thanks for the patch, one comment below: >Vaibhav Hiremath (hvaib...@ti.com) wrote: > >Signed-off-by: Vaibhav Hiremath >--- > drivers/media/video/v4l2-mem2mem.c | 40 ++- > 1 files changed, 16 insertions(+), 24 deletions(-) [...] >@@ -319,10 +317,9 @@ stati

[GIT PATCHES FOR 2.6.35] Updates for the uvcvideo driver

2010-04-01 Thread Laurent Pinchart
The following changes since commit 975b06b6c01ba2da4d26a7ba6ea783d5f670aa7d: Jonathan Corbet (1): V4L/DVB: ov7670: silence some compiler warnings are available in the git repository at: git://linuxtv.org/pinchartl/uvcvideo.git uvcvideo Laurent Pinchart (5): uvcvideo: Add suppor

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Laurent Pinchart
Hi Hans, On Thursday 01 April 2010 10:01:10 Hans Verkuil wrote: > Hi all, > > I just read on LWN that the core kernel guys are putting more effort into > removing the BKL. We are still using it in our own drivers, mostly V4L. > > I added a BKL column to my driver list: > > http://www.linuxtv.or

RE: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf.

2010-04-01 Thread Hiremath, Vaibhav
> -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Thursday, April 01, 2010 2:37 PM > To: Pawel Osciak > Cc: linux-media@vger.kernel.org; m.szyprow...@samsung.com; > kyungmin.p...@samsung.com; Hiremath, Vaibhav > Subject: Re: [PATCH v3 1/2] v4l: Add memory-to-mem

Re: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf.

2010-04-01 Thread Hans Verkuil
On Thursday 01 April 2010 11:06:51 Hans Verkuil wrote: > Here is my review... > > > +/** > > + * v4l2_m2m_release() - cleans up and frees a m2m_dev structure > > + * > > + * Usually called from driver's remove() function. > > + */ > > +void v4l2_m2m_release(struct v4l2_m2m_dev *m2m_dev) > > +{ > >

Re: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf.

2010-04-01 Thread Hans Verkuil
Here is my review... On Monday 29 March 2010 09:36:46 Pawel Osciak wrote: > A mem-to-mem device is a device that uses memory buffers passed by > userspace applications for both their source and destination data. This > is different from existing drivers, which utilize memory buffers for either > i

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-04-01 Thread Hans Verkuil
On Tuesday 30 March 2010 14:39:12 Wolfram Sang wrote: > Hans, > > > But this just feels like an i2c core thing to me. After remove() is called > > the core should just set the client data to NULL. If there are drivers that > > rely on the current behavior, then those drivers should be reviewed fir

[PATCH 2/2] mem2mem_testdev: Code cleanup

2010-04-01 Thread hvaibhav
From: Vaibhav Hiremath Signed-off-by: Vaibhav Hiremath --- drivers/media/video/mem2mem_testdev.c | 58 ++-- 1 files changed, 25 insertions(+), 33 deletions(-) diff --git a/drivers/media/video/mem2mem_testdev.c b/drivers/media/video/mem2mem_testdev.c index 05630e

[PATCH 1/2] v4l2-mem2mem: Code cleanup

2010-04-01 Thread hvaibhav
From: Vaibhav Hiremath Signed-off-by: Vaibhav Hiremath --- drivers/media/video/v4l2-mem2mem.c | 40 ++- 1 files changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/media/video/v4l2-mem2mem.c b/drivers/media/video/v4l2-mem2mem.c index a78157f..4cd

RE: [PATCH v3 0/2] Mem-to-mem device framework

2010-04-01 Thread Hiremath, Vaibhav
> -Original Message- > From: Pawel Osciak [mailto:p.osc...@samsung.com] > Sent: Monday, March 29, 2010 1:07 PM > To: linux-media@vger.kernel.org > Cc: p.osc...@samsung.com; m.szyprow...@samsung.com; > kyungmin.p...@samsung.com; Hiremath, Vaibhav > Subject: [PATCH v3 0/2] Mem-to-mem device

V4L-DVB drivers and BKL

2010-04-01 Thread Hans Verkuil
Hi all, I just read on LWN that the core kernel guys are putting more effort into removing the BKL. We are still using it in our own drivers, mostly V4L. I added a BKL column to my driver list: http://www.linuxtv.org/wiki/index.php/V4L_framework_progress#Bridge_Drivers If you 'own' one of these

Re: [PATCH] s2255drv: removal of big kernel lock

2010-04-01 Thread Hans Verkuil
On Wednesday 31 March 2010 16:41:51 Dean A. wrote: > # HG changeset patch > # User Dean Anderson > # Date 1270046291 25200 > # Node ID c72bdc8732abc0cf7bc376babfd06b2d999bdcf4 > # Parent 2ab296deae938864b06b29cc224eb4b670ae3aa9 > s2255drv: removal of BKL > > From: Dean Anderson > > big kernel