soc-camera: fix missing clean up on error path
If soc_camera_init_user_formats() fails in soc_camera_probe(), we have to call
client's .remove() method to unregister the video device.
Reported-by: Kuninori Morimoto
Signed-off-by: Guennadi Liakhovetski
---
(please use the new V4L Mailing List)
Hi,
I've a LV5H clone marketed in Italy under Extreme Technology brand
which does not work under Ubuntu Jaunty (kernel version 2.6.30 used to
solve intel graphics video card performance issue).
It is identified by:
idVendor=eb1a, idProduct=2883
I tried to use it using the following em28xx.
OK after adding 'options saa7134 card=156' to /etc/modprobe.d/modprobe.conf
it loads correctly, thanks Brad.
dmesg:
[8.438243] Linux video capture interface: v2.00
[8.606434] nvidia :01:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
[8.606440] nvidia :01:00.0: setting latenc
On Thu, 2009-06-18 at 21:43 -0500, Theodore Kilgore wrote:
>
> On Thu, 18 Jun 2009, Andy Walls wrote:
> >
> >
> >
>
> Interesting. To answer your question, I have no idea off the top of my
> head. I do have what seems to be a similar camera. It is
>
> Bus 005 Device 006: ID 0979:0371 Jeilin Tec
On Sun, 2009-06-14 at 22:33 -0400, Andy Walls wrote:
> On Fri, 2009-06-12 at 14:26 -0400, Andy Walls wrote:
> > On Thu, 2009-06-11 at 16:20 +0100, Steve Firth wrote:
>
> > >I've de-lidded the MPC718 card and the chip set is as
> > > below.
> >
> > > Devices
> > > ---
> > > Co
Hi,
I have this card and tried testing the tree at
http://kernellabs.com/hg/~mkrufky/dtv1000s
revision b0f29c0cff4b
No directory was created at /dev/dvb/
'uname -r' gives:
2.6.28-11-generic
which is the Ubuntu 9.04 kernel
(I don't know how to get a vanilla kernel .. sorry)
I'm new at this so I'
On Wed, Jun 17, 2009 at 5:33 PM, Hans Verkuil wrote:
>> I think automatic negotiation is a good thing if it is implemented
>> correctly.
>>
>> Actually, i think modelling software after hardware is a good thing
>> and from that perspective the soc_camera was (and still is) a very
>> good fit for ou
On Thu, 18 Jun 2009, Andy Walls wrote:
My daughter just got one of these toy digital video recorder & webcam
unit.
It normally shows up as a mass storage drive.
If I hold down the shutter button while connecting the USB cable, the
camera LCD show a "webcam mode" icon and it shows up as a dif
This one is about the utility itself. I do apologize for the length
here as "inline" patch is preferred according to the guide and I don't
have any public online storage. Please let me know if this causes any
inconvenience.
Signed-off-by: Yufei Yuan
diff -uprN dvb-apps/util/atsc_epg/atsc_epg.c
d
My daughter just got one of these toy digital video recorder & webcam
unit.
It normally shows up as a mass storage drive.
If I hold down the shutter button while connecting the USB cable, the
camera LCD show a "webcam mode" icon and it shows up as a different USB
device.
Any chance of this worki
Okay, this one serves as a test as well. It's a trivial one to fix the
broken dvb-apps building process with gcc4.4 on kernel 2.6.30, another
way to eliminate the packed bitfield warning is to split the field,
but that is unwanted.
previous build error:
make[2]: Entering directory `/home/alex/sou
On Thu, 18 Jun 2009, Jan Nikitenko wrote:
> Replace printing to magically sized temporal buffer with use of KERN_CONT
temporary not temporal.
> - sprintf(buf2, "%02x ", val);
> + deb_info(KERN_CONT, " %02x", val);
No comma after KERN_CONT
>
Hi,
Am Donnerstag, den 18.06.2009, 16:01 +0200 schrieb Halim Sahin:
> Hi,
> you can see at my dmesg output
> [ 2282.430209] bttv: driver version 0.9.18 loaded
>
> i have done
> hg clone http://linuxtv.org/hg/v4l-dvb
> cd v4l-dvb
> make && make install
> reboot
> No idea why I don't have the audi
If this information is not sufficient, feel free to contact me.
amd64 Debian Lenny with 2.6.30-1 from unstable. v4l-dvb is installed
from mercurial just minutes ago ( hg clone
http://www.linuxtv.org/hg/v4l-dvb )
Best regards
lsusb
Bus 001 Device 009: ID eb1a:2881 eMPIA Technology, Inc.
dm
This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.
Results of the daily build of v4l-dvb:
date:Thu Jun 18 19:00:05 CEST 2009
path:http://www.linuxtv.org/hg/v4l-dvb
changeset: 12070:722c6faf3ab5
gcc version: gcc
Hi Mauro,
As requested:
On 06/18/2009 12:44 PM, Mauro Carvalho Chehab wrote:
>
> Also, checkpatch is warning about a few troubles at the patches.
>
> Could you please create another tree, directly based on mine, fix the coding
> styles and send another pull request?
>
I've rebased my tree on yo
Hi,
I've again updated the patchset in Gitorious after a long break. It's
here. The base is fairly recent linux-omap (May) but I wouldn't expect
problems in rebasing on top of newer updates either.
http://www.gitorious.org/projects/omap3camera>
The amount of changes is more or less huge but I'l
Ok, a couple of things have become clearer to me, some others managed to
confuse me again:
On Wed, 10 Jun 2009, Hans Verkuil wrote:
> On Wednesday 10 June 2009 18:02:39 Guennadi Liakhovetski wrote:
[snip]
> > which I now interpret as
> >
> > S_FMT(640x480) means "scale whatever rectangle has b
This patch adds a document file for si4713 device driver.
It describes the driver interfaces and organization.
Signed-off-by: Eduardo Valentin
---
linux/Documentation/video4linux/si4713.txt | 169
1 files changed, 169 insertions(+), 0 deletions(-)
create mode 10064
This patch adds simple support for FM TX extended controls
on v4l2-ctl utility.
Signed-off-by: Eduardo Valentin
---
v4l2-apps/util/v4l2-ctl.cpp | 36
1 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/v4l2-apps/util/v4l2-ctl.cpp b/v4l2-apps/uti
Signed-off-by: Eduardo Valentin
---
linux/drivers/media/video/v4l2-common.c | 50 +++
1 files changed, 50 insertions(+), 0 deletions(-)
diff --git a/linux/drivers/media/video/v4l2-common.c
b/linux/drivers/media/video/v4l2-common.c
index 5cfd727..fc4d7a8 100644
---
Simple add Makefile and Kconfig entries.
Signed-off-by: Eduardo Valentin
---
linux/drivers/media/radio/Kconfig | 22 ++
linux/drivers/media/radio/Makefile |2 ++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/linux/drivers/media/radio/Kconfig
b/linux/
This patch adds files which creates the radio interface
for si4713 FM transmitter (modulator) devices.
In order to do the real access to device registers, this
driver uses the v4l2 subdev interface exported by si4713 i2c driver.
Signed-off-by: "Eduardo Valentin "
---
linux/drivers/media/radio/ra
Hello all,
First of all, I'd like to thank you for the good review. The driver
is getting better and better. With this new API change, si4713 is looking
like a fm transmitter driver.
So, I'm resending the FM transmitter driver and the proposed changes in
v4l2 api files in order to cover the f
This single patch adds documentation description for FM Modulator (FM_TX)
Extended Control Class and its Control IDs. The text was added under
"Extended Controls" section.
Signed-off-by: Eduardo Valentin
---
v4l2-spec/Makefile |1 +
v4l2-spec/biblio.sgml | 10 +++
v4l2-spec/controls
Signed-off-by: Eduardo Valentin
---
linux/include/media/v4l2-subdev.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/linux/include/media/v4l2-subdev.h
b/linux/include/media/v4l2-subdev.h
index 5dcb367..4dc3788 100644
--- a/linux/include/media/v4l2-subdev.h
+++ b/linux/
This patch adds a new class of extended controls. This class
is intended to support FM Radio Modulators properties such as:
rds, audio limiters, audio compression, pilot tone generation,
tuning power levels and preemphasis properties.
Signed-off-by: Eduardo Valentin
---
linux/include/linux/video
Hi,
you can see at my dmesg output
[ 2282.430209] bttv: driver version 0.9.18 loaded
i have done
hg clone http://linuxtv.org/hg/v4l-dvb
cd v4l-dvb
make && make install
reboot
No idea why I don't have the audiodev modparam?
Regards
Halim
--
Halim Sahin
E-Mail:
halim.sahi
> Hi,
> On Do, Jun 18, 2009 at 01:09:56 +0200, Hans Verkuil wrote:
>>
>> > Hi,
>> > sorry for the nusable output!
>> > I found the time consuming funktion:
>> > bttv_init_card2(btv);
>> > This takes about 4 min. today.
>> > my new testcode:
>> > /* needs to be done before i2c is re
Ok, I guess I violated at least coding style rule No.1, :) Will peruse
the coding style page tonight and redo the submission.
Regards,
Yufei
On Thu, Jun 18, 2009 at 3:48 AM, Manu Abraham wrote:
> On Thu, Jun 18, 2009 at 12:32 PM, Manu Abraham wrote:
>> 2009/6/18 Yufei Yuan :
>>> Hi,
>>>
>>> I am
Hi Devin,
do you have some updates on LV5H hybrid tv card?
If needed I can help you with some testing
Thanks in advance,
Mimmo
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kerne
Hi,
On Do, Jun 18, 2009 at 01:09:56 +0200, Hans Verkuil wrote:
>
> > Hi,
> > sorry for the nusable output!
> > I found the time consuming funktion:
> > bttv_init_card2(btv);
> > This takes about 4 min. today.
> > my new testcode:
> > /* needs to be done before i2c is registered */
Updated temporary patch to get ov7670 working with soc camera.
---
Basically this is the original patch with the changes Guennadi
suggested. Again this is only for info, not a formal patch submission.
diff --git a/drivers/media/video/ov7670.c b/drivers/media/video/ov7670.c
index 0e2184e..9bea804
> Hi Sakari,
>
> Em Wed, 17 Jun 2009 20:40:32 +0300
> Sakari Ailus escreveu:
>
>> > So, I decided to send you this email, c/c a random list of people that
>> I
>> > believe are involved on the submit and/or review process of those
>> patches, in
>> > the hope to better understand and to discuss w
Replace printing to magically sized temporal buffer with use of KERN_CONT
for continual printing of eeprom registers dump.
Since deb_info is defined as dprintk, which is defined as printk without
additional parameters, meaning that deb_info is equivalent to direct printk
(without KERN_ facility),
Replace printing to magically sized temporal buffer with use of KERN_CONT for
continual printing of eeprom registers dump.
Since deb_info is defined as dprintk, which is defined as printk without
additional parameters, meaning that deb_info is equivalent to direct printk
(without KERN_ facility
This patch fixes stack corruption bug present in dump_regs function of zl10353
and qt1010 drivers:
the buffer buf was one byte smaller than required - there are 4 chars for
address prefix, 16 * 3 chars for dump of 16 eeprom bytes per line and 1 byte
for zero ending the string required, i.e. 53 b
> Hi,
> sorry for the nusable output!
> I found the time consuming funktion:
> bttv_init_card2(btv);
> This takes about 4 min. today.
> my new testcode:
> /* needs to be done before i2c is registered */
> printk("linke 2:bttv_init_card1(btv);\n");
>
> bttv_init_card1(btv);
Em Wed, 17 Jun 2009 23:54:40 +0200
Hans de Goede escreveu:
> Hi Mauro,
>
> Can you please pull from:
> http://linuxtv.org/hg/~hgoede/gspca
>
> I know you haven't even had the chance to do my previous
> pull request :)
>
> New this time:
> * mark the ov511 driver as deprecated, note:
> we shoul
Em Wed, 17 Jun 2009 08:46:19 +0200
Hans de Goede escreveu:
> Hi Mauro,
>
> Can you please pull from:
> http://linuxtv.org/hg/~hgoede/gspca
>
> I've asked JF Moine a couple of days ago if he wanted
> this to go through his tree or directly, but have not
> received an answer, as there is one impo
Hi,
sorry not to have answered sooner.
On Tuesday 09 June 2009 00:05:10 Karicheri, Muralidharan wrote:
> > > +
> > > +/* register access routines */
> > > +static inline u32 regr(u32 offset)
> > > +{
> > > + if (offset <= ccdc_addr_size)
> >
> > This should be <.
> >
> > > + return __raw_
Guennadi Liakhovetski wrote:
> On Wed, 17 Jun 2009, Jonathan Cameron wrote:
>
>> This is purely for info of anyone else wanting to use the ov7670
>> with Guennadi's recent work on converted soc-camera to v4l2-subdevs.
>>
>> It may not be completely minimal, but it's letting me take pictures ;)
>
Hi,
sorry for the nusable output!
I found the time consuming funktion:
bttv_init_card2(btv);
This takes about 4 min. today.
my new testcode:
/* needs to be done before i2c is registered */
printk("linke 2:bttv_init_card1(btv);\n");
bttv_init_card1(btv);
/* register
On Thu, 18 Jun 2009, Valentin Longchamp wrote:
> The sensor chips both are mt9t031 so they have the same i2c address (I have
> looked at the datasheet, and I don't think this can be changed). So I cannot
> use them both at the same time.
Right, but I think, there are some i2c ICs, that allow for
Hi,
On Mi, Jun 17, 2009 at 10:06:26 +0200, Hans Verkuil wrote:
> The log is from bttv version 0.9.17. The new code is only present in version
> 0.9.18. So this is definitely not related to any of my changes.
>
> The text "bttv0: gpio: en=, out= in=003ff502 [init]" comes
> from th
Guennadi Liakhovetski wrote:
On Thu, 18 Jun 2009, Valentin Longchamp wrote:
Hi Guennadi,
I am trying to follow your developments at porting soc-camera to v4l2-subdev.
However, even if I understand quite correctly soc-camera, it is quite
difficult for me to get all the subtleties in your work.
"Johannes T. K." writes:
>>
>> If anyone has been able to tune the cable adapter under linux I'd like to
>> hear more.
>>
>
> I have a firedtv c/ci which I have had some success with in linux. I
> have no problem tuning and watching/recoding programs as long as they
> are not scrambled.
Same her
On Thu, 18 Jun 2009, Valentin Longchamp wrote:
> Hi Guennadi,
>
> I am trying to follow your developments at porting soc-camera to v4l2-subdev.
> However, even if I understand quite correctly soc-camera, it is quite
> difficult for me to get all the subtleties in your work.
>
> That's why I am a
Hi Guennadi,
I am trying to follow your developments at porting soc-camera to
v4l2-subdev. However, even if I understand quite correctly soc-camera,
it is quite difficult for me to get all the subtleties in your work.
That's why I am asking you for a little help: when do you think would be
t
On Thu, Jun 18, 2009 at 12:32 PM, Manu Abraham wrote:
> 2009/6/18 Yufei Yuan :
>> Hi,
>>
>> I am not sure if this is the correct mailing list to send this patch.
>> From the LinuxTV website, it seems that currently dvb-apps project has
>> no owner.
>>
>> A new utility atsc_epg is added into the dvb
2009/6/18 Yufei Yuan :
> Hi,
>
> I am not sure if this is the correct mailing list to send this patch.
> From the LinuxTV website, it seems that currently dvb-apps project has
> no owner.
>
> A new utility atsc_epg is added into the dvb-apps utility suite. It
> parses PSIP information carried in OT
51 matches
Mail list logo