Re: [PATCH net-next v3 3/9] Bluetooth: RFCOMM: avoid leaving dangling sk pointer in rfcomm_sock_alloc()

2024-10-15 Thread Eric Dumazet
On Mon, Oct 14, 2024 at 11:30 PM Kuniyuki Iwashima wrote: > > From: Ignat Korchagin > Date: Mon, 14 Oct 2024 16:38:02 +0100 > > bt_sock_alloc() attaches allocated sk object to the provided sock object. > > If rfcomm_dlc_alloc() fails, we release the sk object, but leave the > > dangling pointer i

Re: [PATCH net-next v3 3/9] Bluetooth: RFCOMM: avoid leaving dangling sk pointer in rfcomm_sock_alloc()

2024-10-14 Thread Kuniyuki Iwashima
From: Ignat Korchagin Date: Mon, 14 Oct 2024 16:38:02 +0100 > bt_sock_alloc() attaches allocated sk object to the provided sock object. > If rfcomm_dlc_alloc() fails, we release the sk object, but leave the > dangling pointer in the sock object, which may cause use-after-free. > > Fix this by swa

[PATCH net-next v3 3/9] Bluetooth: RFCOMM: avoid leaving dangling sk pointer in rfcomm_sock_alloc()

2024-10-14 Thread Ignat Korchagin
bt_sock_alloc() attaches allocated sk object to the provided sock object. If rfcomm_dlc_alloc() fails, we release the sk object, but leave the dangling pointer in the sock object, which may cause use-after-free. Fix this by swapping calls to bt_sock_alloc() and rfcomm_dlc_alloc(). Signed-off-by: