RE: [PATCH] crypto: testmgr - Improve randomization of params for AEAD fuzz testing

2019-07-29 Thread Pascal Van Leeuwen
Hi Eric, > -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Monday, July 29, 2019 11:11 AM > To: Eric Biggers ; Pascal van Leeuwen > > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au

RE: [PATCH] crypto: testmgr - Improve randomization of params for AEAD fuzz testing

2019-07-29 Thread Pascal Van Leeuwen
s, that would indeed be a better place, thanks! > > > > > Also, perhaps these should use the convention '.proportion_of_total', like > > > 'struct testvec_config' already does, rather than '.threshold'? That > > > would be > >

RE: [PATCH] crypto: testmgr - Improve randomization of params for AEAD fuzz testing

2019-07-29 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Monday, July 29, 2019 8:23 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; da...@davemloft.net > Subject: Re: [PATCH] crypto: testmgr - Improve ra

RE: [PATCH] crypto: testmgr - Improve randomization of params for AEAD fuzz testing

2019-07-29 Thread Pascal Van Leeuwen
Herbert, > -Original Message- > From: Herbert Xu > Sent: Tuesday, July 30, 2019 12:31 AM > To: Pascal Van Leeuwen > Cc: Eric Biggers ; Pascal van Leeuwen > ; linux- > cry...@vger.kernel.org; da...@davemloft.net > Subject: Re: [PATCH] crypto: testmgr - Improve

RE: [PATCH] crypto: testmgr - Improve randomization of params for AEAD fuzz testing

2019-07-29 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Tuesday, July 30, 2019 2:17 AM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; da...@davemloft.net > Subject: Re: [PATCH] crypto: testmgr - Improve ra

RE: [PATCH] crypto: testmgr - Improve randomization of params for AEAD fuzz testing

2019-07-29 Thread Pascal Van Leeuwen
(at some point) update the AEAD tests to intentionally > generate > some inauthentic inputs, but that will take some more work. > > - Eric > I believe that's a rather essential part of verifying AEAD decryption(!) Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: [PATCH] crypto: testmgr - Improve randomization of params for AEAD fuzz testing

2019-07-29 Thread Pascal Van Leeuwen
= 0; > > > > > > I'm planning to (at some point) update the AEAD tests to intentionally > > > generate > > > some inauthentic inputs, but that will take some more work. > > > > > > - Eric > > > > > I believe t

RE: [PATCHv2 2/3] crypto: inside-secure - add support for PCI based FPGA development board

2019-07-30 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Tuesday, July 30, 2019 11:08 AM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; > da...@davemloft.net; Pascal Van Leeuwen > Subject:

RE: [PATCH] crypto: testmgr - Improve randomization of params for AEAD fuzz testing

2019-07-30 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Tuesday, July 30, 2019 6:26 AM > To: Pascal Van Leeuwen > Cc: Herbert Xu ; Pascal van Leeuwen > ; > linux-crypto@vger.kernel.org; da...@davemloft.net > Subject: Re: [PATCH] crypto: testmgr - Improve randomizati

RE: [PATCH] crypto: inside-secure - Fix null ptr derefence on rmmod for macchiatobin

2019-07-30 Thread Pascal Van Leeuwen
-Original Message- > From: Antoine Tenart > Sent: Tuesday, July 30, 2019 10:12 AM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; > da...@davemloft.net; Pascal Van Leeuwen > Subject: Re: [

RE: [PATCH 2/3] crypto: inside-secure - added support for rfc3686(ctr(aes))

2019-07-30 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Tuesday, July 30, 2019 10:24 AM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: [PATCH

RE: [PATCH] crypto: inside-secure - Fix null ptr derefence on rmmod for macchiatobin

2019-07-30 Thread Pascal Van Leeuwen
> -Original Message- > From: Herbert Xu > Sent: Tuesday, July 30, 2019 1:35 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; da...@davemloft.net > Subject: Re: [PATCH] crypto: inside-secure - Fix null ptr dere

RE: [PATCH 1/3] crypto: inside-secure - add support for authenc(hmac(sha1),cbc(des3_ede))

2019-07-30 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Friday, July 26, 2019 2:57 PM > To: Antoine Tenart ; Pascal van Leeuwen > > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au; > da...@

[PATCH 0/2] crypto: inside-secure - Cosmetic fixes for readability

2019-07-30 Thread Pascal van Leeuwen
This patch set replaces some hard constants with appropriate defines from the crypto header files and fixes a comment mistake. Pascal van Leeuwen (2): crypto: inside-secure - Use defines instead of some constants (cosmetic) crypto: inside-secure: This fixes a mistake in a comment for XTS

[PATCH 2/2] crypto: inside-secure: This fixes a mistake in a comment for XTS

2019-07-30 Thread Pascal van Leeuwen
This fixes a copy-paste (and forgot to edit) mistake in a comment for XTS regarding the key length specification. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel_cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/inside-secure

[PATCH 1/2] crypto: inside-secure - Use defines instead of some constants (cosmetic)

2019-07-30 Thread Pascal van Leeuwen
This patch replaces some hard constants regarding key, IV and nonce sizes with appropriate defines from the crypto header files. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel_cipher.c | 35 ++ 1 file changed, 19 insertions(+), 16 deletions

RE: [PATCHv2 2/3] crypto: inside-secure - add support for PCI based FPGA development board

2019-07-30 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Tuesday, July 30, 2019 3:43 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: [PATCHv2

Crypto API skcipher key size question

2019-07-30 Thread Pascal Van Leeuwen
to avoid posting a redundant patch here :-) Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

[PATCH] crypto: inside-secure: Remove redundant DES ECB & CBC keysize check

2019-07-31 Thread Pascal van Leeuwen
This patch removes a DES key size check that is redundant as it is already performed by the crypto API itself due to min_keysize = max_keysize. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel_cipher.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers

RE: [PATCHv2 2/3] crypto: inside-secure - add support for PCI based FPGA development board

2019-07-31 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Tuesday, July 30, 2019 12:21 PM > To: Antoine Tenart ; Pascal van Leeuwen > > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au; > da...@

RE: [PATCHv2 2/3] crypto: inside-secure - add support for PCI based FPGA development board

2019-07-31 Thread Pascal Van Leeuwen
> -Original Message- > From: Herbert Xu > Sent: Wednesday, July 31, 2019 1:08 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; da...@davemloft.net > Subject: Re: [PATCHv2 2/3] crypto: inside-secure - add support

RE: [PATCHv2 2/3] crypto: inside-secure - add support for PCI based FPGA development board

2019-07-31 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Wednesday, July 31, 2019 2:13 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: [

RE: [PATCHv2 3/3] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-07-31 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Wednesday, July 31, 2019 2:26 PM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; > da...@davemloft.net; Pascal Van Leeuwen > Subject:

RE: [PATCHv2 3/3] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-07-31 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Wednesday, July 31, 2019 4:46 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: [

[PATCH 1/4] crypto: inside-secure - make driver selectable for non-Marvell hardware

2019-07-31 Thread Pascal van Leeuwen
From: Pascal van Leeuwen While being a generic EIP97/EIP197 driver, the driver was only selectable for Marvell Armada hardware. This fix makes the driver selectable for any Device Tree supporting kernel configuration, allowing it to be used for other compatible hardware by just adding the

[PATCH 3/4] crypto: inside-secure - add support for PCI based FPGA development board

2019-07-31 Thread Pascal van Leeuwen
From: Pascal van Leeuwen This patch adds support for a PCIE development board with FPGA from Xilinx, to facilitate pre-silicon driver development by both Inside Secure and its IP customers. Since Inside Secure neither produces nor has access to actual silicon, this is required functionality to

[PATCHv3 0/4] crypto: inside-secure - broaden driver scope

2019-07-31 Thread Pascal van Leeuwen
EIP197B FW - use readl_relaxed() instead of readl() + cpu_relax() in polling loop - merged patch "fix null ptr dereference on rmmod for macchiatobin" here - merged patch "removed unused struct entry" Pascal van Leeuwen (4): crypto: inside-secure - make driver selectable for non-Marvell

[PATCH 2/4] crypto: inside-secure - Remove redundant algo to engine mapping code

2019-07-31 Thread Pascal van Leeuwen
removed now because otherwise the next patch will add new hardware which would otherwise have to be added to all algorithms, so now is a convenient time to just get rid of this. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 9 - drivers/crypto/inside

[PATCH 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-07-31 Thread Pascal van Leeuwen
From: Pascal van Leeuwen Until now, the inside-secure driver required a set of firmware images supplied by the silicon vendor, typically under NDA, to be present in /lib/firmware/inside-secure in order to be able to function. This patch removes the dependence on this official vendor firmware by

[PATCHv3 0/4] crypto: inside-secure - broaden driver scope

2019-07-31 Thread Pascal van Leeuwen
EIP197B FW - use readl_relaxed() instead of readl() + cpu_relax() in polling loop - merged patch "fix null ptr dereference on rmmod for macchiatobin" here - merged patch "removed unused struct entry" Pascal van Leeuwen (4): crypto: inside-secure - make driver selectable for non-Marvell

[PATCHv3 3/4] crypto: inside-secure - add support for PCI based FPGA development board

2019-07-31 Thread Pascal van Leeuwen
. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 560 +++ drivers/crypto/inside-secure/safexcel.h | 30 +- drivers/crypto/inside-secure/safexcel_ring.c | 3 +- 3 files changed, 420 insertions(+), 173 deletions(-) diff --git a

[PATCHv3 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-07-31 Thread Pascal van Leeuwen
"mini" FW - developed specifically for this driver - that can be provided under GPL 2.0 through linux-firmwares. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 194 drivers/crypto/inside-secure/safexcel.h | 12 ++ 2 fil

[PATCHv3 2/4] crypto: inside-secure - Remove redundant algo to engine mapping code

2019-07-31 Thread Pascal van Leeuwen
removed now because otherwise the next patch will add new hardware which would otherwise have to be added to all algorithms, so now is a convenient time to just get rid of this. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 9 - drivers/crypto/inside

[PATCHv3 1/4] crypto: inside-secure - make driver selectable for non-Marvell hardware

2019-07-31 Thread Pascal van Leeuwen
also allows the driver to be selected for PCI(E) supporting kernel con- figurations, to be able to use it with PCIE based FPGA development boards for pre-silicon driver development by both Inside Secure and its IP custo- mers. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/Kconfig | 12

Sent out some incorrect patch mails for crypto:inside-secure, please ignore

2019-07-31 Thread Pascal Van Leeuwen
insidesecure .com email adres in the From: header line, instead of verimatrix), and take only the second, corrected set of 5. Sorry about that. Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: Need help with failling gcm_base(ctr,ghash-generic) selftest

2019-08-01 Thread Pascal Van Leeuwen
t. So possibly a problem with the way you setup the authentication key (which is actually derived from the encryption key, but I don't know if your hardware does this autonomously, mine doesn't) and/or operation? > Thanks > Regards Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: Need help with failling gcm_base(ctr,ghash-generic) selftest

2019-08-02 Thread Pascal Van Leeuwen
> -Original Message- > From: Corentin Labbe > Sent: Friday, August 2, 2019 7:19 AM > To: Pascal Van Leeuwen > Cc: herb...@gondor.apana.org.au; linux-crypto@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: Need help with failling gcm_base(ctr,gh

RE: [PATCH 0/2] Add support for the AES-XTS algorithm

2019-08-02 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Herbert Xu > Sent: Friday, August 2, 2019 6:45 AM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@davemloft.net; Pascal > Van Lee

RE: [PATCHv3 3/4] crypto: inside-secure - add support for PCI based FPGA development board

2019-08-05 Thread Pascal Van Leeuwen
et? Please advise :-) > -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Antoine Tenart > Sent: Monday, August 5, 2019 10:36 AM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; >

RE: [PATCHv3 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-08-05 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Antoine Tenart > Sent: Monday, August 5, 2019 11:07 AM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > herb...@gondor.apana.org.au; >

RE: [PATCHv3 3/4] crypto: inside-secure - add support for PCI based FPGA development board

2019-08-05 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Monday, August 5, 2019 11:10 AM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: [

RE: [PATCHv3 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-08-05 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Monday, August 5, 2019 11:54 AM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: [

RE: [PATCHv3 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-08-05 Thread Pascal Van Leeuwen
> -Original Message- > From: Antoine Tenart > Sent: Monday, August 5, 2019 2:43 PM > To: Pascal Van Leeuwen > Cc: Antoine Tenart ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: [PATCHv3

[PATCH] crypto: xts - Add support for Cipher Text Stealing

2019-08-06 Thread Pascal van Leeuwen
additional test vectors supplied to the linux_crypto mailing list previously. It has also been fuzzed against Inside Secure AES-XTS hardware which has been actively used in the field for more than a decade already. Signed-off-by: Pascal van Leeuwen --- crypto/xts.c | 230

[PATCHv4 1/4] crypto: inside-secure - make driver selectable for non-Marvell hardware

2019-08-06 Thread Pascal van Leeuwen
also allows the driver to be selected for PCI(E) supporting kernel con- figurations, to be able to use it with PCIE based FPGA development boards for pre-silicon driver development by both Inside Secure and its IP custo- mers. Signed-off-by: Pascal van Leeuwen Acked-by: Antoine Tenart --- drivers

[PATCHv4 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-08-06 Thread Pascal van Leeuwen
"mini" FW - developed specifically for this driver - that can be provided under GPL 2.0 through linux-firmwares. Signed-off-by: Pascal van Leeuwen Acked-by: Antoine Tenart --- drivers/crypto/inside-secure/safexcel.c | 194 drivers/crypto/inside-secure/

[PATCHv4 2/4] crypto: inside-secure - Remove redundant algo to engine mapping code

2019-08-06 Thread Pascal van Leeuwen
removed now because otherwise the next patch will add new hardware which would otherwise have to be added to all algorithms, so now is a convenient time to just get rid of this. Signed-off-by: Pascal van Leeuwen Acked-by: Antoine Tenart --- drivers/crypto/inside-secure/safexcel.c| 9

[PATCHv4 0/4] crypto: inside-secure - broaden driver scope

2019-08-06 Thread Pascal van Leeuwen
refix "crypto_is_" to "safexcel_" for consistency Pascal van Leeuwen (4): crypto: inside-secure - make driver selectable for non-Marvell hardware crypto: inside-secure - Remove redundant algo to engine mapping code crypto: inside-secure - add support for PCI based FPGA develo

[PATCHv4 3/4] crypto: inside-secure - add support for PCI based FPGA development board

2019-08-06 Thread Pascal van Leeuwen
. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c | 543 +++ drivers/crypto/inside-secure/safexcel.h | 30 +- drivers/crypto/inside-secure/safexcel_ring.c | 3 +- 3 files changed, 407 insertions(+), 169 deletions(-) diff --git a

RE: AEAD question

2019-08-06 Thread Pascal Van Leeuwen
testing by testmgr. Regards, Pascal > -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Tuesday, July 23, 2019 12:27 AM > To: Eric Biggers > Cc: linux-crypto@vger.kernel.org; Herbert Xu ; > da...@davemloft

[GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver

2019-08-06 Thread Pascal van Leeuwen
for you to fetch changes up to fbfe41f92f941d19b840ec0e282f422379982ccb: inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver (2019-08-06 13:19:44 +0200) ------------ Pascal van Leeuwen (1): inside-secure:

RE: [PATCH] crypto: xts - Add support for Cipher Text Stealing

2019-08-06 Thread Pascal Van Leeuwen
Milan, Thanks for trying :-) > -Original Message- > From: Milan Broz > Sent: Tuesday, August 6, 2019 8:35 PM > To: Pascal van Leeuwen ; linux-crypto@vger.kernel.org > Cc: rs...@cube.dyndns.org; herb...@gondor.apana.org.au; da...@davemloft.net; > Pascal Van > L

RE: [PATCH] crypto: xts - Add support for Cipher Text Stealing

2019-08-07 Thread Pascal Van Leeuwen
Milan, > -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Tuesday, August 6, 2019 9:37 PM > To: Milan Broz ; Pascal van Leeuwen > ; linux- > cry...@vger.kernel.org > Cc: rs...@cube.dyndns.org; herb

RE: [PATCH] crypto: xts - Add support for Cipher Text Stealing

2019-08-07 Thread Pascal Van Leeuwen
Milan, > -Original Message- > From: Milan Broz > Sent: Wednesday, August 7, 2019 1:20 PM > To: Pascal Van Leeuwen ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org > Cc: rs...@cube.dyndns.org; herb...@gondor.apana.org.au; da...@davemloft.net > Subject: Re: [PAT

RE: [PATCH] crypto: xts - Add support for Cipher Text Stealing

2019-08-07 Thread Pascal Van Leeuwen
> -Original Message- > From: Milan Broz > Sent: Wednesday, August 7, 2019 1:42 PM > To: Pascal Van Leeuwen ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org > Cc: rs...@cube.dyndns.org; herb...@gondor.apana.org.au; da...@davemloft.net > Subject: Re: [PATCH] cryp

RE: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-07 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, August 7, 2019 6:51 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au; > ebigg...@kernel.org; > gmazyl...@gmail.com > Subject: Re: [RFC PATCH v2] md/dm-cryp

RE: [PATCH] crypto: xts - Add support for Cipher Text Stealing

2019-08-07 Thread Pascal Van Leeuwen
> -Original Message- > From: Milan Broz > Sent: Wednesday, August 7, 2019 7:24 PM > To: Pascal Van Leeuwen ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org > Cc: rs...@cube.dyndns.org; herb...@gondor.apana.org.au; da...@davemloft.net > Subject: Re: [PATCH] cryp

RE: [PATCH] crypto: xts - Add support for Cipher Text Stealing

2019-08-07 Thread Pascal Van Leeuwen
> -Original Message- > From: Ondrej Mosnáček > Sent: Wednesday, August 7, 2019 10:33 PM > To: Milan Broz > Cc: Pascal Van Leeuwen ; Pascal van Leeuwen > ; linux-crypto@vger.kernel.org; rs...@cube.dyndns.org; > herb...@gondor.apana.org.au; da...@davemloft.net > Sub

[PATCHv2] crypto: xts - Add support for Cipher Text Stealing

2019-08-08 Thread Pascal van Leeuwen
behind init_crypt() in the encrypt() and decrypt() functions, no need to compute for lengths < 16 - Fixed comment style for single line comments Signed-off-by: Pascal van Leeuwen --- crypto/xts.c | 229 +-- 1 file changed, 209 inserti

RE: [PATCHv2] crypto: xts - Add support for Cipher Text Stealing

2019-08-08 Thread Pascal Van Leeuwen
Ard, > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, August 8, 2019 9:45 AM > To: Pascal van Leeuwen > Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE > ; > Herbert Xu ; David S. Miller > ; Pascal > Van Leeuwen > Subject: Re: [PATCHv2]

RE: [PATCHv2] crypto: xts - Add support for Cipher Text Stealing

2019-08-08 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Thursday, August 8, 2019 10:33 AM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; open list:HARDWARE RANDOM > NUMBER GENERATOR > CORE ; Herbert Xu > ; David S. > Miller > Subject: Re: [PATCHv2]

RE: [PATCHv2] crypto: xts - Add support for Cipher Text Stealing

2019-08-08 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Thursday, August 8, 2019 12:38 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; open list:HARDWARE RANDOM > NUMBER GENERATOR > CORE ; Herbert Xu > ; David S. > Miller > Subject: Re: [PATCHv2]

RE: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Thursday, August 8, 2019 7:15 PM > To: Pascal Van Leeuwen > Cc: Milan Broz ; Ard Biesheuvel > ; linux- > cry...@vger.kernel.org; herb...@gondor.apana.org.au; a...@redhat.com; > snit...@redhat.com; > dm-de.

RE: [PATCH 2/2] crypto: inside-secure: This fixes a mistake in a comment for XTS

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Herbert Xu > Sent: Friday, August 9, 2019 7:11 AM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@davemloft.net; Pascal > Van Lee

RE: [PATCH] crypto: xts - add support for ciphertext stealing

2019-08-09 Thread Pascal Van Leeuwen
w.r.t. hardware acceleration :-) > -Original Message- > From: Ard Biesheuvel > Sent: Friday, August 9, 2019 8:31 AM > To: linux-crypto@vger.kernel.org > Cc: herb...@gondor.apana.org.au; ebigg...@kernel.org; Ard Biesheuvel > ; Pascal Van Leeuwen ; > Ondrej > Mosnacek

XTS template wrapping question

2019-08-09 Thread Pascal Van Leeuwen
export? (And I don't see how xts(aes) would work directly, considering that only seems to handle single cipher blocks? Or ... will the crypto API actually wrap some multi-block skcipher thing around the single block cipher instance automatically??) Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com

RE: XTS template wrapping question

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Friday, August 9, 2019 1:39 PM > To: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au; > da...@davemloft.net; Eric > Biggers > Subject: XTS

RE: [PATCH] crypto: xts - add support for ciphertext stealing

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Friday, August 9, 2019 12:22 PM > To: Ard Biesheuvel ; linux-crypto@vger.kernel.org > Cc: herb...@gondor.apana.org.au; ebigg...@kernel.org; Ondrej Mo

RE: XTS template wrapping question

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Pascal Van Leeuwen > Sent: Friday, August 9, 2019 4:18 PM > To: Pascal Van Leeuwen ; > linux-crypto@vger.kernel.org; > herb...@gondor.apana.org.au; da...@davemloft.net; Eric Biggers > > Subject: RE: XTS template wrapping quest

[PATCH] crypto: aead - Do not allow authsize=0 if auth. alg has digestsize>0

2019-08-09 Thread Pascal van Leeuwen
testing purposes only. Signed-off-by: Pascal van Leeuwen --- crypto/aead.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/aead.c b/crypto/aead.c index 4908b5e..e423107 100644 --- a/crypto/aead.c +++ b/crypto/aead.c @@ -75,7 +75,8 @@ int crypto_aead_setauthsize(struct

RE: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Friday, August 9, 2019 7:17 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org > Subject: Re: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV > generation > > On Fri, Aug 09, 2019 at 0

RE: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Friday, August 9, 2019 10:56 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org > Subject: Re: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV > generation > > On Fri, Aug 09, 2019 at 0

RE: XTS template wrapping question

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Friday, August 9, 2019 6:46 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: XTS template wrapping question > > On Fri, Aug 0

RE: XTS template wrapping question

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Friday, August 9, 2019 7:07 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au; > da...@davemloft.net > Subject: Re: XTS template wrapping question > > On Fri, Aug 0

RE: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Eric Biggers > Sent: Saturday, August 10, 2019 12:05 AM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org > Subject: Re: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV > generation > > On Fri, Aug 09, 2019 at 0

RE: [PATCHv4 0/4] crypto: inside-secure - broaden driver scope

2019-08-19 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Herbert Xu > Sent: Thursday, August 15, 2019 1:51 PM > To: Pascal van Leeuwen > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@davemloft.net; Pascal >

[PATCHv5 1/4] crypto: inside-secure - make driver selectable for non-Marvell hardware

2019-08-19 Thread Pascal van Leeuwen
From: Pascal van Leeuwen While being a generic EIP97/EIP197 driver, the driver was only selectable for Marvell Armada hardware. This fix makes the driver selectable for any Device Tree supporting kernel configuration, allowing it to be used for other compatible hardware by just adding the

[PATCHv5 3/4] crypto: inside-secure - add support for PCI based FPGA development board

2019-08-19 Thread Pascal van Leeuwen
From: Pascal van Leeuwen This patch adds support for a PCIE development board with FPGA from Xilinx, to facilitate pre-silicon driver development by both Inside Secure and its IP customers. Since Inside Secure neither produces nor has access to actual silicon, this is required functionality to

[PATCHv5 0/4] crypto: inside-secure - broaden driver scope

2019-08-19 Thread Pascal van Leeuwen
refix "crypto_is_" to "safexcel_" for consistency changes since v4: - rebased so it applies on the latest state of cryptodev - fixed typo in safexcel.c that caused FW download fail on Macchiatobin Pascal van Leeuwen (4): crypto: inside-secure - make driver selectable for non-Marvel

[PATCHv5 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware

2019-08-19 Thread Pascal van Leeuwen
From: Pascal van Leeuwen Until now, the inside-secure driver required a set of firmware images supplied by the silicon vendor, typically under NDA, to be present in /lib/firmware/inside-secure in order to be able to function. This patch removes the dependence on this official vendor firmware by

[PATCHv5 2/4] crypto: inside-secure - Remove redundant algo to engine mapping code

2019-08-19 Thread Pascal van Leeuwen
removed now because otherwise the next patch will add new hardware which would otherwise have to be added to all algorithms, so now is a convenient time to just get rid of this. Signed-off-by: Pascal van Leeuwen Acked-by: Antoine Tenart --- drivers/crypto/inside-secure/safexcel.c| 9

RE: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver

2019-08-20 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Josh Boyer > Sent: Thursday, August 15, 2019 1:33 PM > To: Pascal van Leeuwen > Cc: Linux Firmware ; linux-crypto@vger.kernel.org > Subject: Re: [GIT PULL] inside-secure: add new G

RE: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver

2019-08-21 Thread Pascal Van Leeuwen
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Josh Boyer > Sent: Tuesday, August 20, 2019 3:10 PM > To: Pascal Van Leeuwen > Cc: Pascal van Leeuwen ; Linux Firmware > ; > linux-crypto@vger.kernel.org > Subject: Re: [GI

[GIT PULL v2] inside-secure: add new "mini" firmware for the EIP197 driver

2019-08-21 Thread Pascal van Leeuwen
728c53fbddc22ebaf49783de1fda7c4c66bde120: inside-secure: add new "mini" firmware for the EIP197 driver (2019-08-21 09:45:26 +0200) changes since v1: - changed license type from GPLv2 to redistributable Pascal van Leeuwen (1):

[PATCH 3/3] crypto: inside-secure - Only enable algorithms advertised by the hardware

2019-08-30 Thread Pascal van Leeuwen
van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 36 -- drivers/crypto/inside-secure/safexcel.h| 33 +++ drivers/crypto/inside-secure/safexcel_cipher.c | 19 ++ drivers/crypto/inside-secure/safexcel_hash.c | 12

[PATCH 0/3] crypto: inside-secure - Add AES-XTS cipher support

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for the AES-XTS algorithm for HW that supports it. Pascal van Leeuwen (3): crypto: inside-secure - Move static cipher alg & mode settings to init crypto: inside-secure - Add support for the AES-XTS algorithm crypto: inside-secure - Only enable algorithms advert

[PATCH 1/3] crypto: inside-secure - Move static cipher alg & mode settings to init

2019-08-30 Thread Pascal van Leeuwen
ctx->alg and ctx->mode were set from safexcel_send_req through the various safexcel_encrypt and _decrypt routines, but this makes little sense as these are static per ciphersuite. So moved to _init instead, in preparation of adding more ciphersuites. Signed-off-by: Pascal van L

[PATCH 2/3] crypto: inside-secure - Add support for the AES-XTS algorithm

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for the AES-XTS skcipher algorithm. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 + drivers/crypto/inside-secure/safexcel_cipher.c | 124 - 3

[PATCH] crypto: inside-secure - Made .cra_priority value a define

2019-08-30 Thread Pascal van Leeuwen
Instead of having a fixed value (of 300) all over the place, the value for for .cra_priority is now made into a define (SAFEXCEL_CRA_PRIORITY). This makes it easier to play with, e.g. during development. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.h| 3

[PATCH] crypto: inside-secure - Minor code cleanup and optimizations

2019-08-30 Thread Pascal van Leeuwen
Some minor cleanup changing e.g. "if (!x) A else B" to "if (x) B else A", merging some back-to-back if's with the same condition, collapsing some back-to-back assignments to the same variable and replacing some weird assignments with proper symbolics. Signed-o

[PATCH] crypto: inside-secure - Minor optimization recognizing CTR is always AES

2019-08-30 Thread Pascal van Leeuwen
Moved counter mode handling code in front as it doesn't depend on the rest of the code to be executed, it can just do its thing and exit. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel_cipher.c | 25 ++--- 1 file changed, 14 insertions(+

[PATCH 0/4] Add support for AES-GCM, AES-CFB, AES-OFB and AES-CCM

2019-08-30 Thread Pascal van Leeuwen
This patchset adds support for the AES-GCM and AES-CCM AEAD ciphersuites and the AES-CFB and AES-OFB feedback modes for AES. Pascal van Leeuwen (4): crypto: inside-secure - Added support for basic AES-GCM crypto: inside-secure - Added AES-CFB support crypto: inside-secure - Added AES-OFB

[PATCH 4/4] crypto: inside-secure - Added support for basic AES-CCM

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for the basic AES-CCM AEAD cipher suite. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 +- drivers/crypto/inside-secure/safexcel.h| 10 +- drivers/crypto/inside-secure/safexcel_cipher.c | 288

[PATCH 3/4] crypto: inside-secure - Added AES-OFB support

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for AES in output feedback mode (AES-OFB). Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 1 + drivers/crypto/inside-secure/safexcel.h| 2 ++ drivers/crypto/inside-secure/safexcel_cipher.c | 36

[PATCH 1/4] crypto: inside-secure - Added support for basic AES-GCM

2019-08-30 Thread Pascal van Leeuwen
This patch adds support for the basic AES-GCM AEAD cipher suite. Signed-off-by: Pascal van Leeuwen --- drivers/crypto/inside-secure/safexcel.c| 4 +- drivers/crypto/inside-secure/safexcel.h| 7 +- drivers/crypto/inside-secure/safexcel_cipher.c | 226

<    1   2   3   4