Re: [PATCH] crypto: ccp - Fix sparse warnings

2020-07-07 Thread John Allen
On Fri, Jul 03, 2020 at 02:46:52PM +1000, Herbert Xu wrote: > This patch fixes a number of endianness marking issues in the ccp > driver. > > Signed-off-by: Herbert Xu Acked-by: John Allen

Re: [PATCH v4 07/13] crypto: ccp - permit asynchronous skcipher as fallback

2020-07-07 Thread John Allen
allocating an ordinary skcipher > as the fallback, and invoke it with the completion routine that was given > to the outer request. > > Signed-off-by: Ard Biesheuvel Acked-by: John Allen

Re: [PATCH] crypto: ccp - Silence strncpy warning

2020-07-09 Thread John Allen
On Thu, Jul 09, 2020 at 10:44:04PM +1000, Herbert Xu wrote: > This patch kills an strncpy by using strscpy instead. The name > would be silently truncated if it is too long. > > Signed-off-by: Herbert Xu Acked-by: John Allen

Re: [PATCH v2] crypto: ccp: sp-pci: use generic power management

2020-07-22 Thread John Allen
the generic framework, PCI Core takes care of the necessary operations, > and drivers are required to do only device-specific jobs. > > Signed-off-by: Vaibhav Gupta Acked-by: John Allen

Re: [v3 PATCH 21/31] crypto: ccp - Remove rfc3686 implementation

2020-08-06 Thread John Allen
On Tue, Jul 28, 2020 at 05:19:26PM +1000, Herbert Xu wrote: > The rfc3686 implementation in ccp is pretty much the same > as the generic rfc3686 wrapper. So it can simply be removed to > reduce complexity. > > Signed-off-by: Herbert Xu Acked-by: John Allen

Re: [PATCH] crypto: ccp - fix error handling

2020-09-22 Thread John Allen
On Mon, Sep 21, 2020 at 01:34:35PM +0200, Pavel Machek wrote: > Fix resource leak in error handling. > > Signed-off-by: Pavel Machek (CIP) Acked-by: John Allen > > diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c > index bd270e66185e..40869ea1e

[PATCH] crypto: ccp - Fix use of merged scatterlists

2020-06-22 Thread John Allen
seen is equal to the DMA length of the current entry being processed in the DMA mapped representation. Fixes: 63b945091a070 ("crypto: ccp - CCP device driver and interface support") Signed-off-by: John Allen Cc: sta...@vger.kernel.org --- drivers/crypto/ccp/ccp-dev.h | 1 + drivers/

Re: [PATCH] crypto: ccp - Fix use of merged scatterlists

2020-06-25 Thread John Allen
On Thu, Jun 25, 2020 at 02:53:55PM +, Sasha Levin wrote: > Hi > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag > fixing commit: 63b945091a07 ("crypto: ccp - CCP device driver and interface > support"). > > The bot has tested the followin

Re: [PATCH v2] crypto: ccp - Update CCP driver maintainer information

2020-06-26 Thread John Allen
On Fri, Jun 26, 2020 at 02:09:39PM -0500, Tom Lendacky wrote: > From: Tom Lendacky > > Add John Allen as a new CCP driver maintainer. Additionally, break out > the driver SEV support and create a new maintainer entry, with Brijesh > Singh and Tom Lendacky as maintainers. >

Re: problem with ccp-crypto module on apu

2020-12-28 Thread John Allen
On Thu, Dec 17, 2020 at 07:42:52AM +, Domen Stangar wrote: > Hi, > I would like to report issue with ccp-crypto. > When I issue modprobe command, it would not continue, without SIGINT signal > (ctrl+c). > If module is compiled in kernel, boot doesn't finish. > Looks like problem is that ecb(aes

Re: problem with ccp-crypto module on apu

2021-01-07 Thread John Allen
On Mon, Jan 04, 2021 at 04:10:26PM +, Domen Stangar wrote: > Device name: ccp-1 >RNG name: ccp-1-rng ># Queues: 3 > # Cmds: 0 > Version: 5 > Engines: AES 3DES SHA RSA ECC ZDE TRNG > Queues: 5 > LSB Entries: 128 > > Let me know if you need anything else. Hi Domen, Lo

Re: [PATCH v3 06/19] crypto: ccp: convert tasklets to use new tasklet_setup() API

2021-01-13 Thread John Allen
pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais Acked-by: John Allen > --- > drivers/crypto/ccp/ccp-dev-v3.c| 9 - > drivers/crypto/ccp/ccp-dev-v5.c| 9 - > drivers/crypto/ccp/ccp-dmaengine.c | 7 +++ > 3 fil

Re: [PATCH] crypto: ccp -A value assigned to a variable is never used.

2021-03-31 Thread John Allen
On Tue, Mar 30, 2021 at 06:10:29PM +0800, Jiapeng Chong wrote: > Fix the following whitescan warning: > > Assigning value "64" to "dst.address" here, but that stored value is > overwritten before it can be used. > Thanks for reporting. Acked-by: John