Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-08-07 Thread Jakub Kicinski
On Fri, 7 Aug 2020 19:39:19 +0530 Srujana Challa wrote: > Add support for the cryptographic acceleration unit (CPT) on > OcteonTX2 CN96XX SoC. Please address the W=1 C=1 build warnings ../drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c:475:51: warning: cast removes address space '__iomem' of

Re: [PATCH v3,net-next,0/4] Add Support for Marvell OcteonTX2 Cryptographic

2020-09-17 Thread Jakub Kicinski
On Thu, 17 Sep 2020 18:58:31 +0530 Srujana Challa wrote: > The following series adds support for Marvell Cryptographic Acceleration > Unit(CPT) on OcteonTX2 CN96XX SoC. > This series is tested with CRYPTO_EXTRA_TESTS enabled and > CRYPTO_DISABLE_TESTS disabled. No writeable debugfs files, please.

Re: [RFC 1/1] net/tls(TLS_SW): Handle -ENOSPC error return from device/AES-NI

2020-10-07 Thread Jakub Kicinski
On Wed, 7 Oct 2020 15:19:47 -0400 Pooja Trivedi wrote: > When an -ENOSPC error code is returned by the crypto device or AES-NI > layer, TLS SW path sets an EBADMSG on the socket causing the > application to fail. In an attempt to address the -ENOSPC in the TLS > SW path, changes were made in tls_s

Re: [RFC 1/1] net/tls(TLS_SW): Handle -ENOSPC error return from device/AES-NI

2020-10-09 Thread Jakub Kicinski
On Thu, 8 Oct 2020 16:35:34 +1100 Herbert Xu wrote: > Jakub Kicinski wrote: > > > > Why would the driver return EBUSY from an async API? What's the caller > > supposed to do with that? > > The Crypto API offers two modes for callers to deal with congestion

Re: [PATCH v4,net-next,00/13] Add Support for Marvell OcteonTX2 Cryptographic

2020-10-09 Thread Jakub Kicinski
On Fri, 9 Oct 2020 21:04:08 +0530 Srujana Challa wrote: > This series introduces crypto(CPT) drivers(PF & VF) for Marvell OcteonTX2 > CN96XX Soc. > > OcteonTX2 SOC's resource virtualization unit (RVU) supports multiple > physical and virtual functions. Each of the PF/VF's functionality is > determ

Re: [PATCH v7,net-next,02/13] octeontx2-af: add mailbox interface for CPT

2020-10-14 Thread Jakub Kicinski
On Mon, 12 Oct 2020 16:27:08 +0530 Srujana Challa wrote: > On OcteonTX2 SoC, the admin function (AF) is the only one with all > priviliges to configure HW and alloc resources, PFs and it's VFs > have to request AF via mailbox for all their needs. This patch adds > a mailbox interface for CPT PFs an

Re: [PATCH v7,net-next,03/13] octeontx2-af: add debugfs entries for CPT block

2020-10-14 Thread Jakub Kicinski
On Mon, 12 Oct 2020 16:27:09 +0530 Srujana Challa wrote: > +static ssize_t rvu_dbg_cpt_cmd_parser(struct file *filp, > + const char __user *buffer, size_t count, > + loff_t *ppos) > +{ > + struct seq_file *s = filp->private_dat

Re: [PATCH v7,net-next,04/13] drivers: crypto: add Marvell OcteonTX2 CPT PF driver

2020-10-14 Thread Jakub Kicinski
On Mon, 12 Oct 2020 16:27:10 +0530 Srujana Challa wrote: > +union otx2_cptx_lf_misc_int { > + u64 u; > + struct otx2_cptx_lf_misc_int_s { > + u64 reserved_0:1; > + u64 nqerr:1; > + u64 irde:1; > + u64 nwrp:1; > + u64 reserved_4:1;

Re: [PATCH v7,net-next,04/13] drivers: crypto: add Marvell OcteonTX2 CPT PF driver

2020-10-14 Thread Jakub Kicinski
On Mon, 12 Oct 2020 16:27:10 +0530 Srujana Challa wrote: > + err = pci_set_dma_mask(pdev, DMA_BIT_MASK(48)); > + err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(48)); dma_set_mask_and_coherent()

Re: [PATCH v7,net-next,07/13] crypto: octeontx2: load microcode and create engine groups

2020-10-14 Thread Jakub Kicinski
On Mon, 12 Oct 2020 16:27:13 +0530 Srujana Challa wrote: > +/* tar header as defined in POSIX 1003.1-1990. */ > +struct tar_hdr_t { > + char name[100]; > + char mode[8]; > + char uid[8]; > + char gid[8]; > + char size[12]; > + char mtime[12]; > + char chksum[8]; > +

Re: [PATCH v8,net-next,00/12] Add Support for Marvell OcteonTX2

2020-10-19 Thread Jakub Kicinski
On Mon, 19 Oct 2020 17:11:45 +0530 Srujana Challa wrote: > This series introduces crypto(CPT) drivers(PF & VF) for Marvell OcteonTX2 > CN96XX Soc. e have already sent a pull request for 5.10 and therefore net-next is closed for new drivers, features, and code refactoring. Please repost when net-

Re: [PATCH net-next 00/15] in_interrupt() cleanup, part 2

2020-10-30 Thread Jakub Kicinski
On Tue, 27 Oct 2020 23:54:39 +0100 Sebastian Andrzej Siewior wrote: > Folks, > > in the discussion about preempt count consistency across kernel > configurations: > > https://lore.kernel.org/r/20200914204209.256266...@linutronix.de/ > > Linus clearly requested that code in drivers and librari

Re: [PATCH net-next 04/15] net: mlx5: Replace in_irq() usage.

2020-10-31 Thread Jakub Kicinski
ady so > using it for the lock variant decision is a straight forward replacement > for in_irq(). > > Signed-off-by: Sebastian Andrzej Siewior > Cc: Saeed Mahameed > Cc: Leon Romanovsky > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-r...@vger.kernel.org Saeed, please pick this up into your tree.

Re: [PATCH net-next 00/15] in_interrupt() cleanup, part 2

2020-10-31 Thread Jakub Kicinski
On Tue, 27 Oct 2020 23:54:39 +0100 Sebastian Andrzej Siewior wrote: > Folks, > > in the discussion about preempt count consistency across kernel > configurations: > > https://lore.kernel.org/r/20200914204209.256266...@linutronix.de/ > > Linus clearly requested that code in drivers and librari

Re: [PATCH net-next 14/15] net: dpaa: Replace in_irq() usage.

2020-10-31 Thread Jakub Kicinski
andler and NAPI should be scheduled. > > Signed-off-by: Sebastian Andrzej Siewior > Cc: "Horia Geantă" > Cc: Aymen Sghaier > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Madalin Bucur > Cc: Jakub Kicinski > Cc: Li Yang > Cc: linux-crypto@vger.kernel

Re: [PATCH v8,net-next,00/12] Add Support for Marvell OcteonTX2

2020-10-31 Thread Jakub Kicinski
On Sat, 31 Oct 2020 15:28:59 -0400 Willem de Bruijn wrote: > The point about parsing tar files remains open. In general error-prone > parsing is better left to userspace. The tar files have to go. Srujana said they have 3 files to load, just load them individually.

Re: [PATCH v9,net-next,05/12] crypto: octeontx2: add mailbox communication with AF

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:39:17 +0530 Srujana Challa wrote: > + err = pci_alloc_irq_vectors(pdev, RVU_PF_INT_VEC_CNT, > + RVU_PF_INT_VEC_CNT, PCI_IRQ_MSIX); I don't see any pci_free_irq_vectors() in this patch

Re: [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework

2020-11-11 Thread Jakub Kicinski
On Mon, 9 Nov 2020 17:39:24 +0530 Srujana Challa wrote: > CPT offload module utilises the linux crypto framework to offload > crypto processing. This patch registers supported algorithms by > calling registration functions provided by the kernel crypto API. > > The module currently supports: > - A

Re: [EXT] Re: [PATCH v9,net-next,05/12] crypto: octeontx2: add mailbox communication with AF

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 07:07:34 + Srujana Challa wrote: > > On Mon, 9 Nov 2020 17:39:17 +0530 Srujana Challa wrote: > > > + err = pci_alloc_irq_vectors(pdev, RVU_PF_INT_VEC_CNT, > > > + RVU_PF_INT_VEC_CNT, PCI_IRQ_MSIX); > > > > I don't see any pci_free_irq_vectors

Re: chapoly acceleration hardware [Was: Re: [RFC PATCH 00/18] crypto: wireguard using the existing crypto API]

2019-09-26 Thread Jakub Kicinski
On Thu, 26 Sep 2019 13:06:51 +0200, Jason A. Donenfeld wrote: > On Thu, Sep 26, 2019 at 12:19 PM Pascal Van Leeuwen wrote: > > Actually, that assumption is factually wrong. I don't know if anything > > is *publicly* available, but I can assure you the silicon is running in > > labs already. And som

Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-18 Thread Jakub Kicinski
On Sun, 17 May 2020 16:26:36 + Pooja Trivedi wrote: > In pure sw ktls(AES-NI), -EAGAIN from tcp layer (do_tcp_sendpages for > encrypted record) gets treated as error, subtracts the offset, and > returns to application. Because of this, application sends data from > subtracted offset, which lead

Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-19 Thread Jakub Kicinski
On Tue, 19 May 2020 13:21:56 -0400 Pooja Trivedi wrote: > On Mon, May 18, 2020 at 6:50 PM Jakub Kicinski wrote: > > On Sun, 17 May 2020 16:26:36 + Pooja Trivedi wrote: > > > In pure sw ktls(AES-NI), -EAGAIN from tcp layer (do_tcp_sendpages for > > > encrypted re

Re: [PATCH net] net/tls(TLS_SW): Fix integrity issue with non-blocking sw KTLS request

2020-05-20 Thread Jakub Kicinski
On Wed, 20 May 2020 15:56:56 -0400 Pooja Trivedi wrote: > On Tue, May 19, 2020 at 5:43 PM Jakub Kicinski wrote: > > > > On Tue, 19 May 2020 13:21:56 -0400 Pooja Trivedi wrote: > > > On Mon, May 18, 2020 at 6:50 PM Jakub Kicinski wrote: > > > > On Sun, 17 M

Re: [RFC PATCH net 1/1] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test

2020-06-02 Thread Jakub Kicinski
On Tue, 2 Jun 2020 14:56:25 + Pooja Trivedi wrote: > This selftest tests for cases where sendfile's 'count' > parameter is provided with a size greater than the intended > file size. > > Motivation: When sendfile is provided with 'count' parameter > value that is greater than the size of the

Re: [PATCH net] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test

2020-06-05 Thread Jakub Kicinski
off-by: Mallesham Jatharkonda > > Signed-off-by: Josh Tway Looks good to me, but I'm not 100% sure we want to merge it before the fix is merged. Reviewed-by: Jakub Kicinski Thanks!

Re: INFO: task hung in tls_sw_release_resources_tx

2019-08-16 Thread Jakub Kicinski
On Thu, 15 Aug 2019 11:06:00 -0700, syzbot wrote: > syzbot has bisected this bug to: > > commit 130b392c6cd6b2aed1b7eb32253d4920babb4891 > Author: Dave Watson > Date: Wed Jan 30 21:58:31 2019 + > > net: tls: Add tls 1.3 support > > bisection log: https://syzkaller.appspot.com/x/bise

Re: INFO: task hung in tls_sw_sendmsg

2019-08-19 Thread Jakub Kicinski
On Mon, 11 Mar 2019 01:20:05 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:d9862cfb Merge tag 'mips_5.1' of git://git.kernel.org/pub/.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=16e9d97720 > kernel confi

Re: INFO: task hung in tls_sw_release_resources_tx

2019-08-19 Thread Jakub Kicinski
On Fri, 16 Aug 2019 22:47:43 -0700, Eric Biggers wrote: > [+Steffen, who is the maintainer of pcrypt] > > On Fri, Aug 16, 2019 at 07:02:34PM -0700, Jakub Kicinski wrote: > > On Thu, 15 Aug 2019 11:06:00 -0700, syzbot wrote: > > > syzbot has bisected this bug

Re: INFO: task hung in tls_sw_release_resources_tx

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 14:12:55 -0700, Jakub Kicinski wrote: > Looks like the dup didn't tickle syzbot the right way. Let me retry > sending this directly to the original report. Oh, no, my bad, there was just a third bug of the same nature. tls_sw_release_resources_tx got renamed at

Re: [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework

2020-11-13 Thread Jakub Kicinski
On Fri, 13 Nov 2020 14:16:01 +1100 Herbert Xu wrote: > On Wed, Nov 11, 2020 at 04:10:39PM -0800, Jakub Kicinski wrote: > > On Mon, 9 Nov 2020 17:39:24 +0530 Srujana Challa wrote: > > > CPT offload module utilises the linux crypto framework to offload > > > crypto proce

Re: [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 07:59:56 + Srujana Challa wrote: > > On Fri, Nov 13, 2020 at 08:44:40AM -0800, Jakub Kicinski wrote: > > > > > > SGTM, actually everything starting from patch 4 is in drivers/crypto, > > > so we can merge the first 3 into net-next and th

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote: > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple break/goto/return/fallt

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote: > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A. R. Silva wrote: > > > This series aims to fix almost all remaining fall-through warnings in > > >

Re: [net-next v2 0/5] Add CHACHA20-POLY1305 cipher to Kernel TLS

2020-11-27 Thread Jakub Kicinski
On Tue, 24 Nov 2020 18:24:45 +0300 Vadim Fedorenko wrote: > RFC 7905 defines usage of ChaCha20-Poly1305 in TLS connections. This > cipher is widely used nowadays and it's good to have a support for it > in TLS connections in kernel. > Changes v2: > nit fixes suggested by Ja

Re: [net-next v4 00/14] Add Marvell CN10K support

2021-02-08 Thread Jakub Kicinski
On Sat, 6 Feb 2021 04:19:59 +0530 Geetha sowjanya wrote: > The current admin function (AF) driver and the netdev driver supports > OcteonTx2 silicon variants. The same OcteonTx2's > Resource Virtualization Unit (RVU) is carried forward to the next-gen > silicon ie OcteonTx3, with some changes and f