Re: [v3 PATCH] hwrng: core - Remove add_early_randomness

2024-05-22 Thread Jarkko Sakkinen
On Wed May 22, 2024 at 8:37 AM EEST, Herbert Xu wrote: > On Tue, May 21, 2024 at 03:37:16PM -0400, Nícolas F. R. A. Prado wrote: > > > > FWIW this patch fixes the warning. So feel free to add > > > > Tested-by: Nícolas F. R. A. Prado > > Could you please test this patch instead? > > ---8<--- > A

Re: [v3 PATCH] hwrng: core - Remove add_early_randomness

2024-05-22 Thread Nícolas F . R . A . Prado
On Wed, May 22, 2024 at 01:37:54PM +0800, Herbert Xu wrote: > On Tue, May 21, 2024 at 03:37:16PM -0400, Nícolas F. R. A. Prado wrote: > > > > FWIW this patch fixes the warning. So feel free to add > > > > Tested-by: Nícolas F. R. A. Prado > > Could you please test this patch instead? > > ---8<-

Re: [v3 PATCH] hwrng: core - Remove add_early_randomness

2024-05-22 Thread Linus Torvalds
On Tue, 21 May 2024 at 22:38, Herbert Xu wrote: > > In this particular configuration, the deadlock doesn't exist because > the warning triggered at a point before modules were even available. > However, the deadlock can be real because any module loaded would > invoke async_synchronize_full. I th

Re: [v3 PATCH] hwrng: core - Remove add_early_randomness

2024-05-22 Thread Herbert Xu
On Wed, May 22, 2024 at 03:53:23PM -0700, Linus Torvalds wrote: > > That said, looking at the code in question, there are other oddities > going on. Even the "we found a favorite new rng" case looks rather > strange. The thread we use - nice and asynchronous - seems to sleep > only if the randomne

Re: [v3 PATCH] hwrng: core - Remove add_early_randomness

2024-05-22 Thread Herbert Xu
On Wed, May 22, 2024 at 02:51:36PM +0300, Jarkko Sakkinen wrote: > > What is the kthread doing this currently? It's hwrng_fillfn. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt