[REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Karel Balej
Dimitri, Johannes, ever since upgrading to Linux v6.7 I am unable to connect to a 802.1X wireless network (specifically, eduroam). In my dmesg, the following messages appear: [ 68.161621] wlan0: authenticate with xx:xx:xx:xx:xx:xx (local address=xx:xx:xx:xx:xx:xx) [ 68.163733

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Johannes Berg
Not sure why you're CC'ing the world, but I guess adding a few more doesn't hurt ... On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: > > and I use iwd This is your problem, the wireless stack in the kernel doesn't use any kernel crypto code for 802.1X. I suppose iwd wants to use the kern

[PATCH 0/2] Add Inline Crypto Engine for SC7280 UFS

2024-03-13 Thread Luca Weiss
Add the required bits to support Inline Crypto Engine on SC7280 SoC with UFS. Signed-off-by: Luca Weiss --- Luca Weiss (2): dt-bindings: crypto: ice: Document sc7280 inline crypto engine arm64: dts: qcom: sc7280: Add inline crypto engine .../devicetree/bindings/crypto/qcom,inline-cr

[PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine

2024-03-13 Thread Luca Weiss
Document the compatible used for the inline crypto engine found on SC7280. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine

[PATCH 2/2] arm64: dts: qcom: sc7280: Add inline crypto engine

2024-03-13 Thread Luca Weiss
Add the ICE found on sc7280 and link it to the UFS node. For reference: [0.261424] qcom-ice 1d88000.crypto: Found QC Inline Crypto Engine (ICE) v3.2.0 Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm

Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add inline crypto engine

2024-03-13 Thread Konrad Dybcio
On 3/13/24 13:53, Luca Weiss wrote: Add the ICE found on sc7280 and link it to the UFS node. For reference: [0.261424] qcom-ice 1d88000.crypto: Found QC Inline Crypto Engine (ICE) v3.2.0 Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] dt-bindings: crypto: ice: Document sc7280 inline crypto engine

2024-03-13 Thread Krzysztof Kozlowski
On 13/03/2024 13:53, Luca Weiss wrote: > Document the compatible used for the inline crypto engine found on > SC7280. > > Signed-off-by: Luca Weiss > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread James Prestwood
Hi, On 3/13/24 1:56 AM, Johannes Berg wrote: Not sure why you're CC'ing the world, but I guess adding a few more doesn't hurt ... On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: and I use iwd This is your problem, the wireless stack in the kernel doesn't use any kernel crypto code for

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Michael Yartys
Hi This came in via the iwd mailing list, and I would like to add some small a detail as I also experience this issue on my university eduroam network. I've verified that the certificate chain doesn't contain SHA-1 signed certificates, so the update breaks more than just SHA-1. Michael On

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: > Hi, > > On 3/13/24 1:56 AM, Johannes Berg wrote: > > Not sure why you're CC'ing the world, but I guess adding a few more > > doesn't hurt ... > > > > On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: > > > and I use iwd > >

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Karel Balej
Thank you all for your feedback so far. Since it seems that this really is a regression on the kernel side, let me add the appropriate list to Cc and tag this: #regzbot introduced: 16ab7cb5825f Best regards, K. B.

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread James Prestwood
Hi, On 3/13/24 12:44 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: Hi, On 3/13/24 1:56 AM, Johannes Berg wrote: Not sure why you're CC'ing the world, but I guess adding a few more doesn't hurt ... On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood wrote: > Hi, > > On 3/13/24 12:44 PM, Eric Biggers wrote: > > On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: > > > Hi, > > > > > > On 3/13/24 1:56 AM, Johannes Berg wrote: > > > > Not sure why you're CC'ing the world, but

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread James Prestwood
Hi, On 3/13/24 1:22 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood wrote: Hi, On 3/13/24 12:44 PM, Eric Biggers wrote: On Wed, Mar 13, 2024 at 10:26:06AM -0700, James Prestwood wrote: Hi, On 3/13/24 1:56 AM, Johannes Berg wrote: Not sure why you're CC'ing

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: > Hi, > > On 3/13/24 1:22 PM, Eric Biggers wrote: > > On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood wrote: > > > Hi, > > > > > > On 3/13/24 12:44 PM, Eric Biggers wrote: > > > > On Wed, Mar 13, 2024 at 10:26:06AM -0700,

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Jeff Johnson
On 3/13/2024 3:10 PM, Eric Biggers wrote: > On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: >> Hi, >> >> On 3/13/24 1:22 PM, Eric Biggers wrote: >>> On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood wrote: Hi, On 3/13/24 12:44 PM, Eric Biggers wrote: > On

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 03:51:10PM -0700, Jeff Johnson wrote: > On 3/13/2024 3:10 PM, Eric Biggers wrote: > > On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: > >> Hi, > >> > >> On 3/13/24 1:22 PM, Eric Biggers wrote: > >>> On Wed, Mar 13, 2024 at 01:12:54PM -0700, James Prestwood w

Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support

2024-03-13 Thread Eric Biggers
On Wed, Mar 13, 2024 at 04:06:11PM -0700, Eric Biggers wrote: > On Wed, Mar 13, 2024 at 03:51:10PM -0700, Jeff Johnson wrote: > > On 3/13/2024 3:10 PM, Eric Biggers wrote: > > > On Wed, Mar 13, 2024 at 02:17:29PM -0700, James Prestwood wrote: > > >> Hi, > > >> > > >> On 3/13/24 1:22 PM, Eric Bigger