Re: [PATCH] crypto: virtio-crypto: Handle dataq logic with tasklet

2023-12-01 Thread Herbert Xu
Gonglei Arei wrote: > Doing ipsec produces a spinlock recursion warning. > This is due to crypto_finalize_request() being called in the upper half. > Move virtual data queue processing of virtio-crypto driver to tasklet. > > Fixes: dbaf0624ffa57 ("crypto: add virtio-crypto driver") > Reported-by:

Re: [PATCH][next] powerpc/crypto: Avoid -Wstringop-overflow warnings

2023-12-01 Thread Herbert Xu
On Tue, Nov 21, 2023 at 12:52:44PM -0600, Gustavo A. R. Silva wrote: > The compiler doesn't know that `32` is an offset into the Hash table: > > 56 struct Hash_ctx { > 57 u8 H[16]; /* subkey */ > 58 u8 Htable[256]; /* Xi, Hash table(offset 32) */ > 59 }; > > So, it legit

Re: [PATCH] crypto: virtio-crypto: Handle dataq logic with tasklet

2023-12-01 Thread Michael S. Tsirkin
On Mon, Nov 20, 2023 at 11:49:45AM +, Gonglei (Arei) wrote: > Doing ipsec produces a spinlock recursion warning. > This is due to crypto_finalize_request() being called in the upper half. > Move virtual data queue processing of virtio-crypto driver to tasklet. > > Fixes: dbaf0624ffa57 ("crypto