Re: [PATCH] crypto: arm/blake2s - fix for big endian

2021-03-10 Thread Ard Biesheuvel
On Wed, 10 Mar 2021 at 08:29, Eric Biggers wrote: > > From: Eric Biggers > > The new ARM BLAKE2s code doesn't work correctly (fails the self-tests) > in big endian kernel builds because it doesn't swap the endianness of > the message words when loading them. Fix this. > > Fixes: 5172d322d34c ("c

[PATCH v3 0/2] crypto: arm - clean up redundant helper macros

2021-03-10 Thread Ard Biesheuvel
Now that ARM's asm/assembler.h provides mov_l and rev_l macros, let's get rid of the locally defined ones that live in the ChaCha and AES crypto code. Changes since v2: - fix rev_32->rev_l in the patch subject lines - add Eric's ack Changes since v1: - drop the patch that introduces rev_l, it has

[PATCH v3 2/2] crypto: arm/chacha-scalar - switch to common rev_l macro

2021-03-10 Thread Ard Biesheuvel
Drop the local definition of a byte swapping macro and use the common one instead. Signed-off-by: Ard Biesheuvel Reviewed-by: Nicolas Pitre Reviewed-by: Geert Uytterhoeven Reviewed-by: Linus Walleij Reviewed-by: Eric Biggers --- arch/arm/crypto/chacha-scalar-core.S | 43 ++--

[PATCH v3 1/2] crypto: arm/aes-scalar - switch to common rev_l/mov_l macros

2021-03-10 Thread Ard Biesheuvel
The scalar AES implementation has some locally defined macros which reimplement things that are now available in macros defined in assembler.h. So let's switch to those. Signed-off-by: Ard Biesheuvel Reviewed-by: Nicolas Pitre Reviewed-by: Geert Uytterhoeven Reviewed-by: Linus Walleij Reviewed

Re: [PATCH] crypto: public_key: check that pkey_algo is non-NULL before passing it to strcmp()

2021-03-10 Thread Greg KH
On Mon, Jan 18, 2021 at 06:13:02PM +0100, Toke Høiland-Jørgensen wrote: > David Howells writes: > > > Toke Høiland-Jørgensen wrote: > > > >> Reviewed-by: Toke Høiland-Jørgensen > >> > >> and also, if you like: > >> > >> Tested-by: Toke Høiland-Jørgensen > > > > Thanks! > > Any chance of tha

Caleb Leo Foundation,

2021-03-10 Thread JOHN UMAH
Caleb Leo Foundation 1501 K St NWWashington DC 20005 United States of America You've received $ 1,300,000 from the Calab Leo Foundation course Humanitarian aid / poverty reduction program. In the case of claims for this gift, please fill in the following form; Full name: Telephone number: State: C

Re: [PATCH v11 01/10] oid_registry: Add OIDs for ECDSA with sha224/256/384/512

2021-03-10 Thread Jarkko Sakkinen
On Fri, Mar 05, 2021 at 03:59:47PM -0500, Stefan Berger wrote: > From: Stefan Berger > > Add OIDs for ECDSA with sha224/256/384/512. Nit: SHA224/256/384/512 (sorry cannot help myself with these, have been doing this way too much, consider me as a bot :-) ) > > Signed-off-by: Stefan Berger A

Re: [PATCH v11 03/10] crypto: Add NIST P384 curve parameters

2021-03-10 Thread Jarkko Sakkinen
On Fri, Mar 05, 2021 at 03:59:49PM -0500, Stefan Berger wrote: > From: Saulo Alessandre > > Add the parameters for the NIST P384 curve and define a new curve ID > for it. Make the curve available in ecc_get_curve. > > Summary of changes: > > * crypto/ecc_curve_defs.h > - add nist_p384 params

Re: [PATCH v11 05/10] ecdsa: Register NIST P384 and extend test suite

2021-03-10 Thread Jarkko Sakkinen
On Fri, Mar 05, 2021 at 03:59:51PM -0500, Stefan Berger wrote: > From: Saulo Alessandre > > Register NIST P384 as an akcipher and extend the testmgr with > NIST P384-specific test vectors. > > Summary of changes: > > * crypto/ecdsa.c > - add ecdsa_nist_p384_init_tfm > - register and unregis

Re: [PATCH v11 10/10] certs: Add support for using elliptic curve keys for signing modules

2021-03-10 Thread Jarkko Sakkinen
On Fri, Mar 05, 2021 at 03:59:56PM -0500, Stefan Berger wrote: > From: Stefan Berger > > Add support for using elliptic curve keys for signing modules. It uses > a NIST P384 (secp384r1) key if the user chooses an elliptic curve key > and will have ECDSA support built into the kernel. > > Note: A

Re: [PATCH v11 01/10] oid_registry: Add OIDs for ECDSA with sha224/256/384/512

2021-03-10 Thread Stefan Berger
On 3/10/21 10:35 AM, Jarkko Sakkinen wrote: On Fri, Mar 05, 2021 at 03:59:47PM -0500, Stefan Berger wrote: From: Stefan Berger Add OIDs for ECDSA with sha224/256/384/512. Nit: SHA224/256/384/512 (sorry cannot help myself with these, have been doing this way too much, consider me as a bot :-

Re: [PATCH v11 01/10] oid_registry: Add OIDs for ECDSA with sha224/256/384/512

2021-03-10 Thread Jarkko Sakkinen
On Wed, Mar 10, 2021 at 01:38:12PM -0500, Stefan Berger wrote: > > On 3/10/21 10:35 AM, Jarkko Sakkinen wrote: > > On Fri, Mar 05, 2021 at 03:59:47PM -0500, Stefan Berger wrote: > > > From: Stefan Berger > > > > > > Add OIDs for ECDSA with sha224/256/384/512. > > Nit: SHA224/256/384/512 (sorry c