The crypto mediatek driver has been replaced by the inside-secure driver now.
Remove DT bindings documentation and update crypto engine nodes to the
mt7623.dtsi files.
Signed-off-by: Vic Wu
Acked-by: Ryder Lee
---
Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 25
---
Hi Herbert,
> El 3 mar 2021, a las 10:20, Herbert Xu escribió:
>
> On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote:
>>
>> I ran rngtest and this is what I got:
>
> This is meaningless except for sources that have not been whitened.
>
> Your justification needs to be bas
Fixes the following W=1 kernel build warning(s):
drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines
supporting VMX instructions on the Power 8(). Prototype was for p8_init()
instead
Cc: "Breno Leitão"
Cc: Nayna Jain
Cc: Paulo Flabiano Smorigo
Cc: Michael Ellerman
Cc: Be
On Tue, Feb 09, 2021 at 02:59:23PM +0800, chenxiang wrote:
> From: Xiang Chen
>
> For function dma_unmap_sg(), the parameter should be number of
> elements in the scatterlist prior to the mapping, not after the mapping.
> So fix this usage.
>
> Signed-off-by: Xiang Chen
> ---
> drivers/crypto
On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote:
>
> I ran rngtest and this is what I got:
This is meaningless except for sources that have not been whitened.
Your justification needs to be based on what the hardware does or
is documented to do.
Thanks,
--
Email: Herbert
Fixes the following W=1 kernel build warning(s):
drivers/crypto/atmel-ecc.c:41: warning: cannot understand function prototype:
'struct atmel_ecdh_ctx '
Cc: Tudor Ambarus
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Nicolas Ferre
Cc: Alexandre Belloni
Cc: Ludovic Desroches
Cc: linux-crypto@vge
On Wed, Feb 24, 2021 at 10:29:13AM -0600, Josh Poimboeuf wrote:
> Standardize the crypto asm to make it resemble compiler-generated code,
> so that objtool can understand it.
>
> This magically enables ORC unwinding from crypto code. It also fixes
> the last known remaining objtool warnings on vm
Fixes the following W=1 kernel build warning(s):
drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct
ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead
drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct
ocs_dma_list. Protot
Fixes the following W=1 kernel build warning(s):
drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm'
not described in 'cbc_aes_nx_set_key'
drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member
'in_key' not described in 'cbc_aes_nx_set_key'
drivers
On Wed, Mar 03, 2021 at 12:26:32PM +0200, Horia Geantă wrote:
> Adding some people in the loop, maybe they could help in understanding
> why lack of "dma-coherent" property for a HW-coherent device could lead to
> unexpected / strange side effects.
>
> On 3/1/2021 5:22 PM, Sascha Hauer wrote:
> >
Fixes the following W=1 kernel build warning(s):
drivers/crypto/cavium/nitrox/nitrox_isr.c:17: warning: expecting prototype for
One vector for each type of ring(). Prototype was for NR_RING_VECTORS() instead
drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or
member '
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This is set 1 of 2 sets required to fully clean Crypto.
No functional changes since v1.
Lee Jones (10):
crypto: hisilicon: sec_drv: Supply missi
Fixes the following W=1 kernel build warning(s):
drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a
given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead
drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member
'xts_key_fallbac
The ones remove here not only fail to conform to kernel-doc, but also
provide no value, so let's remove them completely in this case.
Fixes the following W=1 kernel build warning(s):
drivers/crypto/ux500/hash/hash_core.c:368: warning: Function parameter or
member 'ctx' not described in 'hash_ge
Fixes the following W=1 kernel build warning(s):
drivers/crypto/bcm/util.c:136: warning: Function parameter or member
'from_nents' not described in 'spu_msg_sg_add'
drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'length'
not described in 'spu_msg_sg_add'
drivers/crypto/b
Fixes the following W=1 kernel build warning(s):
drivers/crypto/hisilicon/sec/sec_drv.c:843: warning: Function parameter or
member 'queue' not described in 'sec_queue_empty'
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: Zaibo Xu
Cc: Jonathan Cameron
Cc: linux-crypto@vger.kernel.org
Signed-off-by
Fixes the following W=1 kernel build warning(s):
drivers/crypto/chelsio/chcr_core.c:2: warning: wrong kernel-doc identifier on
line:
drivers/crypto/chelsio/chcr_algo.c:806: warning: Function parameter or member
'wrparam' not described in 'create_cipher_wr'
drivers/crypto/chelsio/chcr_algo.c:8
Hi Philipp,
> El 3 mar 2021, a las 14:52, Philipp Zabel escribió:
>
> Hi Álvaro,
>
> On Wed, 2021-02-24 at 09:22 +0100, Álvaro Fernández Rojas wrote:
> [...]
>> @@ -115,6 +121,8 @@ static void bcm2835_rng_cleanup(struct hwrng *rng)
>> /* disable rng hardware */
>> rng_writel(priv, 0,
On 3/3/2021 2:07 PM, Robin Murphy wrote:
> On 2021-03-03 10:26, Horia Geantă wrote:
>> Adding some people in the loop, maybe they could help in understanding
>> why lack of "dma-coherent" property for a HW-coherent device could lead to
>> unexpected / strange side effects.
>>
>> On 3/1/2021 5:22 PM
On 3/3/2021 4:35 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a
> given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead
> drivers/crypto/caam/caamalg_qi2.c:87: warning
On 2021-03-03 10:26, Horia Geantă wrote:
Adding some people in the loop, maybe they could help in understanding
why lack of "dma-coherent" property for a HW-coherent device could lead to
unexpected / strange side effects.
On 3/1/2021 5:22 PM, Sascha Hauer wrote:
Hi All,
I am on a Layerscape LS
On 3/3/21 6:06 AM, Álvaro Fernández Rojas wrote:
> Hi Philipp,
>
>> El 3 mar 2021, a las 14:52, Philipp Zabel escribió:
>>
>> Hi Álvaro,
>>
>> On Wed, 2021-02-24 at 09:22 +0100, Álvaro Fernández Rojas wrote:
>> [...]
>>> @@ -115,6 +121,8 @@ static void bcm2835_rng_cleanup(struct hwrng *rng)
>>>
On 3/3/2021 4:57 PM, Sascha Hauer wrote:
> On Wed, Mar 03, 2021 at 12:26:32PM +0200, Horia Geantă wrote:
>> Adding some people in the loop, maybe they could help in understanding
>> why lack of "dma-coherent" property for a HW-coherent device could lead to
>> unexpected / strange side effects.
>>
>
From: Tom Lendacky
If SEV has been disabled (e.g. through BIOS), the driver probe will still
issue SEV firmware commands. The SEV INIT firmware command will return an
error in this situation, but the error code is a general error code that
doesn't highlight the exact reason.
Add a check for X86_
On Wed, Mar 03, 2021 at 04:09:23PM +0800, Vic Wu wrote:
> The crypto mediatek driver has been replaced by the inside-secure driver now.
> Remove DT bindings documentation and update crypto engine nodes to the
> mt7623.dtsi files.
>
> Signed-off-by: Vic Wu
> Acked-by: Ryder Lee
> ---
> Document
Hi Álvaro,
On Wed, 2021-02-24 at 09:22 +0100, Álvaro Fernández Rojas wrote:
[...]
> @@ -115,6 +121,8 @@ static void bcm2835_rng_cleanup(struct hwrng *rng)
> /* disable rng hardware */
> rng_writel(priv, 0, RNG_CTRL);
>
> + reset_control_rearm(priv->reset);
> +
> if (!IS_ERR
Adding some people in the loop, maybe they could help in understanding
why lack of "dma-coherent" property for a HW-coherent device could lead to
unexpected / strange side effects.
On 3/1/2021 5:22 PM, Sascha Hauer wrote:
> Hi All,
>
> I am on a Layerscape LS1046a using Linux-5.11. The CAAM drive
Tianjia,
can you say whether SM2 support works for you before and after
applying this patch? I cannot verify it with an sm2 key I have created
using a sequence of commands like this:
> modprobe sm2_generic
> id=$(keyctl newring test @u)
> keyctl padd asymmetric "" $id < sm2.der
add_key: Ke
Hi Herbert,
在 2021/3/3 16:59, Herbert Xu 写道:
On Tue, Feb 09, 2021 at 02:59:23PM +0800, chenxiang wrote:
From: Xiang Chen
For function dma_unmap_sg(), the parameter should be number of
elements in the scatterlist prior to the mapping, not after the mapping.
So fix this usage.
Signed-off-by:
On Thu, Mar 04, 2021 at 10:18:51AM +0800, chenxiang (M) wrote:
>
> Thank you for reminding me about this. I didn't notice that it changes the
> count passed to create_sg_component.
> I have a change on this patch as follows, and please have a check on it:
Yes this looks fine.
Thanks,
--
Email: H
syzbot has found a reproducer for the following issue on:
HEAD commit:d310ec03 Merge tag 'perf-core-2021-02-17' of git://git.ker..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=13e7a292d0
kernel config: https://syzkaller.appspot.com/x/.config?x=2b83073
On Mon, Feb 22, 2021 at 04:12:13PM +0100, Romain Perier wrote:
>
> diff --git a/crypto/lrw.c b/crypto/lrw.c
> index bcf09fbc750a..4d35f4439012 100644
> --- a/crypto/lrw.c
> +++ b/crypto/lrw.c
> @@ -357,10 +357,10 @@ static int lrw_create(struct crypto_template *tmpl,
> struct rtattr **tb)
>
On Sat, Feb 20, 2021 at 05:51:22PM +0800, liulongfang wrote:
.
> Since patch3 is an unnecessary patch,
> can you just remove it and merge patch1 and patch2?
Please repost.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/p
On Thu, Feb 25, 2021 at 11:07:59AM -0500, Stefan Berger wrote:
> From: Saulo Alessandre
>
> * crypto/ecc_curve_defs.h
> - add nist_p384 params
>
> * include/crypto/ecdh.h
> - add ECC_CURVE_NIST_P384
>
> Signed-off-by: Saulo Alessandre
> Tested-by: Stefan Berger
> ---
> crypto/ecc_curve_d
On Thu, Feb 25, 2021 at 01:27:09PM -0500, Thara Gopinath wrote:
> Enable support for AEAD algorithms in Qualcomm CE driver. The first three
> patches in this series are cleanups and add a few missing pieces required
> to add support for AEAD algorithms. Patch 4 introduces supported AEAD
> transfo
On 2021/3/4 12:41, Herbert Xu wrote:
> On Sat, Feb 20, 2021 at 05:51:22PM +0800, liulongfang wrote:
> .
>> Since patch3 is an unnecessary patch,
>> can you just remove it and merge patch1 and patch2?
>
> Please repost.
>
> Thanks,
>
Ok.
Thanks,
Longfang
1. Fix a problems.
2. Fix some coding style.
Changes v2 -> v3:
- Delete shash test error patch.
Changes v1 -> v2:
- Modify the way to fix shash test error.
Longfang Liu (2):
crypto: hisilicon/sec - fixes some log printing style
crypto: hisilicon/sec - fixes some driver coding style
dri
1. Fix a problem of error log printing
2. Modify error log printing style
Signed-off-by: Longfang Liu
---
drivers/crypto/hisilicon/sec2/sec.h| 5 +-
drivers/crypto/hisilicon/sec2/sec_crypto.c | 82 +++---
drivers/crypto/hisilicon/sec2/sec_crypto.h | 2 -
3 files
cleanup static check errors for SEC
Signed-off-by: Longfang Liu
---
drivers/crypto/hisilicon/sec2/sec_main.c | 131 ++-
1 file changed, 76 insertions(+), 55 deletions(-)
diff --git a/drivers/crypto/hisilicon/sec2/sec_main.c
b/drivers/crypto/hisilicon/sec2/sec_main.c
On Mon, Feb 08, 2021 at 03:12:20PM +0530, Allen Pais wrote:
> From: Allen Pais
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> S
On Tue, Feb 09, 2021 at 09:35:34AM +0800, Tian Tao wrote:
> Use device-managed registration, so we can delete the ba431_trng_remove.
>
> Signed-off-by: Tian Tao
> ---
> drivers/char/hw_random/ba431-rng.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
Patch applied. Thanks
On Mon, Feb 08, 2021 at 05:10:38PM +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./arch/powerpc/crypto/sha1-spe-glue.c:110:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
> ---
> arch/powerpc/crypto/sha1-spe-glue.c | 2 +-
> 1 file changed,
A new generation of accelerator Kunpeng930 has appeared, and the
corresponding driver needs to be updated to support some new
algorithms of Kunpeng930. To be compatible with Kunpeng920, we
add parameter 'struct hisi_qm *qm' to sec_algs_(un)register to
identify the chip's version.
Signed-off-by: Me
1. crypto and crypto/atmel-ecc:
Move curve id of ECDH from the key into the algorithm name instead
in crypto and atmel-ecc, so ECDH algorithm name change form 'ecdh'
to 'ecdh-nist-pxxx', and we cannot use 'curve_id' in 'struct ecdh';
2. crypto/testmgr and net/bluetooth:
Modify 'testmgr.
Eric Biggers wrote:
> From: Eric Biggers
>
> Neither crypto_unregister_shashes() nor the module_exit function return
> a value, so the explicit 'return' is unnecessary.
>
> Signed-off-by: Eric Biggers
> ---
> arch/arm/crypto/blake2b-neon-glue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 del
1. Add curve 25519 parameters in 'crypto/ecc_curve_defs.h';
2. Add curve25519 interface 'ecc_get_curve25519_param' in
'include/crypto/ecc_curve.h', to make its parameters be
exposed to everyone in kernel tree.
Signed-off-by: Meng Yu
Reviewed-by: Zaibo Xu
---
crypto/ecc.c |
1. Enable 'ECDH' algorithm in Kunpeng 930;
2. HPRE ECDH Support: ecdh-nist-p192, ecdh-nist-p256.
Signed-off-by: Meng Yu
Reviewed-by: Zaibo Xu
---
drivers/crypto/hisilicon/hpre/hpre.h| 2 +-
drivers/crypto/hisilicon/hpre/hpre_crypto.c | 515 +++-
drivers/crypto/
Move 'ecc_get_curve' to 'include/crypto/ecc_curve.h', so everyone
in kernel tree can easily get ecc curve params;
Signed-off-by: Meng Yu
Reviewed-by: Zaibo Xu
---
crypto/ecc.c | 5 -
crypto/ecc.h | 37 ++--
include/crypto/ecc_curve.h
Enable 'CURVE25519' algorithm in Kunpeng 930.
Signed-off-by: Meng Yu
Reviewed-by: Zaibo Xu
Reported-by: kernel test robot
---
drivers/crypto/hisilicon/Kconfig| 1 +
drivers/crypto/hisilicon/hpre/hpre.h| 2 +
drivers/crypto/hisilicon/hpre/hpre_crypto.c | 366
Algorithm type is brought in to get hardware HPRE queue
to support different algorithms.
Signed-off-by: Meng Yu
Reviewed-by: Zaibo Xu
---
drivers/crypto/hisilicon/hpre/hpre.h| 10 +-
drivers/crypto/hisilicon/hpre/hpre_crypto.c | 12 ++--
drivers/crypto/hisilicon/hpre/hpr
1. Move curve ID from the key into the algorithm name (like 'ecdh-nist-pxxx'
so we get its tfm like 'crypto_alloc_kpp("ecdh-nist-p256", 0, 0)'),
in 'crypto/ecc.c' (has been verified by testmgr) and 'crypto/atmel-ecc.c'
(only compiled, not do test), and modify 'testmgr.c' and
'net/bluetoo
On Tue, Feb 09, 2021 at 04:03:37PM +0800, Tian Tao wrote:
> Use devm_platform_ioremap_resource() to simplify the code.
>
> Signed-off-by: Tian Tao
> ---
> drivers/char/hw_random/xiphera-trng.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert
On Tue, Feb 09, 2021 at 10:28:55AM +, Giovanni Cabiddu wrote:
> From: Bhaskar Chowdhury
>
> Trivial fix to spelling mistake in adf_pf2vf_msg.c and adf_vf2pf_msg.c.
> s/messge/message/
>
> Signed-off-by: Bhaskar Chowdhury
> Signed-off-by: Giovanni Cabiddu
> ---
> drivers/crypto/qat/qat_com
On Wed, Feb 10, 2021 at 11:16:37AM +0800, Tang Bin wrote:
> The function meson_crypto_probe() is only called with an openfirmware
> platform device. Therefore there is no need to check that the passed
> in device is NULL.
>
> Signed-off-by: Tang Bin
> ---
> drivers/crypto/amlogic/amlogic-gxl-cor
On Wed, Feb 10, 2021 at 07:43:50AM +, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 472b0cd3 ("crypto: keembay - Add Keem Bay OCS HCU driver")
> Reported-by: Hulk Robot
> Signed-of
On Wed, Feb 10, 2021 at 07:45:27AM +, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4")
> Reported-by: Hulk Robot
>
On Thu, Feb 11, 2021 at 03:01:17PM -0500, Thara Gopinath wrote:
> This patch series is a result of running kernel crypto fuzz tests (by
> enabling CONFIG_CRYPTO_MANAGER_EXTRA_TESTS) on the transformations
> currently supported via the Qualcomm crypto engine on sdm845. The first
> nine patches are
On Fri, Feb 12, 2021 at 09:46:10AM +0100, Corentin Labbe wrote:
> This patch fixes a memory leak on an error path.
>
> Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
> Reported-by: kernel test robot
> Reported-by: Dan Carpenter
> Signed-off-by: Corentin Labbe
> ---
> driver
On Fri, Feb 12, 2021 at 05:35:26PM +0100, Krzysztof Kozlowski wrote:
> The driver for Slim Security Subsystem (SlimSSS) on Exynos5433 takes two
> clocks - aclk (AXI/AHB clock) and pclk (APB/Advanced Peripheral Bus
> clock). The "aclk", as main high speed bus clock, is enabled first. Then
> the "p
On Tue, Feb 23, 2021 at 11:42:04AM +0800, Kai Ye wrote:
> Delete sg_data function, because sg_data function definition same as
> sg_virt(), so need to delete it and use sg_virt() replace to sg_data().
>
> Signed-off-by: Kai Ye
> ---
> crypto/testmgr.c | 11 +++
> 1 file changed, 3 insert
On Fri, Feb 26, 2021 at 09:23:06AM +0800, Yang Li wrote:
> In one of the error paths of the for_each_child_of_node() loop,
> add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function
> "for_each_child_of_node"
On Fri, Feb 19, 2021 at 07:19:18PM +0800, Tian Tao wrote:
> This commit fixes the checkpatch warning:
> WARNING: Use #include instead of
> drivers/char/hw_random/omap-rng.c:34
>
> Signed-off-by: Tian Tao
> ---
> drivers/char/hw_random/omap-rng.c | 3 +--
> 1 file changed, 1 insertion(+), 2 del
Some devices may need to perform a reset before using the RNG, such as the
BCM6368.
Signed-off-by: Álvaro Fernández Rojas
---
v5: no changes.
v4: pass dt_binding_check.
v3: make resets required if brcm,bcm6368-rng.
v2: document reset support.
.../devicetree/bindings/rng/brcm,bcm2835.yaml
BCM6368 devices need to reset the in order to generate true random numbers.
This is what BCM6368 produces without a reset:
root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000
rngtest 6.10
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions. T
v5: remove reset_control_rearm() and apply on latest herbert/cryptodev-2.6.git.
v4: fix documentation, add reset_control_rearm().
v3: make resets required if brcm,bcm6368-rng.
v2: document reset support.
Álvaro Fernández Rojas (2):
dt-bindings: rng: bcm2835: document reset support
hwrng: bcm28
65 matches
Mail list logo
