Re: [PATCH v7 3/4] x509: Add support for parsing x509 certs with ECDSA keys

2021-02-11 Thread kernel test robot
Hi Stefan, Thank you for the patch! Yet something to improve: [auto build test ERROR on cryptodev/master] [also build test ERROR on crypto/master security/next-testing v5.11-rc7 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we s

Re: [PATCH -next] crypto: keembay-ocs-aes - Fix error return code in kmb_ocs_aes_probe()

2021-02-11 Thread Alessandrelli, Daniele
Hi Wei, Thanks for this fix as well :) On Wed, 2021-02-10 at 07:45 +, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS > AES

Re: [PATCH -next] crypto: keembay-ocs-hcu - Fix error return code in kmb_ocs_hcu_probe()

2021-02-11 Thread Alessandrelli, Daniele
Hi Wei, Thanks for the fix. On Wed, 2021-02-10 at 07:43 +, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 472b0cd3 ("crypto: keembay - Add Keem Bay OCS HCU driver") > Reported-by:

[net-next v6 00/14] Add Marvell CN10K support

2021-02-11 Thread Geetha sowjanya
The current admin function (AF) driver and the netdev driver supports OcteonTx2 silicon variants. The same OcteonTx2's Resource Virtualization Unit (RVU) is carried forward to the next-gen silicon ie OcteonTx3, with some changes and feature enhancements. This patch set adds support for OcteonTx3 (

[net-next v6 03/14] octeontx2-af: cn10k: Update NIX/NPA context structure

2021-02-11 Thread Geetha sowjanya
NIX hardware context structure got changed to accommodate new features like bandwidth steering, L3/L4 outer/inner checksum enable/disable etc., on CN10K platform. This patch defines new mbox message NIX_CN10K_AQ_INST for new NIX context initialization. This patch also updates the NPA context struc

[net-next v6 02/14] octeontx2-pf: cn10k: Add mbox support for CN10K

2021-02-11 Thread Geetha sowjanya
From: Subbaraya Sundeep Firmware allocates memory regions for PFs and VFs in DRAM. The PFs memory region is used for AF-PF and PF-VF mailbox. This mbox facilitate communication between AF-PF and PF-VF. On CN10K platform: The DRAM region allocated to PF is enumerated as PF BAR4 memory. PF BAR4 co

[net-next v6 04/14] octeontx2-af: cn10k: Update NIX and NPA context in debugfs

2021-02-11 Thread Geetha sowjanya
On CN10K platform NPA and NIX context structure bit fields had changed to support new features like bandwidth steering etc. This patch dumps approprate context for CN10K platform. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham --- .../marvell/octeontx2/af/rvu_debugfs.c| 177

[net-next v6 01/14] octeontx2-af: cn10k: Add mbox support for CN10K platform

2021-02-11 Thread Geetha sowjanya
From: Subbaraya Sundeep Firmware allocates memory regions for PFs and VFs in DRAM. The PFs memory region is used for AF-PF and PF-VF mailbox. This mbox facilitates communication between AF-PF and PF-VF. On CN10K platform: The DRAM region allocated to PF is enumerated as PF BAR4 memory. PF BAR4 c

[net-next v6 05/14] octeontx2-pf: cn10k: Initialise NIX context

2021-02-11 Thread Geetha sowjanya
On CN10K platform NIX RQ and SQ context structure got changed. This patch uses new mbox message "NIX_CN10K_AQ_ENQ" for NIX context initialization on CN10K platform. This patch also updates the nix_rx_parse_s and nix_sqe_sg_s structures to add packet steering bit feilds. Signed-off-by: Geetha sowj

[net-next v6 07/14] octeontx2-pf: cn10k: Use LMTST lines for NPA/NIX operations

2021-02-11 Thread Geetha sowjanya
This patch adds support to use new LMTST lines for NPA batch free and burst SQE flush. Adds new dev_hw_ops structure to hold platform specific functions and create new files cn10k.c and cn10k.h. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham --- .../ethernet/marvell/octeontx2/nic/M

[net-next v6 06/14] octeontx2-pf: cn10k: Map LMTST region

2021-02-11 Thread Geetha sowjanya
On CN10K platform transmit/receive buffer alloc and free from/to hardware had changed to support burst operation. Whereas pervious silicon's only support single buffer free at a time. To Support the same firmware allocates a DRAM region for each PF/VF for storing LMTLINES. These LMTLINES are used f

[net-next v6 09/14] octeontx2-af: cn10k: Add support for programmable channels

2021-02-11 Thread Geetha sowjanya
From: Subbaraya Sundeep NIX uses unique channel numbers to identify the packet sources/sinks like CGX,LBK and SDP. The channel numbers assigned to each block are hardwired in CN9xxx silicon. The fixed channel numbers in CN9xxx are: 0x0 | a << 8 | b- LBK(0..3)_CH(0..63) 0x0 | a << 8

[net-next v6 08/14] octeontx2-af: cn10k: Add RPM MAC support

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam OcteonTx2's next gen platform the CN10K has RPM MAC which has a different serdes when compared to CGX MAC. Though the underlying HW is different, the CSR interface has been designed largely inline with CGX MAC, with few exceptions though. So we are using the same CGX driver

[net-next v6 10/14] octeontx2-af: cn10K: Add MTU configuration

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam OcteonTx3 CN10K silicon supports bigger MTU when compared to 9216 MTU supported by OcteonTx2 silicon variants. Lookback interface supports upto 64K and RPM LMAC interfaces support upto 16K. This patch does the necessary configuration and adds support for PF/VF drivers to r

[net-next v6 12/14] octeontx2-af: cn10k: Add RPM LMAC pause frame support

2021-02-11 Thread Geetha sowjanya
From: Rakesh Babu Flow control configuration is different for CGX(Octeontx2) and RPM(CN10K) functional blocks. This patch adds the necessary changes for RPM to support 802.3 pause frames configuration on cn10k platforms. Signed-off-by: Rakesh Babu Signed-off-by: Geetha sowjanya Signed-off-by:

[net-next v6 14/14] octeontx2-af: cn10k: MAC internal loopback support

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam MAC on CN10K silicon support loopback for selftest or debug purposes. This patch does necessary configuration to loopback packets upon receiving request from LMAC mapped RVU PF's netdev via mailbox. Also MAC (CGX) on OcteonTx2 silicon variants and MAC (RPM) on OcteonTx3 CN

[net-next v6 13/14] octeontx2-af: cn10k: Add RPM Rx/Tx stats support

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam RPM supports below list of counters as an extension to existing counters * class based flow control pause frames * vlan/jabber/fragmented packets * fcs/alignment/oversized error packets This patch adds support to display supported RPM counters via debugfs and define

[net-next v6 11/14] octeontx2-pf: cn10k: Get max mtu supported from admin function

2021-02-11 Thread Geetha sowjanya
From: Hariprasad Kelam CN10K supports max MTU of 16K on LMAC links and 64k on LBK links and Octeontx2 silicon supports 9K mtu on both links. Get the same from nix_get_hw_info mbox message in netdev probe. This patch also calculates receive buffer size required based on the MTU set. Signed-off-b

Re: [PATCH v7 3/4] x509: Add support for parsing x509 certs with ECDSA keys

2021-02-11 Thread Stefan Berger
On 2/11/21 3:03 AM, kernel test robot wrote: Hi Stefan, Thank you for the patch! Yet something to improve: crypto/asymmetric_keys/public_key.c:97: undefined reference to `parse_OID' So the issue is that  only ASYMMETRIC_PUBLIC_KEY_SUBTYPE is selected in this config and the selection of OID

Re: [PATCH v7 3/4] x509: Add support for parsing x509 certs with ECDSA keys

2021-02-11 Thread Stefan Berger
On 2/11/21 12:30 PM, Stefan Berger wrote: On 2/11/21 3:03 AM, kernel test robot wrote: Hi Stefan, Thank you for the patch! Yet something to improve: crypto/asymmetric_keys/public_key.c:97: undefined reference to `parse_OID' So the issue is that  only ASYMMETRIC_PUBLIC_KEY_SUBTYPE is select

Re: [net-next v6 14/14] octeontx2-af: cn10k: MAC internal loopback support

2021-02-11 Thread kernel test robot
Hi Geetha, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Geetha-sowjanya/Add-Marvell-CN10K-support/20210212-001410 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e

[PATCH v7 00/11] Regression fixes/clean ups in the Qualcomm crypto engine driver

2021-02-11 Thread Thara Gopinath
This patch series is a result of running kernel crypto fuzz tests (by enabling CONFIG_CRYPTO_MANAGER_EXTRA_TESTS) on the transformations currently supported via the Qualcomm crypto engine on sdm845. The first nine patches are fixes for various regressions found during testing. The last two patches

[PATCH v7 01/11] crypto: qce: sha: Restore/save ahash state with custom struct in export/import

2021-02-11 Thread Thara Gopinath
Export and import interfaces save and restore partial transformation states. The partial states were being stored and restored in struct sha1_state for sha1/hmac(sha1) transformations and sha256_state for sha256/hmac(sha256) transformations.This led to a bunch of corner cases where improper state w

[PATCH v7 02/11] crypto: qce: sha: Hold back a block of data to be transferred as part of final

2021-02-11 Thread Thara Gopinath
If the available data to transfer is exactly a multiple of block size, save the last block to be transferred in qce_ahash_final (with the last block bit set) if this is indeed the end of data stream. If not this saved block will be transferred as part of next update. If this block is not held back

[PATCH v7 03/11] crypto: qce: skcipher: Return unsupported if key1 and key 2 are same for AES XTS algorithm

2021-02-11 Thread Thara Gopinath
Crypto engine does not support key1 = key2 for AES XTS algorithm; the operation hangs the engines. Return -EINVAL in case key1 and key2 are the same. Signed-off-by: Thara Gopinath --- drivers/crypto/qce/skcipher.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff -

[PATCH v7 04/11] crypto: qce: skcipher: Return unsupported if any three keys are same for DES3 algorithms

2021-02-11 Thread Thara Gopinath
Return unsupported if any three keys are same for DES3 algorithms since CE does not support this and the operation causes the engine to hang. Signed-off-by: Thara Gopinath --- v6->v7: - Fixed sparse warning in patch 4 as pointed out by Herbert Xu. This means the checking if any

[PATCH v7 06/11] crypto: qce: skcipher: Return error for non-blocksize data(ECB/CBC algorithms)

2021-02-11 Thread Thara Gopinath
ECB/CBC encryption/decryption requires the data to be blocksize aligned. Crypto engine hangs on non-block sized operations for these algorithms. Return invalid data if data size is not blocksize aligned for these algorithms. Signed-off-by: Thara Gopinath --- v5->v6: - Remove the wrong TO

[PATCH v7 05/11] crypto: qce: skcipher: Return error for zero length messages

2021-02-11 Thread Thara Gopinath
Crypto engine BAM dma does not support 0 length data. Return unsupported if zero length messages are passed for transformation. Signed-off-by: Thara Gopinath --- v5->v6: - Return 0 for zero length messages instead of -EOPNOTSUPP in the cipher algorithms as pointed out by Eric B

[PATCH v7 08/11] crypto: qce: skcipher: Improve the conditions for requesting AES fallback cipher

2021-02-11 Thread Thara Gopinath
The following are the conditions for requesting AES fallback cipher. - AES-192 - AES-XTS request with len <= 512 byte (Allow messages of length less than 512 bytes for all other AES encryption algorithms other than AES XTS) - AES-XTS request with len > Q

[PATCH v7 09/11] crypto: qce: common: Set data unit size to message length for AES XTS transformation

2021-02-11 Thread Thara Gopinath
Set the register REG_ENCR_XTS_DU_SIZE to cryptlen for AES XTS transformation. Anything else causes the engine to return back wrong results. Acked-by: Bjorn Andersson Signed-off-by: Thara Gopinath --- drivers/crypto/qce/common.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v7 07/11] crypto: qce: skcipher: Set ivsize to 0 for ecb(aes)

2021-02-11 Thread Thara Gopinath
ECB transformations do not have an IV and hence set the ivsize to 0 for ecb(aes). Signed-off-by: Thara Gopinath --- drivers/crypto/qce/skcipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index c2f0469ffb22..

[PATCH v7 11/11] crypto: qce: Remove totallen and offset in qce_start

2021-02-11 Thread Thara Gopinath
totallen is used to get the size of the data to be transformed. This is also available via nbytes or cryptlen in the qce_sha_reqctx and qce_cipher_ctx. Similarly offset convey nothing for the supported encryption and authentication transformations and is always 0. Remove these two redundant paramet

[PATCH v7 10/11] crypto: qce: Remover src_tbl from qce_cipher_reqctx

2021-02-11 Thread Thara Gopinath
src_table is unused and hence remove it from struct qce_cipher_reqctx Signed-off-by: Thara Gopinath --- drivers/crypto/qce/cipher.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/qce/cipher.h b/drivers/crypto/qce/cipher.h index cffa9fc628ff..850f257d00f3 100644 --- a/drivers/c

Re: [net-next v6 00/14] Add Marvell CN10K support

2021-02-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Feb 2021 21:28:20 +0530 you wrote: > The current admin function (AF) driver and the netdev driver supports > OcteonTx2 silicon variants. The same OcteonTx2's > Resource Virtualization Unit (RVU) is carried forwa