Hi Rob,
On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all e
On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote:
> Quoting Rob Herring (2021-02-02 12:55:42)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> >
> > b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
>
On Tue, Feb 02, 2021 at 02:55:44PM -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all
Use devm_hwrng_register to get rid of manual unregistration.
Signed-off-by: Tian Tao
---
drivers/char/hw_random/optee-rng.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/hw_random/optee-rng.c
b/drivers/char/hw_random/optee-rng.c
index a99d829..135a825 100644
On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd
> Cc: Maxime Ripard
> Cc: Chen-Yu Tsai
> Cc: Linus Walleij
>
On Tue, 2 Feb 2021 at 23:20, Eric Biggers wrote:
>
> On Mon, Feb 01, 2021 at 07:02:28PM +0100, Ard Biesheuvel wrote:
> > Some generic implementations of vintage ciphers rely on alignmasks to
> > ensure that the input is presented with the right alignment. Given that
> > these are all C implementat
Hi Rob,
On Wed, 3 Feb 2021 at 05:55, Rob Herring wrote:
> diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,ms
> -Original Message-
> From: Maciej Pijanowski
> Sent: Wednesday, February 3, 2021 11:00 AM
> To: Van Leeuwen, Pascal ; linux-crypto@vger.kernel.org
> Cc: aten...@kernel.org; pascalv...@gmail.com; Piotr Król
>
> Subject: Re: safexcel driver for EIP197 and mini firmware features
>
> <<< E
On Wed, Feb 03, 2021 at 10:37:10AM +0100, Ard Biesheuvel wrote:
>
> One thing that became apparent to me while looking into this stuff is
> that the skcipher encrypt/decrypt API ignores alignmasks altogether,
> so this is something we should probably look into at some point, i.e.,
> whether the ali
On 02-02-21, 14:55, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entries. 'contains' i
On Wed, 3 Feb 2021 at 12:19, Herbert Xu wrote:
>
> On Wed, Feb 03, 2021 at 10:37:10AM +0100, Ard Biesheuvel wrote:
> >
> > One thing that became apparent to me while looking into this stuff is
> > that the skcipher encrypt/decrypt API ignores alignmasks altogether,
> > so this is something we shou
From: Daniele Alessandrelli
The length ('len' parameter) passed to crypto_ecdh_decode_key() is never
checked against the length encoded in the passed buffer ('buf'
parameter). This could lead to an out-of-bounds access when the passed
length is less than the encoded length.
Add a check to preven
Given how kernel mode NEON code disables preemption (to ensure that the
FP/SIMD register state is protected without having to context switch it),
we need to take care not to let those algorithms operate on unbounded
input data, or we may end up with excessive scheduling blackouts on
CONFIG_PREEMPT
Instead of calling into kernel_neon_end() and kernel_neon_begin() (and
potentially into schedule()) from the assembler code when running in
task mode and a reschedule is pending, perform only the preempt count
check in assembler, but simply return early in this case, and let the C
code deal with th
Add a macro cond_yield that branches to a specified label when called if
the TIF_NEED_RESCHED flag is set and decreasing the preempt count would
make the task preemptible again, resulting in a schedule to occur. This
can be used by kernel mode SIMD code that keeps a lot of state in SIMD
registers,
Instead of calling into kernel_neon_end() and kernel_neon_begin() (and
potentially into schedule()) from the assembler code when running in
task mode and a reschedule is pending, perform only the preempt count
check in assembler, but simply return early in this case, and let the C
code deal with th
Instead of calling into kernel_neon_end() and kernel_neon_begin() (and
potentially into schedule()) from the assembler code when running in
task mode and a reschedule is pending, perform only the preempt count
check in assembler, but simply return early in this case, and let the C
code deal with th
Instead of yielding from the bowels of the asm routine if a reschedule
is needed, divide up the input into 4 KB chunks in the C glue. This
simplifies the code substantially, and avoids scheduling out the task
with the asm routine on the call stack, which is undesirable from a
CFI/instrumentation po
Signed-off-by: Ard Biesheuvel
---
arch/arm64/crypto/aes-glue.c | 21 +---
arch/arm64/crypto/aes-modes.S | 52 +++-
2 files changed, 33 insertions(+), 40 deletions(-)
diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c
index e7f116d833b9..17e735931a0c 100
> -Original Message-
> From: Maciej Pijanowski
> Sent: Tuesday, February 2, 2021 10:16 AM
> To: Van Leeuwen, Pascal ; linux-crypto@vger.kernel.org
> Cc: antoine.ten...@bootlin.com; pascalv...@gmail.com; Piotr Król
>
> Subject: Re: safexcel driver for EIP197 and mini firmware features
>
>
Instead of calling into kernel_neon_end() and kernel_neon_begin() (and
potentially into schedule()) from the assembler code when running in
task mode and a reschedule is pending, perform only the preempt count
check in assembler, but simply return early in this case, and let the C
code deal with th
The users of the conditional NEON yield macros have all been switched to
the simplified cond_yield macro, and so the NEON specific ones can be
removed.
Signed-off-by: Ard Biesheuvel
---
arch/arm64/include/asm/assembler.h | 70
1 file changed, 70 deletions(-)
diff --git a/ar
There is no need for elaborate yield handling in the bit-sliced NEON
implementation of AES, given that skciphers are naturally bounded by the
size of the chunks returned by the skcipher_walk API. So remove the
yield calls from the asm code.
Signed-off-by: Ard Biesheuvel
---
arch/arm64/crypto/aes
On Tue, 2021-02-02 at 14:55 -0600, Rob Herring wrote:
> Properties in if/then schemas weren't getting checked by the meta-schemas.
> Enabling meta-schema checks finds several errors.
>
> The use of an 'items' schema (as opposed to the list form) is wrong in
> some cases as it applies to all entrie
On Wed, 3 Feb 2021 at 14:55, Tian Tao wrote:
>
> Use devm_hwrng_register to get rid of manual unregistration.
>
> Signed-off-by: Tian Tao
> ---
> drivers/char/hw_random/optee-rng.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Fix up subject line as s/hwrng: optee -:/hwrng: optee:
Use devm_hwrng_register to get rid of manual unregistration.
Signed-off-by: Tian Tao
Reviewed-by: Sumit Garg
---
v2:Fix up subject line as s/hwrng: optee -:/hwrng: optee:/
---
drivers/char/hw_random/optee-rng.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/h
Hi Uwe,
On 1/26/21 5:58 PM, Uwe Kleine-König wrote:
> All amba drivers return 0 in their remove callback. Together with the
> driver core ignoring the return value anyhow, it doesn't make sense to
> return a value here.
>
> Change the remove prototype to return void, which makes it explicit that
On 03.02.2021 12:04, Van Leeuwen, Pascal wrote:
-Original Message-
From: Maciej Pijanowski
Sent: Wednesday, February 3, 2021 11:00 AM
To: Van Leeuwen, Pascal ; linux-crypto@vger.kernel.org
Cc: aten...@kernel.org; pascalv...@gmail.com; Piotr Król
Subject: Re: safexcel driver for EIP197
On 02.02.2021 10:15, Maciej Pijanowski wrote:
On 02.02.2021 09:48, Van Leeuwen, Pascal wrote:
Hello Maciej,
Hello,
-Original Message-
From: Maciej Pijanowski
Sent: Monday, February 1, 2021 7:53 PM
To: linux-crypto@vger.kernel.org
Cc: antoine.ten...@bootlin.com; pascalv...@gmail.c
Export and import interfaces save and restore partial transformation
states. The partial states were being stored and restored in struct
sha1_state for sha1/hmac(sha1) transformations and sha256_state for
sha256/hmac(sha256) transformations.This led to a bunch of corner cases
where improper state w
This patch series is a result of running kernel crypto fuzz tests (by
enabling CONFIG_CRYPTO_MANAGER_EXTRA_TESTS) on the transformations
currently supported via the Qualcomm crypto engine on sdm845. The first
nine patches are fixes for various regressions found during testing. The
last two patches
Crypto engine does not support key1 = key2 for AES XTS algorithm; the
operation hangs the engines. Return -EINVAL in case key1 and key2 are the
same.
Signed-off-by: Thara Gopinath
---
drivers/crypto/qce/skcipher.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff -
If the available data to transfer is exactly a multiple of block size, save
the last block to be transferred in qce_ahash_final (with the last block
bit set) if this is indeed the end of data stream. If not this saved block
will be transferred as part of next update. If this block is not held back
totallen is used to get the size of the data to be transformed.
This is also available via nbytes or cryptlen in the qce_sha_reqctx
and qce_cipher_ctx. Similarly offset convey nothing for the supported
encryption and authentication transformations and is always 0.
Remove these two redundant paramet
Return unsupported if any three keys are same for DES3 algorithms
since CE does not support this and the operation causes the engine to
hang.
Signed-off-by: Thara Gopinath
---
drivers/crypto/qce/skcipher.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/crypto/qce/sk
ECB/CBC encryption/decryption requires the data to be blocksize aligned.
Crypto engine hangs on non-block sized operations for these algorithms.
Return invalid data if data size is not blocksize aligned for these
algorithms.
Signed-off-by: Thara Gopinath
---
drivers/crypto/qce/skcipher.c | 12 ++
src_table is unused and hence remove it from struct qce_cipher_reqctx
Signed-off-by: Thara Gopinath
---
drivers/crypto/qce/cipher.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/qce/cipher.h b/drivers/crypto/qce/cipher.h
index cffa9fc628ff..850f257d00f3 100644
--- a/drivers/c
The following are the conditions for requesting AES fallback cipher.
- AES-192
- AES-XTS request with len <= 512 byte (Allow messages of length
less than 512 bytes for all other AES encryption algorithms other
than AES XTS)
- AES-XTS request with len > Q
Set the register REG_ENCR_XTS_DU_SIZE to cryptlen for AES XTS
transformation. Anything else causes the engine to return back
wrong results.
Acked-by: Bjorn Andersson
Signed-off-by: Thara Gopinath
---
drivers/crypto/qce/common.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
ECB transformations do not have an IV and hence set the ivsize to 0 for
ecb(aes).
Signed-off-by: Thara Gopinath
---
drivers/crypto/qce/skcipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c
index 28bea9584c33..
Crypto engine BAM dma does not support 0 length data. Return unsupported
if zero length messages are passed for transformation.
Signed-off-by: Thara Gopinath
---
drivers/crypto/qce/skcipher.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/
s/messge/message/
Signed-off-by: Bhaskar Chowdhury
---
drivers/crypto/qat/qat_common/adf_pf2vf_msg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_common/adf_pf2vf_msg.c
b/drivers/crypto/qat/qat_common/adf_pf2vf_msg.c
index 8b090b7ae8c6..a1b77bd7a8
s/messge/message/ ..two different lines
Signed-off-by: Bhaskar Chowdhury
---
drivers/crypto/qat/qat_common/adf_vf2pf_msg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/qat/qat_common/adf_vf2pf_msg.c
b/drivers/crypto/qat/qat_common/adf_vf2pf_msg.c
ind
s/optimzation/optimization/
Signed-off-by: Bhaskar Chowdhury
---
crypto/xor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/xor.c b/crypto/xor.c
index eacbf4f93990..c046d074f522 100644
--- a/crypto/xor.c
+++ b/crypto/xor.c
@@ -95,7 +95,7 @@ do_xor_speed(struct xor_
From: Daniele Alessandrelli
In ocs_aes_ccm_write_b0(), 'q' (the octet length of the binary
representation of the octet length of the payload) is set to 'iv[0]',
while it should be set to 'iv[0] & 0x7' (i.e., only the last 3
bits of iv[0] should be used), as documented in NIST Special Publication
Herbert,
On Tue, Feb 02, 2021 at 04:10:03PM +1100, Herbert Xu wrote:
> On Fri, Jan 29, 2021 at 06:25:35PM -0300, Saulo Alessandre wrote:
> > From: Saulo Alessandre
> >
> > * Documentation/admin-guide/module-signing.rst
> > - Documents how to generate certificate and signature for (ECDSA).
> >
On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> Hi Rob,
>
> On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote:
> > Properties in if/then schemas weren't getting checked by the meta-schemas.
> > Enabling meta-schema checks finds several errors.
> >
> > The use of an 'items' sc
Hi Rob,
On Wed, Feb 3, 2021 at 4:55 PM Rob Herring wrote:
> On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote:
> > > Properties in if/then schemas weren't getting checked by the meta-schemas.
> > > Enabling meta-schema checks
On 2/3/21 7:39 AM, Bhaskar Chowdhury wrote:
>
> s/optimzation/optimization/
>
> Signed-off-by: Bhaskar Chowdhury
Acked-by: Randy Dunlap
Thanks.
> ---
> crypto/xor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/xor.c b/crypto/xor.c
> index eacbf4f93990..c0
On 2/3/21 7:01 AM, Bhaskar Chowdhury wrote:
>
> s/messge/message/ ..two different lines
>
> Signed-off-by: Bhaskar Chowdhury
Acked-by: Randy Dunlap
Thanks.
> ---
> drivers/crypto/qat/qat_common/adf_vf2pf_msg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dr
On 28/01/2021 02:03, Herbert Xu wrote:
> On Fri, Jan 22, 2021 at 03:09:52PM +0800, Meng Yu wrote:
>> 1. Add ecc curves(P224, P384, P521) for ECDH;
>
> OK I think this is getting unwieldy.
>
> In light of the fact that we already have hardware that supports
> a specific subset of curves, I think per
submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thara-Gopinath/Regression-fixes-clean-ups-in-the-Qualcomm-crypto-engine-driver/20210203-224305
base:
https://git.kernel.org/pub/scm/linux/
On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote:
> Quoting Rob Herring (2021-02-02 12:55:42)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> >
> > b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
>
On Wed, 3 Feb 2021 12:36:17 +0100, Ard Biesheuvel wrote:
> Given how kernel mode NEON code disables preemption (to ensure that the
> FP/SIMD register state is protected without having to context switch it),
> we need to take care not to let those algorithms operate on unbounded
> input data, or we
Hi Rob,
> From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM
>
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd
> Cc: Maxime Ripard
> Cc: Chen-Yu Tsai
Hi Rob,
> From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM
>
> Fixing the compatible string typos results in an error in the example:
>
> Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.example.dt.yaml:
> iommu@fe951000: 'power-domains' is a required property
>
> Based
On Thu, Feb 04, 2021 at 04:56:17AM +0800, kernel test robot wrote:
>
> Thank you for the patch! Yet something to improve:
Please fix this before you resubmit again.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.
On Wed, Feb 03, 2021 at 09:31:31PM +, Will Deacon wrote:
>
> Applied first patch only to arm64 (for-next/crypto), thanks!
>
> [1/9] arm64: assembler: add cond_yield macro
> https://git.kernel.org/arm64/c/d13c613f136c
>
> This is the only patch on the branch, so I'm happy for it to be pu
On Mon, Feb 01, 2021 at 10:19:07AM -0500, Stefan Berger wrote:
> Add support for parsing the parameters of a NIST P256 or NIST P192 key.
> Enable signature verification using these keys. The new module is
> enabled with CONFIG_ECDSA:
> Elliptic Curve Digital Signature Algorithm (NIST P192, P256 e
On Tue, Feb 02, 2021 at 12:35:26PM +, Alessandrelli, Daniele wrote:
>
> Unrelated question: I have my Keem Bay OCS ECC patchset [1] almost
> ready for re-submission. Should I go ahead or should I wait for the
> final decision about using 'ecdh-nist-pXXX' in place of 'ecdh'?
If we agree on goin
On Wed, Feb 03, 2021 at 03:03:44PM -0300, Saulo Alessandre wrote:
>
> In this patch I'm using akcipher allocate like ecdsa(sha1,sha256,...),
> because the ecdsa algo is generic, and using the curve name and ndigits
> inside vli_mmod_fast to discover the curve, but I agree the correct way
> would b
On Wed, Feb 03, 2021 at 06:34:06PM +0300, Vitaly Chikunov wrote:
>
> Thanks for the invitation, I'm didn't receive this thread - is
> there a temporary problem with the linux-crypto@vger.kernel.org list?
> I re-checked my subscription and it seems valid.
There was a problem between vger and gmail
On 2/4/21 12:27 AM, Herbert Xu wrote:
On Mon, Feb 01, 2021 at 10:19:07AM -0500, Stefan Berger wrote:
Add support for parsing the parameters of a NIST P256 or NIST P192 key.
Enable signature verification using these keys. The new module is
enabled with CONFIG_ECDSA:
Elliptic Curve Digital Sign
Remove casting the values returned by dma_alloc_coherent.
Signed-off-by: Xu Wang
---
drivers/crypto/cavium/cpt/cptvf_main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/cavium/cpt/cptvf_main.c
b/drivers/crypto/cavium/cpt/cptvf_main.c
index f016448e4
Fix the following coccicheck warning:
./drivers/crypto/picoxcell_crypto.c:1201:8-16: WARNING: use scnprintf
or sprintf.
Reported-by: Abaci Robot
Signed-off-by: Jiapeng Chong
---
drivers/crypto/picoxcell_crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto
65 matches
Mail list logo
