Re: [PATCH v3 0/4] crypto: switch to crypto API for EBOIV generation

2020-12-02 Thread Gilad Ben-Yossef
Hi, On Thu, Oct 29, 2020 at 12:05 PM Gilad Ben-Yossef wrote: > > > This series creates an EBOIV template that produces a skcipher > transform which passes through all operations to the skcipher, while > using the same skcipher and key to encrypt the input IV, which is > assumed to be a sector off

Re: [PATCH v2] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-12-02 Thread Lukasz Stelmach
It was <2020-11-30 pon 21:01>, when Qinglang Miao wrote: > pm_runtime_get_sync will increment pm usage counter even > failed. Forgetting to putting operation will result in a > reference leak here. > > Replace it with pm_runtime_resume_and_get to keep usage > counter balanced. I remove err_clock la

Re: Null pointer dereference in public key verification (related to SM2 introduction)

2020-12-02 Thread Tobias Markus
Hi David, I'm afraid I can't provide an exactly matching disassembly of the function since I've since updated to newer -rc kernels. Another debugging hurdle is that the specific kernel code path seems to be triggered by a very specific iwd code path that iwd only uses for 802.1X/EAP-secured net

Re: [PATCH] random: Don't freeze in add_hwgenerator_randomness() if stopping kthread

2020-12-02 Thread Horia Geantă
On 11/17/2019 2:57 AM, Herbert Xu wrote: > On Sun, Nov 17, 2019 at 12:01:20AM +0100, Maciej S. Szmigiero wrote: >> >> If a reader (user space) task is frozen then it is no longer waiting >> on this waitqueue - at least if I understand correctly how the freezer >> works for user space tasks, that is

Re: [PATCH v1 0/9] Enable root to update the blacklist keyring

2020-12-02 Thread Jarkko Sakkinen
On Mon, Nov 30, 2020 at 09:23:59AM +0100, Mickaël Salaün wrote: > > On 30/11/2020 03:40, Jarkko Sakkinen wrote: > > On Fri, Nov 20, 2020 at 07:04:17PM +0100, Mickaël Salaün wrote: > >> Hi, > >> > >> This patch series mainly add a new configuration option to enable the > >> root user to load signed

Re: crypto: sun4i-ss: error with kmap

2020-12-02 Thread Corentin Labbe
On Tue, Dec 01, 2020 at 04:15:08PM +0100, Thomas Gleixner wrote: > On Tue, Dec 01 2020 at 15:45, Corentin Labbe wrote: > > On Tue, Dec 01, 2020 at 03:16:36PM +0100, Thomas Gleixner wrote: > > In fact the warn was a bit later so I added: > >preempt_disable(); > > idx = arch_kmap_loca

[PATCH v6 2/3] lib: zstd: Add decompress_sources.h for decompress_unzstd

2020-12-02 Thread Nick Terrell
From: Nick Terrell Adds decompress_sources.h which includes every .c file necessary for zstd decompression. This is used in decompress_unzstd.c so the internal structure of the library isn't exposed. This allows us to upgrade the zstd library version without modifying any callers. Instead we jus

[PATCH v6 0/3] Update to zstd-1.4.6

2020-12-02 Thread Nick Terrell
From: Nick Terrell Please pull from g...@github.com:terrelln/linux.git tags/zstd-1.4.6-v6 to get these changes. Alternatively the patchset is included. This patchset upgrades the zstd library to the latest upstream release. The current zstd version in the kernel is a modified version of upst

Re: crypto: sun4i-ss: error with kmap

2020-12-02 Thread Thomas Gleixner
On Wed, Dec 02 2020 at 20:55, Corentin Labbe wrote: > On Tue, Dec 01, 2020 at 04:15:08PM +0100, Thomas Gleixner wrote: > > The result could be seen at http://kernel.montjoie.ovh/129768.log > The log is 9Mb, but the ftrace dump seems not terminated, tell me if you need > more. Correct, the interes

Re: [PATCH v6 3/3] lib: zstd: Upgrade to latest upstream zstd version 1.4.6

2020-12-02 Thread kernel test robot
Hi Nick, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on kdave/for-next f2fs/dev-test kees/for-next/pstore linus/master v5.10-rc6] [cannot apply to crypto/master squashfs/master next-20201201] [If your patch is appl

Re: [PATCH] random: Don't freeze in add_hwgenerator_randomness() if stopping kthread

2020-12-02 Thread Herbert Xu
On Wed, Dec 02, 2020 at 04:28:07PM +0200, Horia Geantă wrote: > > I wasn't able to find a follow-up on this topic. > Could you advise on what's the proper thing to do going forward? I think someone needs to come up with a patch that does not cause regressions. Cheers, -- Email: Herbert Xu Home

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: > From: Nick Terrell > > This patch: > - Moves `include/linux/zstd.h` -> `lib/zstd/zstd.h` > - Adds a new API in `include/linux/zstd.h` that is functionally > equivalent to the in-use subset of the current API. Functions are > rena

[PATCH 0/5] crypto: caam - avoid allocating memory at crypto request runtime

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan This series removes CRYPTO_ALG_ALLOCATES_MEMORY flag and allocates the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is added to the reqsize field

[PATCH 1/5] crypto: caam/jr - avoid allocating memory at crypto request runtime for skcipher

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor and hw descriptor commands, link tables, IV is computed in frontend driver (caamalg)

[PATCH 2/5] crypto: caam/jr - avoid allocating memory at crypto request runtime for aead

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is computed in frontend driver (caamalg) ini

[PATCH 3/5] crypto: caam/jr - avoid allocating memory at crypto request runtime fost hash

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor and link tables is computed in frontend driver (caamhash) initialization and saved i

[PATCH 4/5] crypto: caam/qi - avoid allocating memory at crypto request runtime

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is computed in frontend driver (caamalg_qi)

[PATCH 5/5] crypto: caam/qi2 - avoid allocating memory at crypto request runtime

2020-12-02 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory needed by the driver, to fulfil a request, within the crypto request object. The extra size needed for base extended descriptor, hw descriptor commands and link tables is computed in frontend driver (caamalg_qi2)

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Nick Terrell
> On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote: > > On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: >> From: Nick Terrell >> >> This patch: >> - Moves `include/linux/zstd.h` -> `lib/zstd/zstd.h` >> - Adds a new API in `include/linux/zstd.h` that is functionally >> equivale

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: > > > > On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote: > > > > On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: > >> From: Nick Terrell > >> > >> This patch: > >> - Moves `include/linux/zstd.h` -> `lib/zstd/zstd.h`

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Nick Terrell
> On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote: > > On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: >> >> >>> On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote: >>> >>> On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: From: Nick Terrell This

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
On Thu, Dec 03, 2020 at 03:59:21AM +, Nick Terrell wrote: > On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote: > > On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: > >> On Dec 2, 2020, at 5:16 PM, Michał Mirosław > >> wrote: > >>> On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick T

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Nick Terrell
> On Dec 2, 2020, at 9:03 PM, Michał Mirosław wrote: > > On Thu, Dec 03, 2020 at 03:59:21AM +, Nick Terrell wrote: >> On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote: >>> On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: On Dec 2, 2020, at 5:16 PM, Michał Mirosław