[PATCH][next][resend] lib/mpi: fix off-by-one check on index "no"

2020-09-30 Thread Colin King
From: Colin Ian King There is an off-by-one range check on the upper limit of index "no". Fix this by changing the > comparison to >= Addresses-Coverity: ("Out-of-bounds read") Fixes: a8ea8bdd9df9 ("lib/mpi: Extend the MPI library") Signed-off-by: Colin Ian King --- resend to Cc linux-crypto

Re: [PATCH][next][resend] lib/mpi: fix off-by-one check on index "no"

2020-09-30 Thread Ondrej Mosnáček
st 30. 9. 2020 o 15:04 Colin King napísal(a): > > From: Colin Ian King > > There is an off-by-one range check on the upper limit of > index "no". Fix this by changing the > comparison to >= Note that this doesn't completely fix the bug though... (see below) > > Addresses-Coverity: ("Out-of-bou

Re: [PATCH][next][resend] lib/mpi: fix off-by-one check on index "no"

2020-09-30 Thread Ard Biesheuvel
On Wed, 30 Sep 2020 at 16:36, Ondrej Mosnáček wrote: > > st 30. 9. 2020 o 15:04 Colin King napísal(a): > > > > From: Colin Ian King > > > > There is an off-by-one range check on the upper limit of > > index "no". Fix this by changing the > comparison to >= > > Note that this doesn't completely

Re: WARNING: at kernel/workqueue.c:1473 __queue_work+0x3b8/0x3d0

2020-09-30 Thread Daniel Jordan
On Fri, Sep 25, 2020 at 08:12:03PM +0200, Corentin Labbe wrote: > On Tue, Mar 03, 2020 at 04:31:11PM -0500, Daniel Jordan wrote: > > On Tue, Mar 03, 2020 at 08:48:19AM +0100, Corentin Labbe wrote: > > > The patch fix the issue. Thanks! > > > > Thanks for trying it! > > > > > So you could add: > >

Re: [PATCH 00/18] use semicolons rather than commas to separate statements

2020-09-30 Thread Joe Perches
On Tue, 2020-09-29 at 12:37 +0100, Mark Brown wrote: > On Mon, Sep 28, 2020 at 05:45:24PM -0700, Joe Perches wrote: > > On Mon, 2020-09-28 at 20:35 +0100, Mark Brown wrote: > > > [1/1] regmap: debugfs: use semicolons rather than commas to separate > > > statements > > > commit: 7f4a122d0b50b

Re: [PATCH v4 0/9] Update to zstd-1.4.6

2020-09-30 Thread Nick Terrell
> On Sep 29, 2020, at 11:53 PM, Christoph Hellwig wrote: > > As you keep resend this I keep retelling you that should not do it. > Please provide a proper Linux API, and switch to that. Versioned APIs > have absolutely no business in the Linux kernel. The API is not versioned. We provide a st

Re: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6

2020-09-30 Thread Nick Terrell
> On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote: > > From: Nick Terrell It has been brought to my attention that patch 3 hasn’t made it to patchwork, likely because it is too large. I’ll include a pull request in the next cover letter, together with the patches (if needed). Please pull fro

[PATCH] crypto: qat - fix function parameters descriptions

2020-09-30 Thread Giovanni Cabiddu
Fix description of function parameters. This is to fix the following warnings when compiling the driver with W=1: drivers/crypto/qat/qat_common/adf_sriov.c:133: warning: Function parameter or member 'numvfs' not described in 'adf_sriov_configure' drivers/crypto/qat/qat_common/adf_dev_mgr.

[PATCH] crypto: qat - drop input parameter from adf_enable_aer()

2020-09-30 Thread Giovanni Cabiddu
Remove pointer to struct pci_driver from function adf_enable_aer() as it is possible to get it directly from pdev->driver. Signed-off-by: Giovanni Cabiddu Reviewed-by: Fiona Trahe Reviewed-by: Wojciech Ziemba Reviewed-by: Andy Shevchenko --- drivers/crypto/qat/qat_c3xxx/adf_drv.c | 2