Re: [PATCH v2 00/20] crypto: crypto API library interfaces for WireGuard

On Wed, 2 Oct 2019 at 16:17, Ard Biesheuvel wrote: > ... > > In the future, I would like to extend these interfaces to use static calls, > so that the accelerated implementations can be [un]plugged at runtime. For > the time being, we rely on weak aliases and conditional exports so that the > user

Re: PROBLEM: geode-aes not working with skcipher cbc

Hi Gert and others, Would it be possible to fix the geode-aes module? [Wed Oct 2 18:57:38 2019] Error allocating fallback algo cbc(aes) [Wed Oct 2 18:57:38 2019] alg: skcipher: Failed to load transform for cbc-aes-geode: -2 [Wed Oct 2 18:57:38 2019] Geode LX AES :00:01.2: GEODE AES engin

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Wed, Oct 02, 2019 at 10:00:19AM -0400, Mimi Zohar wrote: > On Thu, 2019-09-26 at 20:16 +0300, Jarkko Sakkinen wrote: > > Only the kernel random pool should be used for generating random numbers. > > TPM contributes to that pool among the other sources of entropy. In here it > > is not, agreed, a

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Thu, Oct 03, 2019 at 02:41:19PM +0300, Jarkko Sakkinen wrote: > On Wed, Oct 02, 2019 at 10:00:19AM -0400, Mimi Zohar wrote: > > On Thu, 2019-09-26 at 20:16 +0300, Jarkko Sakkinen wrote: > > > Only the kernel random pool should be used for generating random numbers. > > > TPM contributes to that

Re: [PATCH] crypto: BLAKE2 reference implementation

Hello David, On Mon, 30 Sep 2019 at 15:12, David Sterba wrote: > > The patch brings support of several BLAKE2 algorithms (2b, 2s, various > digest lengths). The in-tree user will be btrfs (for checksumming), > we're going to use the BLAKE2b-256 variant. It would be ideal if the > patches get mer

[PATCH v2] KEYS: asym_tpm: Switch to get_random_bytes()

Only the kernel random pool should be used for generating random numbers. TPM contributes to that pool among the other sources of entropy. In here it is not, agreed, absolutely critical because TPM is what is trusted anyway but in order to remove tpm_get_random() we need to first remove all the cal

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Thu, 2019-10-03 at 14:41 +0300, Jarkko Sakkinen wrote: > On Wed, Oct 02, 2019 at 10:00:19AM -0400, Mimi Zohar wrote: > > On Thu, 2019-09-26 at 20:16 +0300, Jarkko Sakkinen wrote: > > > Only the kernel random pool should be used for generating random numbers. > > > TPM contributes to that pool am

[PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated the generic CBC template wrapper from a blkcipher to a skcipher algo, to get away from the deprecated blkcipher interface. However, as a side effect, drivers that instantiate CBC transforms using the blkcipher as a fallback no lo

Re: [Crypto chcr] crypto: af_alg - cast ki_complete call's ternary operator variables to long.

On Wed, Oct 02, 2019 at 11:32:31PM -0700, Atul Gupta wrote: > The ki_complete called from af_alg_async_cb use ternary operator to get > the value of second argument.As err is signed int while resultlen is > unsigned int, by the precedence rule err is also processed as unsigned > int and lose its or

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Thu, Oct 03, 2019 at 09:02:32AM -0400, Mimi Zohar wrote: > On Thu, 2019-10-03 at 14:41 +0300, Jarkko Sakkinen wrote: > > On Wed, Oct 02, 2019 at 10:00:19AM -0400, Mimi Zohar wrote: > > > On Thu, 2019-09-26 at 20:16 +0300, Jarkko Sakkinen wrote: > > > > Only the kernel random pool should be used

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Thu, Oct 03, 2019 at 09:02:32AM -0400, Mimi Zohar wrote: > That isn't a valid justification for changing the original definition > of trusted keys.  Just as the kernel supports different methods of > implementing the same function on different architectures, trusted > keys will need to support d

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Thu, Oct 03, 2019 at 09:02:01PM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 03, 2019 at 09:02:32AM -0400, Mimi Zohar wrote: > > That isn't a valid justification for changing the original definition > > of trusted keys.  Just as the kernel supports different methods of > > implementing the same f

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

[Cc'ing David Safford] On Thu, 2019-10-03 at 20:58 +0300, Jarkko Sakkinen wrote: > On Thu, Oct 03, 2019 at 09:02:32AM -0400, Mimi Zohar wrote: > > On Thu, 2019-10-03 at 14:41 +0300, Jarkko Sakkinen wrote: > > > On Wed, Oct 02, 2019 at 10:00:19AM -0400, Mimi Zohar wrote: > > > > On Thu, 2019-09-26

Re: [PATCH] crypto: BLAKE2 reference implementation

Hi, thanks for the review. On Thu, Oct 03, 2019 at 02:18:55PM +0200, Ard Biesheuvel wrote: > On Mon, 30 Sep 2019 at 15:12, David Sterba wrote: > > The patch brings support of several BLAKE2 algorithms (2b, 2s, various > > digest lengths). The in-tree user will be btrfs (for checksumming), > > we

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated the generic CBC template wrapper from a blkcipher to a skcipher algo, to get away from the deprecated blkcipher interface. However, as a side effect, drivers that instantiate CBC t

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Thu, Oct 03, 2019 at 02:53:47PM -0400, Mimi Zohar wrote: > [Cc'ing David Safford] > > On Thu, 2019-10-03 at 20:58 +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 03, 2019 at 09:02:32AM -0400, Mimi Zohar wrote: > > > On Thu, 2019-10-03 at 14:41 +0300, Jarkko Sakkinen wrote: > > > > On Wed, Oct 02,

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Fri, Oct 04, 2019 at 12:51:25AM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 03, 2019 at 02:53:47PM -0400, Mimi Zohar wrote: > > [Cc'ing David Safford] > > > > On Thu, 2019-10-03 at 20:58 +0300, Jarkko Sakkinen wrote: > > > On Thu, Oct 03, 2019 at 09:02:32AM -0400, Mimi Zohar wrote: > > > > On T

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Fri, 2019-10-04 at 00:57 +0300, Jarkko Sakkinen wrote: > On Fri, Oct 04, 2019 at 12:51:25AM +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 03, 2019 at 02:53:47PM -0400, Mimi Zohar wrote: > > > [Cc'ing David Safford] > > > > > > On Thu, 2019-10-03 at 20:58 +0300, Jarkko Sakkinen wrote: > > > > On

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Fri, Oct 04, 2019 at 12:57:43AM +0300, Jarkko Sakkinen wrote: > On Fri, Oct 04, 2019 at 12:51:25AM +0300, Jarkko Sakkinen wrote: > > On Thu, Oct 03, 2019 at 02:53:47PM -0400, Mimi Zohar wrote: > > > [Cc'ing David Safford] > > > > > > On Thu, 2019-10-03 at 20:58 +0300, Jarkko Sakkinen wrote: > >

Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes()

On Thu, 2019-10-03 at 18:08 -0400, Mimi Zohar wrote: > On Fri, 2019-10-04 at 00:57 +0300, Jarkko Sakkinen wrote: > > On Fri, Oct 04, 2019 at 12:51:25AM +0300, Jarkko Sakkinen wrote: > > > On Thu, Oct 03, 2019 at 02:53:47PM -0400, Mimi Zohar wrote: > > > > [Cc'ing David Safford] > > > > > > > > On

Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

Hi Jarkko, On Wed, 25 Sep 2019 at 06:41, Jarkko Sakkinen wrote: > > On Wed, Sep 18, 2019 at 11:53:08AM +0530, Sumit Garg wrote: > > No worries :). I will send next version of patch-set. > > > > FYI, I will be travelling for Linaro Connect next week so you could > > expect some delays in my respon

Re: [PATCH] crypto: geode-aes - switch to skcipher for cbc(aes) fallback

On Thu, 3 Oct 2019 at 23:26, Gert Robben wrote: > > Op 03-10-2019 om 15:39 schreef Ard Biesheuvel: > > Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated > > the generic CBC template wrapper from a blkcipher to a skcipher algo, > > to get away from the deprecated blkcipher inter