Re: [PATCH] crypto: gcm - fix cacheline sharing

2019-06-06 Thread Horia Geanta
On 6/6/2019 9:58 AM, Herbert Xu wrote: > On Thu, Jun 06, 2019 at 08:53:10AM +0200, Ard Biesheuvel wrote: >> >> That same patch 'fixes' CBC, since CBC was never broken to begin with. >> The CTS driver does not have something like the auth_tag sharing the >> same cacheline with the IV, so CBC has alw

Re: [PATCH] crypto: gcm - fix cacheline sharing

2019-06-06 Thread Herbert Xu
On Thu, Jun 06, 2019 at 07:10:06AM +, Horia Geanta wrote: > > Not really. > I am in favor of using the HW to update the IV, which would work for all > skcipher algorithms. > I have the fix ready, will send it in a couple of days. OK that would be interesting to see. But I presume you are stil

[PATCH] ARM: dts: imx7ulp: add crypto support

2019-06-06 Thread Horia Geantă
From: Iuliana Prodan Add crypto node in device tree for CAAM support. Noteworthy is that on 7ulp the interrupt line is shared between the two job rings. Signed-off-by: Iuliana Prodan Signed-off-by: Franck LENORMAND Signed-off-by: Horia Geantă --- I've just realized that this patch should be

Re: [PATCH] crypto: gcm - fix cacheline sharing

2019-06-06 Thread Horia Geanta
On 6/6/2019 10:16 AM, Herbert Xu wrote: > On Thu, Jun 06, 2019 at 07:10:06AM +, Horia Geanta wrote: >> >> Not really. >> I am in favor of using the HW to update the IV, which would work for all >> skcipher algorithms. >> I have the fix ready, will send it in a couple of days. > > OK that would

Re: [PATCH] crypto: gcm - fix cacheline sharing

2019-06-06 Thread Herbert Xu
On Thu, Jun 06, 2019 at 08:36:52AM +, Horia Geanta wrote: > > Yes, an internally kmalloc-ed buffer is used for storing the IV (both input > and > output IV). > Once HW finishes the job, area is DMA unmapped and then output IV is copied > into > req->iv. That sounds good to me. Thanks! -- E

Re: mmotm 2019-06-04-16-33 uploaded (drivers/crypto/atmel)

2019-06-06 Thread Ard Biesheuvel
On Wed, 5 Jun 2019 at 20:56, Randy Dunlap wrote: > > On 6/4/19 4:34 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2019-06-04-16-33 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > > >

[PATCH v1 1/5] crypto: talitos - fix ECB and CBC algs ivsize

2019-06-06 Thread Christophe Leroy
commit d84cc9c9524e ("crypto: talitos - fix ECB algs ivsize") wrongly modified CBC algs ivsize instead of ECB aggs ivsize. This restore the CBC algs original ivsize of removes ECB's ones. Signed-off-by: Christophe Leroy Fixes: d84cc9c9524e ("crypto: talitos - fix ECB algs ivsize") --- drivers/c

[PATCH v1 0/5] Additional fixes on Talitos driver

2019-06-06 Thread Christophe Leroy
This series is the last set of fixes for the Talitos driver. We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: [3.385197] bus: 'platform': really_probe: probing driver talitos with device ff02.crypto [3

[PATCH v1 4/5] crypto: talitos - eliminate unneeded 'done' functions at build time

2019-06-06 Thread Christophe Leroy
When building for SEC1 only, talitos2_done functions are unneeded and should go away. For this, use has_ftr_sec1() which will always return true when only SEC1 support is being built, allowing GCC to drop TALITOS2 functions. Signed-off-by: Christophe Leroy --- drivers/crypto/talitos.c | 2 +- 1

[PATCH v1 2/5] crypto: talitos - move struct talitos_edesc into talitos.h

2019-06-06 Thread Christophe Leroy
Next patch will require struct talitos_edesc to be defined earlier in talitos.c This patch moves it into talitos.h so that it can be used from any place in talitos.c Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash on SEC1") Signed-off-by: Christophe Leroy --- drivers/c

[PATCH v1 3/5] crypto: talitos - fix hash on SEC1.

2019-06-06 Thread Christophe Leroy
On SEC1, hash provides wrong result when performing hashing in several steps with input data SG list has more than one element. This was detected with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: [ 44.185947] alg: hash: md5-talitos test failed (wrong result) on test vector 6, cfg="random: may_sleep use_f

[PATCH v1 5/5] crypto: talitos - drop icv_ool

2019-06-06 Thread Christophe Leroy
icv_ool is not used anymore, drop it. Fixes: 9cc87bc3613b ("crypto: talitos - fix AEAD processing") Signed-off-by: Christophe Leroy --- drivers/crypto/talitos.c | 3 --- drivers/crypto/talitos.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talit

[PATCH] crypto: qat - use struct_size() helper

2019-06-06 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct qat_alg_buf_list { ... struct qat_alg_buf bufers[]; } __packed _

[PATCH] crypto: hisilicon - Use the correct style for SPDX License Identifier

2019-06-06 Thread Nishad Kamdar
This patch corrects the SPDX License Identifier style in header file related to Crypto Drivers for Hisilicon SEC Engine in Hip06 and Hip07. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used) Changes made by

Re: [PATCH] crypto: hisilicon - Use the correct style for SPDX License Identifier

2019-06-06 Thread Jonathan Cameron
On Thu, 6 Jun 2019 20:36:17 +0530 Nishad Kamdar wrote: > This patch corrects the SPDX License Identifier style > in header file related to Crypto Drivers for Hisilicon > SEC Engine in Hip06 and Hip07. > For C header files Documentation/process/license-rules.rst > mandates C-like comments (opposed

[PATCH 1/2] crypto: mxs-dcp - Use devm_platform_ioremap_resource()

2019-06-06 Thread Fabio Estevam
Use devm_platform_ioremap_resource() to simplify the code a bit. Signed-off-by: Fabio Estevam --- drivers/crypto/mxs-dcp.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c index bdc4c42d3ac8..f1fa637cb029 100644 --- a/dri

[PATCH 2/2] crypto: sahara - Use devm_platform_ioremap_resource()

2019-06-06 Thread Fabio Estevam
Use devm_platform_ioremap_resource() to simplify the code a bit. Signed-off-by: Fabio Estevam --- drivers/crypto/sahara.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c index fd11162a915e..616fdc9f1816 100644 --- a/drivers

[PATCH] crypto: talitos - Use devm_platform_ioremap_resource()

2019-06-06 Thread Fabio Estevam
Use devm_platform_ioremap_resource() to simplify the code a bit. Signed-off-by: Fabio Estevam --- drivers/crypto/talitos.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index 32a7e747dc5f..f2269a2f8ce6 100644 --- a/dr

[PATCH v2] crypto: talitos - Use devm_platform_ioremap_resource()

2019-06-06 Thread Fabio Estevam
Use devm_platform_ioremap_resource() to simplify the code a bit. While at it, remove unneeded error message in case of devm_platform_ioremap_resource() failure, as the core mm code will take care of it. Signed-off-by: Fabio Estevam --- Changes since v1: - Adjust the error check for devm_platform

Re: [PATCH v2] crypto: talitos - Use devm_platform_ioremap_resource()

2019-06-06 Thread Christophe Leroy
Le 06/06/2019 à 19:28, Fabio Estevam a écrit : Use devm_platform_ioremap_resource() to simplify the code a bit. While at it, remove unneeded error message in case of devm_platform_ioremap_resource() failure, as the core mm code will take care of it. devm_platform_ioremap_resource() doesn't

Re: [PATCH v2] crypto: talitos - Use devm_platform_ioremap_resource()

2019-06-06 Thread Fabio Estevam
Hi Christophe, On Thu, Jun 6, 2019 at 2:45 PM Christophe Leroy wrote: > Have you checked that it has no impact ? > > On SOCs, areas of memory are often shared between several drivers. > devm_ioremap_ressource() can only be used if we are 100% sure that this > area of memory is not shared with an

Re: [PATCH 2/2] zstd: use U16 data type for rankPos

2019-06-06 Thread Nick Terrell
> On May 9, 2019, at 11:13 PM, Maninder Singh wrote: > > rankPos structure variables value can not be more than 512. > So it can easily be declared as U16 rather than U32. > > It will reduce stack usage of HUF_sort from 256 bytes to 128 bytes > > original: > e92ddbf0push{r4, r5, r6,

Re: [GIT] Crypto Fixes for 5.2

2019-06-06 Thread pr-tracker-bot
The pull request you sent on Thu, 6 Jun 2019 14:03:24 +0800: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ae8766042beee814c9e16e9ae1e84cd6eaa7ffaa Thank you! -- Deet-doot-dot, I am a bot.