Re: [PATCH v4 0/7] add integrity and security to TPM2 transactions

2018-10-24 Thread James Bottomley
On Wed, 2018-10-24 at 02:51 +0300, Jarkko Sakkinen wrote: > I would consider sending first a patch set that would iterate the > existing session stuff to be ready for this i.e. merge in two > iterations (emphasis on the word "consider"). We can probably merge > the groundwork quite fast. I realise

Re: [PATCH v4 2/7] tpm2-sessions: Add full HMAC and encrypt/decrypt session handling

2018-10-24 Thread Jarkko Sakkinen
On Tue, 23 Oct 2018, Ard Biesheuvel wrote: On 23 October 2018 at 04:01, James Bottomley wrote: On Mon, 2018-10-22 at 19:19 -0300, Ard Biesheuvel wrote: [...] +static void hmac_init(struct shash_desc *desc, u8 *key, int keylen) +{ + u8 pad[SHA256_BLOCK_SIZE]; + int i; + + desc

Re: [PATCH v4 2/7] tpm2-sessions: Add full HMAC and encrypt/decrypt session handling

2018-10-24 Thread James Bottomley
On Wed, 2018-10-24 at 02:48 +0300, Jarkko Sakkinen wrote: > On Mon, 22 Oct 2018, James Bottomley wrote: > > [...] I'll tidy up the descriptions. > These all sould be combined with the existing session stuff inside > tpm2-cmd.c and not have duplicate infrastructures. The file name > should be tpm2

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-24 Thread anilc
Hi, Thanks for the comments, response inline. Thanks, AnilKumar On 2018-10-18 17:13, kbuild test robot wrote: Hi AnilKumar, Thank you for the patch! Yet something to improve: [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.19-rc8 next-20181018] [if your patch is app

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-24 Thread AnilKumar Chimata
Hi Theodore, Thanks for the comments, On 2018-10-17 22:34, Theodore Y. Ts'o wrote: First, thanks for the effort for working on getting the core ICE driver support into upstreamable patches. On Wed, Oct 17, 2018 at 08:47:56PM +0530, AnilKumar Chimata wrote: +2) Per File Encryption (PFE) +Per F

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-24 Thread AnilKumar Chimata
Hi Randy, Thanks for your comments, On 2018-10-17 23:09, Randy Dunlap wrote: On 10/17/18 8:17 AM, AnilKumar Chimata wrote: This patch adds support for Inline Crypto Engine (ICE), which is embedded into storage device/controller such as UFS/eMMC. ICE is intended for high throughput cryptographi

Re: [RFC PATCH v2 11/12] crypto: adiantum - add Adiantum support

2018-10-24 Thread Eric Biggers
On Tue, Oct 23, 2018 at 07:40:34AM -0300, Ard Biesheuvel wrote: > On 20 October 2018 at 15:12, Eric Biggers wrote: > > Hi Ard, > > > > On Sat, Oct 20, 2018 at 12:17:58PM +0800, Ard Biesheuvel wrote: > >> On 16 October 2018 at 01:54, Eric Biggers wrote: > >> > From: Eric Biggers > >> > > >> > Add

Re: [PATCH 2/3] crypto: ccree: add dt bindings for ccree 713

2018-10-24 Thread Rob Herring
On Tue, Oct 16, 2018 at 02:35:32PM +0100, Gilad Ben-Yossef wrote: > Add device tree bindings associating Arm TrustZone CryptoCell 713 with the > ccree driver. "dt-bindings: crypto: ..." for the subject. > > Signed-off-by: Gilad Ben-Yossef > --- > Documentation/devicetree/bindings/crypto/arm-cry