Re: [PATCH 1/3] crypto: authenc - add TLS type encryption

2016-03-07 Thread Cristian Stoica
Hi Tadeusz, +static int crypto_encauth_dgst_verify(struct aead_request *req, + unsigned int flags) +{ + struct crypto_aead *tfm = crypto_aead_reqtfm(req); + unsigned int authsize = crypto_aead_authsize(tfm); + struct aead_instance *inst = aead

[PATCH v3 1/3] Documentation: devicetree: add Freescale SCC bindings

2016-03-07 Thread Steffen Trumtrar
Add documentation for the Freescale Security Controller (SCC) found on i.MX25 SoCs. Signed-off-by: Steffen Trumtrar Acked-by: Rob Herring --- Changes in v2: - add clocks to required properties - add Acked-by .../devicetree/bindings/crypto/fsl-imx-scc.txt | 21 + 1

[PATCH v3 2/3] ARM: i.MX25: add scc module to dtsi

2016-03-07 Thread Steffen Trumtrar
Add the Security Controller (SCC) module to the dtsi. Signed-off-by: Steffen Trumtrar --- arch/arm/boot/dts/imx25.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index cde329e9b9e3..73118aba4cc4 100644 --- a/arch/arm/b

[PATCH v3 3/3] crypto: add basic driver for the MXC SCC

2016-03-07 Thread Steffen Trumtrar
According to the Freescale GPL driver code, there are two different Security Controller (SCC) versions: SCC and SCC2. The SCC is found on older i.MX SoCs, e.g. the i.MX25. This is the version implemented and tested here. As there is no publicly available documentation for this IP core, all inform

Re: [PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2016-03-07 Thread Steffen Trumtrar
Hi! On Tue, Mar 01, 2016 at 08:49:37AM +0100, Uwe Kleine-König wrote: > Hello Fabio, > > On Mon, Feb 29, 2016 at 08:54:19PM -0300, Fabio Estevam wrote: > > On Mon, Feb 29, 2016 at 6:38 PM, Uwe Kleine-König > > wrote: > > > On Mon, Feb 29, 2016 at 06:16:50PM -0300, Fabio Estevam wrote: > > >> On

Re: [PATCH 1/3] crypto: authenc - add TLS type encryption

2016-03-07 Thread Tadeusz Struk
Hi Cristian, On 03/07/2016 01:05 AM, Cristian Stoica wrote: > Hi Tadeusz, > > > +static int crypto_encauth_dgst_verify(struct aead_request *req, > + unsigned int flags) > +{ > + struct crypto_aead *tfm = crypto_aead_reqtfm(req); > + unsigned int aut

Re: [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA

2016-03-07 Thread David Howells
Andreas Ziegler wrote: > Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to > the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA, > but forgot to remove a 'select' to this option in the definition of > INTEGRITY_ASYMMETRIC_KEYS. > > Let's remove the select, as it's

Re: [PATCH] crypto: implement DH primitives under akcipher API

2016-03-07 Thread Tadeusz Struk
Hi Marcel, On 03/02/2016 05:46 AM, Marcel Holtmann wrote: > And I have the feeling that akcipher is not the best approach for adding a > key exchange method. I think we need a new method for doing exactly that. At > the base of it, the key exchange is fundamentally different. It is unfortunate t

Re: [PATCH] crypto: implement DH primitives under akcipher API

2016-03-07 Thread Marcel Holtmann
Hi Tadeusz, >> And I have the feeling that akcipher is not the best approach for adding a >> key exchange method. I think we need a new method for doing exactly that. At >> the base of it, the key exchange is fundamentally different. > > It is unfortunate that, unlike the symmetric ciphers, not

Re: [PATCH] crypto: implement DH primitives under akcipher API

2016-03-07 Thread Tadeusz Struk
Hi Marcel, On 03/07/2016 02:29 PM, Marcel Holtmann wrote: >> In this way we can define a generic user side of the key exchange interface, >> > and on the the driver side of the akcipher, the implementations would >> > overload >> > the existing akcipher encrypt(), decrypt(), set_pub_key(), set_pri