Re: [PATCH 0/3] KEYS: Use crypto rsa pkcs1pad module for software public keys

2016-02-29 Thread David Howells
Herbert Xu wrote: > David Howells wrote: > > > > Here's a set of patches that change the software public key asymmetric key > > subtype to use the RSA pkcs1pad module in the crypto layer. I've merged > > together mine and Tadeusz's patches. > > > > I have not included Tadeusz's original three

Re: [PATCH] [RFC] mm/page_ref, crypto/async_pq: don't put_page from __exit

2016-02-29 Thread Arnd Bergmann
On Monday 29 February 2016 16:40:02 Joonsoo Kim wrote: > > Hello, Arnd. > > I think that we can avoid this error by using __free_page(). > It would not be inlined so calling it would have no problem. > > Could you test it, please? Yes, I suspect the driver should have done that anyway, new patc

[PATCH] crypto/async_pq: use __free_page() instead of put_page()

2016-02-29 Thread Arnd Bergmann
The addition of tracepoints to the page reference tracking had an unfortunate side-effect in at least one driver that calls put_page from its exit function, resulting in a link error: `.exit.text' referenced in section `__jump_table' of crypto/built-in.o: defined in discarded section `.exit.text'

[PATCH v2 1/3] Documentation: devicetree: add Freescale SCC bindings

2016-02-29 Thread Steffen Trumtrar
Add documentation for the Freescale Security Controller (SCC) found on i.MX25 SoCs. Signed-off-by: Steffen Trumtrar Acked-by: Rob Herring --- Changes since v1: - add clocks to required properties - add Acked-by .../devicetree/bindings/crypto/fsl-imx-scc.txt | 21 +

[PATCH v2 2/3] ARM: i.MX25: add scc module to dtsi

2016-02-29 Thread Steffen Trumtrar
Add the Security Controller (SCC) module to the dtsi. Signed-off-by: Steffen Trumtrar --- arch/arm/boot/dts/imx25.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index cde329e9b9e3..73118aba4cc4 100644 --- a/arch/arm/b

[PATCH v2 3/3] crypto: add basic driver for the MXC SCC

2016-02-29 Thread Steffen Trumtrar
According to the Freescale GPL driver code, there are two different Security Controller (SCC) versions: SCC and SCC2. The SCC is found on older i.MX SoCs, e.g. the i.MX25. This is the version implemented and tested here. As there is no publicly available documentation for this IP core, all inform

Re: [PATCH] PKCS#7: fix unitialized boolean 'want'

2016-02-29 Thread David Howells
Colin King wrote: > The boolean want is not initialized and hence garbage. The default should > be false (later it is only set to true on tne sinfo->authattrs check). > > Found with static analysis using CoverityScan > > Signed-off-by: Colin Ian King Applied. -- To unsubscribe from this list:

[PATCH 2/3] ARM: i.MX25: add RNGC node to dtsi

2016-02-29 Thread Steffen Trumtrar
Add a devicetree entry for the Random Number Generator Version C (RNGC). Signed-off-by: Steffen Trumtrar --- arch/arm/boot/dts/imx25.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index cde329e9b9e3..ec44ed125057 1006

[PATCH 1/3] Documentation: devicetree: add Freescale RNGC binding

2016-02-29 Thread Steffen Trumtrar
Add binding documentation for the Freescale RNGC found on some i.MX2/3/5 SoCs. Signed-off-by: Steffen Trumtrar --- Documentation/devicetree/bindings/rng/mxc_rngc.txt | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/mxc_rngc.txt di

[PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2016-02-29 Thread Steffen Trumtrar
The driver is ported from Freescales Linux git and can be found in the vendor/freescale/imx_2.6.35_maintain branch. According to that code, the RNGC is found on Freescales i.MX3/5 SoCs. The i.MX2x actually has an RNGB, which has no driver implementation in Freescales kernel. However as i

Re: [PATCH] crypto/async_pq: use __free_page() instead of put_page()

2016-02-29 Thread Dan Williams
On Mon, Feb 29, 2016 at 1:33 AM, Arnd Bergmann wrote: > The addition of tracepoints to the page reference tracking had an > unfortunate side-effect in at least one driver that calls put_page > from its exit function, resulting in a link error: > > `.exit.text' referenced in section `__jump_table'

Re: [PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2016-02-29 Thread Fabio Estevam
On Mon, Feb 29, 2016 at 12:52 PM, Steffen Trumtrar wrote: > + ret = clk_prepare_enable(rngc->clk); > + if (ret) > + return ret; > + > + rngc->irq = platform_get_irq(pdev, 0); > + if (!rngc->irq) { > + dev_err(&pdev->dev, "FSL RNGC couldn't get i

Re: [PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2016-02-29 Thread Uwe Kleine-König
On Mon, Feb 29, 2016 at 06:16:50PM -0300, Fabio Estevam wrote: > On Mon, Feb 29, 2016 at 12:52 PM, Steffen Trumtrar > wrote: > > > + ret = clk_prepare_enable(rngc->clk); > > + if (ret) > > + return ret; > > + > > + rngc->irq = platform_get_irq(pdev, 0); > > +

Re: [PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2016-02-29 Thread Fabio Estevam
On Mon, Feb 29, 2016 at 6:38 PM, Uwe Kleine-König wrote: > On Mon, Feb 29, 2016 at 06:16:50PM -0300, Fabio Estevam wrote: >> On Mon, Feb 29, 2016 at 12:52 PM, Steffen Trumtrar >> wrote: >> >> > + ret = clk_prepare_enable(rngc->clk); >> > + if (ret) >> > + return ret; >>

crypto regression in 4.1.18: Check that kernel supports aes-cbc-essiv:sha256 cipher

2016-02-29 Thread Eric Wheeler
Hello all, We updated from 4.1.17 to 4.1.18 (same .config) and now get the following error when trying to open a LUKS volume. We've reverted to 4.1.17 and it still works, so except that I'm not sure which commit caused the problem, it is likely one of the recent commits: When we `cryptsetup l

Re: crypto regression in 4.1.18: Check that kernel supports aes-cbc-essiv:sha256 cipher

2016-02-29 Thread Greg KH
On Tue, Mar 01, 2016 at 01:32:05AM +, Eric Wheeler wrote: > Hello all, > > We updated from 4.1.17 to 4.1.18 (same .config) and now get the following > error when trying to open a LUKS volume. We've reverted to 4.1.17 and it > still works, so except that I'm not sure which commit caused the

Re: [PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2016-02-29 Thread Uwe Kleine-König
Hello Fabio, On Mon, Feb 29, 2016 at 08:54:19PM -0300, Fabio Estevam wrote: > On Mon, Feb 29, 2016 at 6:38 PM, Uwe Kleine-König > wrote: > > On Mon, Feb 29, 2016 at 06:16:50PM -0300, Fabio Estevam wrote: > >> On Mon, Feb 29, 2016 at 12:52 PM, Steffen Trumtrar > >> wrote: > >> > >> > + ret