Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-02-24 Thread Jiri Slaby
On 02/21/2016, 05:40 PM, Milan Broz wrote: > On 02/20/2016 03:33 PM, Thomas D. wrote: >> Hi, >> >> FYI: v3.10.97, v3.14.61 and 3.18.27 are also affected. >> >> v4.3.6 works. Looks like the patch set is only compatible with >=linux-4.3. >> >> v3.12.54 works because it doesn't contain the patch in qu

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-02-24 Thread Milan Broz
On 02/24/2016 09:32 AM, Jiri Slaby wrote: >> +af_alg_release_parent(sk); > > and this occurs to me like a double release? yes, my copy&paste mistake. Anyway, there should be also two more patches from series. If it helps, I copied proper backport here (upstream commit is referenced in head

Asymmetric ciphers: counter measures

2016-02-24 Thread Stephan Mueller
Hi Herbert, currently RSA is implemented as the only asymmetric cipher in software. But others must be expected coming. We have seen the DH patch already. Albeit software asym ciphers is only a fallback, what is your opinion to cover those implementations with counter measures? Currently RSA d

Re: [PATCH] X.509: Fix test for self-signed certificate

2016-02-24 Thread David Howells
Hi Michal, I have the attached patch already in my queue. David --- commit d19fcb825912c67e09e0575b95accaa42899e07f Author: David Howells Date: Wed Feb 24 14:37:54 2016 + X.509: Don't treat self-signed keys specially Trust for a self-signed certificate can normally only be de

Re: [PATCH] Re: Broken userspace crypto in linux-4.1.18

2016-02-24 Thread Greg KH
On Wed, Feb 24, 2016 at 09:54:48AM +0100, Milan Broz wrote: > On 02/24/2016 09:32 AM, Jiri Slaby wrote: > >> + af_alg_release_parent(sk); > > > > and this occurs to me like a double release? > > yes, my copy&paste mistake. Which is why I want the real patches backported please. Whenever we do

[PATCH 2/2] crypto: remove padding logic from rsa.c

2016-02-24 Thread Tadeusz Struk
This reverts back the rsa.c to do the math primitives only. It also reverts the akcipher api changes as the hash param will be passed to the rsa-pkcs1 template. All padding and encoding logic is moved to the rsa-pkcs1pad. The software_pkey.c uses pkcs1pad template to allocate the akcipher and the h

[PATCH 1/2] crypto: Add hash param to pkcs1pad

2016-02-24 Thread Tadeusz Struk
This adds hash param to pkcs1pad. The pkcs1pad template can work with or without the hash. When hash param is provided then the verify operation will also verify the output against the known digest. Signed-off-by: Tadeusz Struk --- crypto/rsa-pkcs1pad.c | 182 +++

[PATCH 0/2] KEYS: Use pkcs1pad for padding in software_pkey

2016-02-24 Thread Tadeusz Struk
Hi David, I have converted the software_pkey to make use of the pkcs1pad template. The rsa.c is reverted back to what it was i.e. just math primitives and all padding is done in rsa-pkcs1padd.c software_pkey.c just allocates pksc1padd(alg,hash) This is incremental series on top of the current http

Re: [PATCH 0/2] KEYS: Use pkcs1pad for padding in software_pkey

2016-02-24 Thread David Howells
Tadeusz Struk wrote: > I have converted the software_pkey to make use of the pkcs1pad > template. The rsa.c is reverted back to what it was i.e. just > math primitives and all padding is done in rsa-pkcs1padd.c > software_pkey.c just allocates pksc1padd(alg,hash) Okay, thanks - I'll take a look

Re: [PATCH v2 0/2] crypto: asynchronous compression api

2016-02-24 Thread Giovanni Cabiddu
Hi Herbert, On Tue, Feb 16, 2016 at 07:57:17PM +, Herbert Xu wrote: > Can you give an example on how to use the noctx support with > your acomp interface? In this version of the acomp api an algorithm can specify different sizes for the compression and the decompression contexts by setting th

[PATCH v2 3/3] crypto: caam - add support for RSA algorithm

2016-02-24 Thread Tudor Ambarus
Add RSA support to caam driver. Coauthored-by: Yashpal Dutta Signed-off-by: Tudor Ambarus --- v2: use kzfree instead of memset with zero and kfree. drivers/crypto/caam/Kconfig | 13 + drivers/crypto/caam/Makefile | 13 + drivers/crypto/caam/caam_rsaprivkey.asn1 | 1

[PATCH v3 7/8] crypto: acomp - add support for deflate via scomp

2016-02-24 Thread Giovanni Cabiddu
This patch implements an scomp backend for the deflate compression algorithm. This way, deflate is exposed through the acomp api. Signed-off-by: Giovanni Cabiddu --- crypto/Kconfig |1 + crypto/deflate.c | 112 +- 2 files changed, 103 in

[PATCH v3 0/8] crypto: asynchronous compression api

2016-02-24 Thread Giovanni Cabiddu
The following patch set introduces acomp, a generic asynchronous (de)compression api. What is proposed is a new crypto type called crypto_acomp_type, plus a new struct acomp_alg and struct crypto_acomp, together with number of helper functions to register acomp type algorithms and allocate tfm inst

[PATCH v3 1/8] crypto: add asynchronous compression api

2016-02-24 Thread Giovanni Cabiddu
This patch introduces acomp, an asynchronous compression api that uses scatterlist buffers. Signed-off-by: Giovanni Cabiddu --- crypto/Kconfig | 10 + crypto/Makefile |2 + crypto/acompress.c | 118 + crypto/crypto_user

[PATCH v3 3/8] crypto: acomp - add support for lzo via scomp

2016-02-24 Thread Giovanni Cabiddu
This patch implements an scomp backend for the lzo compression algorithm. This way, lzo is exposed through the acomp api. Signed-off-by: Giovanni Cabiddu --- crypto/Kconfig |1 + crypto/lzo.c | 100 +++ 2 files changed, 86 insertions(+),

[PATCH v3 6/8] crypto: acomp - add support for 842 via scomp

2016-02-24 Thread Giovanni Cabiddu
This patch implements an scomp backend for the 842 compression algorithm. This way, 842 is exposed through the acomp api. Signed-off-by: Giovanni Cabiddu --- crypto/842.c | 84 ++-- crypto/Kconfig |1 + 2 files changed, 82 insertions(+)

[PATCH v3 5/8] crypto: acomp - add support for lz4hc via scomp

2016-02-24 Thread Giovanni Cabiddu
This patch implements an scomp backend for the lz4hc compression algorithm. This way, lz4hc is exposed through the acomp api. Signed-off-by: Giovanni Cabiddu --- crypto/Kconfig |1 + crypto/lz4hc.c | 94 ++-- 2 files changed, 85 insertion

[PATCH v3 4/8] crypto: acomp - add support for lz4 via scomp

2016-02-24 Thread Giovanni Cabiddu
This patch implements an scomp backend for the lz4 compression algorithm. This way, lz4 is exposed through the acomp api. Signed-off-by: Giovanni Cabiddu --- crypto/Kconfig |1 + crypto/lz4.c | 93 ++-- 2 files changed, 84 insertions(+)

[PATCH v3 2/8] crypto: add driver-side scomp interface

2016-02-24 Thread Giovanni Cabiddu
Add a synchronous back-end (scomp) to acomp. This allows to easily expose the already present compression algorithms in LKCF via acomp. Signed-off-by: Giovanni Cabiddu --- crypto/Makefile |1 + crypto/acompress.c | 75 ++- crypto/scompress.c

[PATCH v3 8/8] crypto: acomp - update testmgr with support for acomp

2016-02-24 Thread Giovanni Cabiddu
This patch adds tests to the test manager for algorithms exposed through the acomp api Signed-off-by: Giovanni Cabiddu --- crypto/testmgr.c | 159 +- 1 files changed, 146 insertions(+), 13 deletions(-) diff --git a/crypto/testmgr.c b/crypto/t

Re: [PATCH] vti6: Add pmtu handling to vti6_xmit.

2016-02-24 Thread Mark McKinstry
On 19/02/16 01:19, Steffen Klassert wrote: > On Thu, Feb 18, 2016 at 01:40:00AM +, Mark McKinstry wrote: >> This patch fixes our issue, thanks. In our scenario the tunnel path MTU >> now gets updated so that subsequent large packets sent over the tunnel >> get fragmented correctly. > I've appli