Re: [PATCH v3 1/2] crypto: KEYS: convert public key to the akcipher api

2015-12-23 Thread kbuild test robot
Hi Tadeusz, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.4-rc6 next-20151223] url: https://github.com/0day-ci/linux/commits/Tadeusz-Struk/crypto-KEYS-convert-public-key-to-akcipher-api/20151223-132001 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH 00/24] crypto: atmel-aes: global rework of the driver

2015-12-23 Thread Herbert Xu
On Thu, Dec 17, 2015 at 05:48:31PM +0100, Cyrille Pitchen wrote: > Hi all, > > this series of patches is a global rework of the Atmel driver. Some > patches improve the performances whereas others fix some bugs like > the counter overflow in CTR mode. > > It also updates some part of the code to

Re: [PATCH] crypto: 842 - remove WARN inside printk

2015-12-23 Thread Herbert Xu
On Mon, Dec 21, 2015 at 12:52:10PM -0500, Dan Streetman wrote: > Remove the WARN() from the beN_to_cpu macro, which is used as a param to a > pr_debug() call. With a certain kernel config, this printk-in-printk > results in the no_printk() macro trying to recursively call the > no_printk() macro,

[PATCH] crypto: ccp - use to_pci_dev and to_platform_device

2015-12-23 Thread Geliang Tang
Use to_pci_dev() and to_platform_device() instead of open-coding. Signed-off-by: Geliang Tang --- drivers/crypto/ccp/ccp-pci.c | 8 drivers/crypto/ccp/ccp-platform.c | 6 ++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/ccp/ccp-pci.c b/drivers/cr

[PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api

2015-12-23 Thread Tadeusz Struk
This patch converts the module verification and digital signature code to the new akcipher API. RSA implementation has been removed from crypto/asymmetric_keys and the new API is used for cryptographic primitives. There is no need for MPI above the akcipher API anymore. Modules can be verified with

Re: [linux-next:master 4796/5585] adf_vf_isr.c:undefined reference to `adf_enable_pf2vf_interrupts'

2015-12-23 Thread Tadeusz Struk
Hi, On 12/19/2015 04:24 PM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: 9379b045413ee30c88965e81d376af989ec32cf3 > commit: 1a72d3a6d1d9a08705546eba14f0390c565ccd24 [4796/5585] crypto: qat - > move isr files to qat commo

Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api

2015-12-23 Thread Herbert Xu
On Wed, Dec 23, 2015 at 06:33:53AM -0800, Tadeusz Struk wrote: > > Changes in v4: > - Flatten both patches into one to avoid bisect compilation problems. Why is this necessary? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herb

Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api

2015-12-23 Thread Tadeusz Struk
On 12/23/2015 06:51 AM, Herbert Xu wrote: >> > Changes in v4: >> > - Flatten both patches into one to avoid bisect compilation problems. > Why is this necessary? Because the first patch modifies the struct public_key and removes the MPIs from it, which the code modified in the second patch still

[PATCH] crypto: qat - fix SKU definiftion for c3xxx dev

2015-12-23 Thread Tadeusz Struk
c3xxx doesn't have the esram BAR and only has 6 ue. Signed-off-by: Tadeusz Struk --- drivers/crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.c | 22 ++ drivers/crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.h |5 ++--- 2 files changed, 8 insertions(+), 19 deletions(-) diff --git a/driv

Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api

2015-12-23 Thread Herbert Xu
On Wed, Dec 23, 2015 at 06:58:55AM -0800, Tadeusz Struk wrote: > > Because the first patch modifies the struct public_key and removes the MPIs > from it, > which the code modified in the second patch still uses. If bisect only takes > the first > then the build will fail on the security/integrit

Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api

2015-12-23 Thread Tadeusz Struk
On 12/23/2015 12:21 PM, Herbert Xu wrote: > Why not just leave the MPIs in the structure and only remove them > by adding a third patch? Right, I think that's a better way of resolving this. v5 on it's way. Thanks, -- TS -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" i

[PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api

2015-12-23 Thread Tadeusz Struk
This patch set converts the module verification and digital signature code to the new akcipher API. RSA implementation has been removed from crypto/asymmetric_keys and the new API is used for cryptographic primitives. There is no need for MPI above the akcipher API anymore. Modules can be verified

[PATCH v5 3/3] crypto: public_key: remove MPIs from public_key_signature struct

2015-12-23 Thread Tadeusz Struk
After digsig_asymmetric.c is converted the MPIs can be now safely removed from the public_key_signature structure. Signed-off-by: Tadeusz Struk --- include/crypto/public_key.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/include/crypto/public_key.h b/inclu

[PATCH v5 2/3] integrity: convert digsig to akcipher api

2015-12-23 Thread Tadeusz Struk
Convert asymmetric_verify to akcipher api. Signed-off-by: Tadeusz Struk --- security/integrity/Kconfig |1 + security/integrity/digsig_asymmetric.c | 10 +++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/security/integrity/Kconfig b/security/integrity/Kc

[PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

2015-12-23 Thread Tadeusz Struk
This patch converts the module verification code to the new akcipher API. Signed-off-by: Tadeusz Struk --- crypto/asymmetric_keys/Kconfig|2 crypto/asymmetric_keys/Makefile |7 - crypto/asymmetric_keys/pkcs7_parser.c | 12 +- crypto/asymmetric_keys/pkcs7_trus