Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
;> simpler, faster, and more correct. >>> >>> Cc: sta...@vger.kernel.org # 4.9 only >>> Reported-by: Eric Biggers >>> Signed-off-by: Andy Lutomirski >> >> 11 patches applied to wireless-drivers-next.git, thanks. >> >> 1fef293b8a98 orinoco

Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
gt;> Cc: sta...@vger.kernel.org # 4.9 only >> Reported-by: Eric Biggers >> Signed-off-by: Andy Lutomirski > > 11 patches applied to wireless-drivers-next.git, thanks. > > 1fef293b8a98 orinoco: Use shash instead of ahash for MIC calculations > a08b98196a36 rt2800: make rx amp

Re: orinoco: Use shash instead of ahash for MIC calculations

2016-12-30 Thread Kalle Valo
eported-by: Eric Biggers > Signed-off-by: Andy Lutomirski 11 patches applied to wireless-drivers-next.git, thanks. 1fef293b8a98 orinoco: Use shash instead of ahash for MIC calculations a08b98196a36 rt2800: make rx ampdu_factor depend on number of rx chains e49abb19d1bf rt2800: don't set ht para

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Kalle Valo
Andy Lutomirski writes: > On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo wrote: >> Andy Lutomirski writes: >> >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>> at the stack. >>> >>> Fix it by switching from ahash to shash. The result should be >>> simpler, faster, and

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Andy Lutomirski
On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo wrote: > Andy Lutomirski writes: > >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash. The result should be >> simpler, faster, and more correct. >> >> Cc: sta...@vger

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-13 Thread Kalle Valo
Andy Lutomirski writes: > Eric Biggers pointed out that the orinoco driver pointed scatterlists > at the stack. > > Fix it by switching from ahash to shash. The result should be > simpler, faster, and more correct. > > Cc: sta...@vger.kernel.org # 4.9 only > Reported-by: Eric Biggers > Signed-o

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-12 Thread Eric Biggers
On Mon, Dec 12, 2016 at 12:55:55PM -0800, Andy Lutomirski wrote: > +int orinoco_mic(struct crypto_shash *tfm_michael, u8 *key, > u8 *da, u8 *sa, u8 priority, > u8 *data, size_t data_len, u8 *mic) > { > - AHASH_REQUEST_ON_STACK(req, tfm_michael); > - struct scatt

[PATCH] orinoco: Use shash instead of ahash for MIC calculations

2016-12-12 Thread Andy Lutomirski
Eric Biggers pointed out that the orinoco driver pointed scatterlists at the stack. Fix it by switching from ahash to shash. The result should be simpler, faster, and more correct. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers Signed-off-by: Andy Lutomirski --- Compile-teste