Re: crypto ahash error handling

2010-11-12 Thread Dmitry Kasatkin
Well.. That was not the case before. I made a new patch set. I will send updates for SHA and AES soon after some more testing. - Dmitry On 12/11/10 02:05, ext Herbert Xu wrote: > On Thu, Nov 11, 2010 at 08:11:21PM +0200, Dmitry Kasatkin wrote: > >> Hi, >> >> Yes. Our HW is capable of produci

Re: crypto ahash error handling

2010-11-11 Thread Herbert Xu
On Thu, Nov 11, 2010 at 08:11:21PM +0200, Dmitry Kasatkin wrote: > Hi, > > Yes. Our HW is capable of producing unfinalised hashes. > Everything is fine. OK then you should be fine even if the user never makes the "final" call, right? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.

Re: crypto ahash error handling

2010-11-11 Thread Dmitry Kasatkin
Hi, Yes. Our HW is capable of producing unfinalised hashes. Everything is fine. No. It is not broken.. It cleans up if error... - Dmitry On 11/11/10 18:17, ext Herbert Xu wrote: > On Wed, Nov 10, 2010 at 04:54:51PM +0200, Dmitry Kasatkin wrote: > >> This is not good. >> >> Driver might allo

Re: crypto ahash error handling

2010-11-11 Thread Herbert Xu
On Wed, Nov 10, 2010 at 04:54:51PM +0200, Dmitry Kasatkin wrote: > This is not good. > > Driver might allocate some resources, which needs to be released. > crypto_ahash_final() should do some kind of "cleanup" task. Then your driver is broken. The whole hash API is designed around the fact that

Re: crypto ahash error handling

2010-11-10 Thread Dmitry Kasatkin
This is not good. Driver might allocate some resources, which needs to be released. crypto_ahash_final() should do some kind of "cleanup" task. - Dmitry On 10/11/10 14:27, ext Herbert Xu wrote: > Dmitry Kasatkin wrote: > >> Hello, >> >> When using crypto ahash API, is it necessary/mandatory

Re: crypto ahash error handling

2010-11-10 Thread Herbert Xu
Dmitry Kasatkin wrote: > Hello, > > When using crypto ahash API, is it necessary/mandatory to call > crypto_ahash_final() if crypto_ahash_update() returns error... > > Basically it might happen after several calls while calculating hash if > HW error happens. > It is not possible to continue has

crypto ahash error handling

2010-11-08 Thread Dmitry Kasatkin
Hello, When using crypto ahash API, is it necessary/mandatory to call crypto_ahash_final() if crypto_ahash_update() returns error... Basically it might happen after several calls while calculating hash if HW error happens. It is not possible to continue hash calculation. it is necessary to reset