Re: authenc: crash if key is not set

2017-04-10 Thread Herbert Xu
On Mon, Apr 10, 2017 at 12:49:16PM +0200, Stephan Müller wrote: > > May I ask that we agree on the memory management fix prior to handling this > issue? When consolidating the common code, I plan to have common code for the > nokey logic which then is automatically applicable to aead too. I thin

Re: authenc: crash if key is not set

2017-04-10 Thread Stephan Müller
Am Montag, 10. April 2017, 12:41:25 CEST schrieb Herbert Xu: Hi Herbert, > > > > Is that bug similar in nature as the algif_skcipher and algif_hash bugs > > that were fixed with the *nokey functions? > > Yes we need to add the same thing to AEAD. May I ask that we agree on the memory managemen

Re: authenc: crash if key is not set

2017-04-10 Thread Herbert Xu
On Fri, Feb 24, 2017 at 09:24:34PM +0100, Stephan Müller wrote: > Hi Herbert, > > I am working on fuzzing the AF_ALG interface. > > The fuzzer reliably triggered the following type of bug when I use > authenc(hmac(sha256),cbc(aes)) or other types of authenc() but do not call > setkey. > > Note

authenc: crash if key is not set

2017-02-24 Thread Stephan Müller
Hi Herbert, I am working on fuzzing the AF_ALG interface. The fuzzer reliably triggered the following type of bug when I use authenc(hmac(sha256),cbc(aes)) or other types of authenc() but do not call setkey. Note, it works with gcm or ccm. Is that bug similar in nature as the algif_skcipher a