Hi,
I am working on a new Version for this patch addressing all comments, and
following all guidelines.
Best Regards,
Benjamin Warnke
Hi,
I modified my code as suggested by Stephan and Eric.
Moving the code from the header files into *.c source files slowed down the
compression and decompression speed by a factor of up to 20.
I made no changes to the code itself, that would explain, why it is so much
slower.
Signed-off-by: B
Hi Stephan,
>>> In general: I do not think that having larger C functions in header files
>>> is a proper coding style.
>>
>> How should I solve this?
>>
>> Option 1:
>> Move everything in the lib/zbewalgo folder into a single source file.
>> This way there is no function defined in a header fi
Hi Eric,
>> Currently ZRAM uses the compression-algorithms from the crypto-api.
>> None of the current compression-algorithms in the crypto-api is designed
>> to compress 4KiB chunks of data efficiently.
>> This patch adds a new compression-algorithm especially designed for ZRAM,
>> to compress sm
Am Dienstag, 30. Januar 2018, 20:49:00 CET schrieb Benjamin Warnke:
Hi Benjamin,
> > In general: I do not think that having larger C functions in header files
> > is a proper coding style.
>
> How should I solve this?
>
> Option 1:
> Move everything in the lib/zbewalgo folder into a single sour
Hi Benjamin,
On Tue, Jan 30, 2018 at 04:08:57PM +0100, Benjamin Warnke wrote:
> Currently ZRAM uses the compression-algorithms from the crypto-api.
> None of the current compression-algorithms in the crypto-api is designed
> to compress 4KiB chunks of data efficiently.
> This patch adds a new comp
Hi Stephan,
thanks for your fast response.
> Please run checkpatch.pl on the patch and fix the formatting issues.
I've run checkpatch.pl again and fixed all errors and warnings except the
warnings about printk.
Compression does not have it's own subsystem, that is why I used
printk(KERN_INFO .
Am Dienstag, 30. Januar 2018, 16:08:57 CET schrieb Benjamin Warnke:
Hi Benjamin,
Please run checkpatch.pl on the patch and fix the formatting issues.
In general: I do not think that having larger C functions in header files is a
proper coding style. Also, having static variables header files is
Currently ZRAM uses the compression-algorithms from the crypto-api.
None of the current compression-algorithms in the crypto-api is designed
to compress 4KiB chunks of data efficiently.
This patch adds a new compression-algorithm especially designed for ZRAM,
to compress small pieces of data more e
