Re: zeroing tfms in crypto_free_tfm()

2009-02-05 Thread Herbert Xu
On Thu, Feb 05, 2009 at 12:03:20PM +0100, Geert Uytterhoeven wrote: > > It doesn't crash because crypto_shash_type.tfmsize = > offsetof(struct crypto_shash, base) = zero. Ah yes, I took out all the members from crypto_shash so it was harmless :) Thanks, -- Visit Openswan at http://www.openswan.

Re: zeroing tfms in crypto_free_tfm()

2009-02-05 Thread Geert Uytterhoeven
On Thu, 5 Feb 2009, Herbert Xu wrote: > On Wed, Feb 04, 2009 at 04:09:04PM +0100, Geert Uytterhoeven wrote: > > However, in the mean time, the allocation mechanism for crypto_tfm objects > > has > > been changed twice, by: > > 1. commit fbdae9f3e7fb57c07cb0d973f113eb25da2e8ff2 ("[CRYPTO] Ensure

Re: zeroing tfms in crypto_free_tfm()

2009-02-04 Thread Herbert Xu
On Wed, Feb 04, 2009 at 04:09:04PM +0100, Geert Uytterhoeven wrote: > > However, in the mean time, the allocation mechanism for crypto_tfm objects has > been changed twice, by: > 1. commit fbdae9f3e7fb57c07cb0d973f113eb25da2e8ff2 ("[CRYPTO] Ensure cit_iv > is aligned correctly"), which repla