Re: crypto: fips - Move fips_enabled sysctl into fips.c

2015-04-23 Thread Daniel Borkmann
On 04/22/2015 07:02 AM, Herbert Xu wrote: There is currently a large ifdef FIPS code section in proc.c. Ostensibly it's there because the fips_enabled sysctl sits under /proc/sys/crypto. However, no other crypto sysctls exist. In fact, the whole ethos of the crypto API is against such user inte

Re: crypto: fips - Move fips_enabled sysctl into fips.c

2015-04-22 Thread Herbert Xu
On Wed, Apr 22, 2015 at 02:33:03PM +0200, Stephan Mueller wrote: > > With this removal of crypto_proc_fips_* from crypto_*_proc, wouldn't you have > broken the link from algapi.c? There, crypto_*_proc is called where now the > FIPS logic may not be initialized any more. This code does not provid

Re: crypto: fips - Move fips_enabled sysctl into fips.c

2015-04-22 Thread Stephan Mueller
Am Mittwoch, 22. April 2015, 13:02:22 schrieb Herbert Xu: Hi Herbert, > There is currently a large ifdef FIPS code section in proc.c. > Ostensibly it's there because the fips_enabled sysctl sits under > /proc/sys/crypto. However, no other crypto sysctls exist. > > In fact, the whole ethos of th