Re: crypto: algif_hash: creating 0 sized array in hash_accept

2016-01-26 Thread Herbert Xu
On Tue, Jan 26, 2016 at 09:30:54AM -0500, Sasha Levin wrote: > > The C spec forbids it, so ubsan complains :) If you really care about this then please send a patch that adds ?: 1 to the size. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.ap

Re: crypto: algif_hash: creating 0 sized array in hash_accept

2016-01-26 Thread Sasha Levin
On 01/26/2016 09:07 AM, Herbert Xu wrote: > On Tue, Jan 26, 2016 at 08:26:41AM -0500, Sasha Levin wrote: >> > >> > This seems to be happening with "digest_null". > In that case this is expected as digest_null obviously has no > state. So why is a zero-length array disallowed by ubsan? The C spec

Re: crypto: algif_hash: creating 0 sized array in hash_accept

2016-01-26 Thread Herbert Xu
On Tue, Jan 26, 2016 at 08:26:41AM -0500, Sasha Levin wrote: > > This seems to be happening with "digest_null". In that case this is expected as digest_null obviously has no state. So why is a zero-length array disallowed by ubsan? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.or

Re: crypto: algif_hash: creating 0 sized array in hash_accept

2016-01-26 Thread Sasha Levin
On 01/25/2016 08:58 AM, Herbert Xu wrote: > On Mon, Jan 25, 2016 at 07:14:20AM -0500, Sasha Levin wrote: >> Hi all, >> >> While fuzzing with trinity inside a KVM tools guest running the latest -next >> kernel >> I've hit: >> >> [ 828.386074] UBSAN: Undefined behaviour in crypto/algif_hash.c:185:7

Re: crypto: algif_hash: creating 0 sized array in hash_accept

2016-01-25 Thread Herbert Xu
On Mon, Jan 25, 2016 at 07:14:20AM -0500, Sasha Levin wrote: > Hi all, > > While fuzzing with trinity inside a KVM tools guest running the latest -next > kernel > I've hit: > > [ 828.386074] UBSAN: Undefined behaviour in crypto/algif_hash.c:185:7 > [ 828.386811] variable length array bound val