Re: [PATCH v2 2/2] hwrng: npcm: add NPCM RNG driver

2019-09-11 Thread Daniel Thompson
On Tue, Sep 10, 2019 at 08:53:13PM +, Milton Miller II wrote: > On September 9, 2019 around 7:40AM in somet timezone, Tomer Maimon wrote: > >+#define NPCM_RNG_TIMEOUT_USEC 2 > >+#define NPCM_RNG_POLL_USEC 1000 > > ... > > >+static int npcm_rng_init(struct hwrng *rng) > >+{ > >+

Re: [PATCH v2 2/2] hwrng: npcm: add NPCM RNG driver

2019-09-10 Thread Milton Miller II
On September 9, 2019 around 7:40AM in somet timezone, Tomer Maimon wrote: >+#define NPCM_RNG_TIMEOUT_USEC 2 >+#define NPCM_RNG_POLL_USEC1000 ... >+static int npcm_rng_init(struct hwrng *rng) >+{ >+ struct npcm_rng *priv = to_npcm_rng(rng); >+ u32 val; >+ >+ val = readl(priv

Re: [PATCH v2 2/2] hwrng: npcm: add NPCM RNG driver

2019-09-10 Thread Daniel Thompson
On Mon, Sep 09, 2019 at 03:38:40PM +0300, Tomer Maimon wrote: > Add Nuvoton NPCM BMC Random Number Generator(RNG) driver. > > Signed-off-by: Tomer Maimon > --- > drivers/char/hw_random/Kconfig| 13 ++ > drivers/char/hw_random/Makefile | 1 + > drivers/char/hw_random/npcm-rng.c | 203 +++