Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

2018-11-19 Thread Jason A. Donenfeld
Hi Herbert, On Tue, Nov 20, 2018 at 4:06 AM Herbert Xu wrote: > > I'd still prefer to see the conversion patches included. Skipping them > > would be > > kicking the can down the road and avoiding issues that will need to be > > addressed > > anyway. Like you, I don't want a "half-baked conco

Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

2018-11-19 Thread Herbert Xu
On Mon, Nov 19, 2018 at 02:54:15PM -0800, Eric Biggers wrote: > > > I think the remaining issue right now is how to order my series and > > Eric's series. If Eric's goes in first, it means that I can either a) > > spend some time developing Zinc further _now_ to support chacha12 and > > keep the to

Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

2018-11-19 Thread Jason A. Donenfeld
Hi Eric, On Tue, Nov 20, 2018 at 12:23 AM Eric Biggers wrote: > It's much better to have the documentation in a permanent location. Agreed. > I actually did add ChaCha12 support to most of the Zinc assembly in > "[WIP] crypto: assembly support for ChaCha12" > (https://git.kernel.org/pub/scm/lin

Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

2018-11-19 Thread Eric Biggers
On Tue, Nov 20, 2018 at 12:15:17AM +0100, Jason A. Donenfeld wrote: > Hi Eric, > > On Mon, Nov 19, 2018 at 11:54 PM Eric Biggers wrote: > > Will v9 include a documentation file for Zinc in Documentation/crypto/? > > That's been suggested several times. > > I had started writing that there, but t

Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

2018-11-19 Thread Jason A. Donenfeld
Hi Eric, On Mon, Nov 19, 2018 at 11:54 PM Eric Biggers wrote: > Will v9 include a documentation file for Zinc in Documentation/crypto/? > That's been suggested several times. I had started writing that there, but then thought that the requested information could go in the commit message instead.

Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

2018-11-19 Thread Eric Biggers
On Mon, Nov 19, 2018 at 07:13:07AM +0100, Jason A. Donenfeld wrote: > Hi Herbert, > > On Mon, Nov 19, 2018 at 6:25 AM Herbert Xu > wrote: > > My proposal is to merge the zinc interface as is, but to invert > > how we place the algorithm implementations. IOW the implementations > > should stay w

Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

2018-11-18 Thread Herbert Xu
Hi Jason: On Mon, Nov 19, 2018 at 07:13:07AM +0100, Jason A. Donenfeld wrote: > > Sorry, but there isn't a chance I'll agree to this. The whole idea is > to have a clean place to focus on synchronous software > implementations, and not keep it tangled up with the asynchronous API. There is nothin

Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

2018-11-18 Thread Jason A. Donenfeld
Hi Herbert, On Mon, Nov 19, 2018 at 6:25 AM Herbert Xu wrote: > My proposal is to merge the zinc interface as is, but to invert > how we place the algorithm implementations. IOW the implementations > should stay where they are now, with in the crypto API. However, > we will provide direct acces