Re: [RFC PATCH] rxrpc: Fix -Wframe-larger-than= warnings from on-stack crypto

2019-07-25 Thread David Howells
Would you rather this went through net or net-next? David

Re: [RFC PATCH] rxrpc: Fix -Wframe-larger-than= warnings from on-stack crypto

2019-07-25 Thread Arnd Bergmann
On Thu, Jul 25, 2019 at 3:31 PM David Howells wrote: > > rxkad sometimes triggers a warning about oversized stack frames when > building with clang for a 32-bit architecture: > > net/rxrpc/rxkad.c:243:12: error: stack frame size of 1088 bytes in function > 'rxkad_secure_packet' [-Werror,-Wframe-l

Re: [RFC PATCH] rxrpc: Fix -Wframe-larger-than= warnings from on-stack crypto

2019-07-25 Thread David Howells
Ard Biesheuvel wrote: > Given that this part of the driver only uses synchronous crypto, and > only using a hardcoded algo and mode [pcbc(fcrypt)], of which only a > generic C implementation exists, may I suggest that we switch to a > library based approach instead? > > That way, we can get rid

Re: [RFC PATCH] rxrpc: Fix -Wframe-larger-than= warnings from on-stack crypto

2019-07-25 Thread Ard Biesheuvel
On Thu, 25 Jul 2019 at 16:31, David Howells wrote: > > rxkad sometimes triggers a warning about oversized stack frames when > building with clang for a 32-bit architecture: > > net/rxrpc/rxkad.c:243:12: error: stack frame size of 1088 bytes in function > 'rxkad_secure_packet' [-Werror,-Wframe-lar