Re: [RFC PATCH] akcipher: Introduce verify2 for public key algorithms

2019-01-16 Thread David Howells
Vitaly Chikunov wrote: > This will be hard to do since there is at least tree device that use > this interface (and who know how much out of tree): > > drivers$ git grep cra_name.*rsa > crypto/caam/caampkc.c: .cra_name = "rsa", > crypto/ccp/ccp-crypto-rsa.c:.cra_name =

Re: [RFC PATCH] akcipher: Introduce verify2 for public key algorithms

2019-01-04 Thread Vitaly Chikunov
On Thu, Dec 13, 2018 at 06:12:33PM +0800, Herbert Xu wrote: > Vitaly Chikunov wrote: > > Current akcipher .verify() just decrypts signature to uncover message > > hash, which is then verified in upper level public_key_verify_signature > > by memcmp with the expected signature value, which is never

Re: [RFC PATCH] akcipher: Introduce verify2 for public key algorithms

2018-12-13 Thread Vitaly Chikunov
Tudor, On Thu, Dec 13, 2018 at 10:26:53AM +, tudor.amba...@microchip.com wrote: > > On 12/11/2018 06:59 PM, Vitaly Chikunov wrote: > > Current akcipher .verify() just decrypts signature to uncover message > > hash, which is then verified in upper level public_key_verify_signature > > by memcm

Re: [RFC PATCH] akcipher: Introduce verify2 for public key algorithms

2018-12-13 Thread Tudor.Ambarus
Hi, On 12/11/2018 06:59 PM, Vitaly Chikunov wrote: > Current akcipher .verify() just decrypts signature to uncover message > hash, which is then verified in upper level public_key_verify_signature > by memcmp with the expected signature value, which is never passed into > verify(). > > This appro

Re: [RFC PATCH] akcipher: Introduce verify2 for public key algorithms

2018-12-13 Thread Herbert Xu
Vitaly Chikunov wrote: > Current akcipher .verify() just decrypts signature to uncover message > hash, which is then verified in upper level public_key_verify_signature > by memcmp with the expected signature value, which is never passed into > verify(). > > This approach is incompatible with ECD