Re: [RFC 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level

2011-03-10 Thread Nicholas A. Bellinger
On Tue, 2011-03-08 at 17:33 +0800, Herbert Xu wrote: > Nicholas A. Bellinger wrote: > > > >> > I should mention this is with the following .config: > >> > > >> > CONFIG_CRYPTO_CRC32C=y > >> > CONFIG_CRYPTO_CRC32C_INTEL=m > > This is why you get the unoptimised version. Had you selected > both a

Re: [RFC 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level

2011-03-08 Thread Herbert Xu
Nicholas A. Bellinger wrote: > >> > I should mention this is with the following .config: >> > >> > CONFIG_CRYPTO_CRC32C=y >> > CONFIG_CRYPTO_CRC32C_INTEL=m This is why you get the unoptimised version. Had you selected both as built-in or both as modules, then it would have worked as intended.

Re: [RFC 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level

2011-03-07 Thread Nicholas A. Bellinger
On Fri, 2011-03-04 at 11:00 -0600, James Bottomley wrote: > On Thu, 2011-03-03 at 12:58 -0800, Nicholas A. Bellinger wrote: > > On Thu, 2011-03-03 at 09:19 -0500, Christoph Hellwig wrote: > > > On Wed, Mar 02, 2011 at 01:32:11PM -0800, Nicholas A. Bellinger wrote: > > > > The kernel code itself tha

Re: [RFC 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level

2011-03-04 Thread James Bottomley
On Thu, 2011-03-03 at 12:58 -0800, Nicholas A. Bellinger wrote: > On Thu, 2011-03-03 at 09:19 -0500, Christoph Hellwig wrote: > > On Wed, Mar 02, 2011 at 01:32:11PM -0800, Nicholas A. Bellinger wrote: > > > The kernel code itself that is specific to using the SSE v4.2 > > > instruction for CRC32C o

Re: [RFC 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level

2011-03-03 Thread Nicholas A. Bellinger
On Thu, 2011-03-03 at 09:19 -0500, Christoph Hellwig wrote: > On Wed, Mar 02, 2011 at 01:32:11PM -0800, Nicholas A. Bellinger wrote: > > The kernel code itself that is specific to using the SSE v4.2 > > instruction for CRC32C offload are using #ifdef CONFIG_X86 stubs in > > iscsi_target_login.c:isc

Re: [RFC 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level

2011-03-03 Thread Christoph Hellwig
On Wed, Mar 02, 2011 at 01:32:11PM -0800, Nicholas A. Bellinger wrote: > The kernel code itself that is specific to using the SSE v4.2 > instruction for CRC32C offload are using #ifdef CONFIG_X86 stubs in > iscsi_target_login.c:iscsi_login_setup_crypto(), and !CONFIG_X86 will > default to using the