Re: [PATCH v4 0/5] BLAKE2b generic implementation

2019-10-13 Thread Eric Biggers
On Sun, Oct 13, 2019 at 09:50:52PM +0200, David Sterba wrote: > On Fri, Oct 11, 2019 at 10:57:40AM -0700, Eric Biggers wrote: > > The choice of data lengths seems a bit unusual, as they include every > > length in > > two ranges but nothing in between. Also, none of the lengths except 0 is a > >

Re: [PATCH v4 0/5] BLAKE2b generic implementation

2019-10-13 Thread David Sterba
On Fri, Oct 11, 2019 at 10:57:40AM -0700, Eric Biggers wrote: > The choice of data lengths seems a bit unusual, as they include every length > in > two ranges but nothing in between. Also, none of the lengths except 0 is a > multiple of the blake2b block size. Instead, maybe use something like >

Re: [PATCH v4 0/5] BLAKE2b generic implementation

2019-10-11 Thread Eric Biggers
On Fri, Oct 11, 2019 at 06:52:03PM +0200, David Sterba wrote: > The patchset adds blake2b refrerence implementation and test vectors. > > V4: > > Code changes: > > - removed .finup > - removed .cra_init > - dropped redundant sanity checks (key length, output size length) > - switch blake2b_param

Re: [PATCH v4 0/5] BLAKE2b generic implementation

2019-10-11 Thread David Sterba
On Fri, Oct 11, 2019 at 06:52:03PM +0200, David Sterba wrote: > Testing performed: > > - compiled with SLUB_DEBUG and KASAN, plus crypto selftests > CONFIG_CRYPTO_MANAGER2=y > CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y > - module loaded, no errors reported fr