Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Hans de Goede
Hi, On 07-10-2019 20:42, Arvind Sankar wrote: On Mon, Oct 07, 2019 at 05:40:07PM +0200, Ingo Molnar wrote: * Arvind Sankar wrote: With the barrier in there, is there any reason to *not* inline the function? barrier_data() is an asm statement that tells the compiler that the asm uses the mem

Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Arvind Sankar
On Mon, Oct 07, 2019 at 05:40:07PM +0200, Ingo Molnar wrote: > > * Arvind Sankar wrote: > > > With the barrier in there, is there any reason to *not* inline the > > function? barrier_data() is an asm statement that tells the compiler > > that the asm uses the memory that was set to zero, thus pr

Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Ingo Molnar
* Arvind Sankar wrote: > With the barrier in there, is there any reason to *not* inline the > function? barrier_data() is an asm statement that tells the compiler > that the asm uses the memory that was set to zero, thus preventing it > from removing the memset even if nothing else uses that me

Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Arvind Sankar
On Mon, Oct 07, 2019 at 04:46:00PM +0200, Ingo Molnar wrote: > > * Hans de Goede wrote: > > > Hi, > > > > On 07-10-2019 16:22, Ingo Molnar wrote: > > > > > > * Hans de Goede wrote: > > > > > > > Hi, > > > > > > > > On 07-10-2019 16:00, Ingo Molnar wrote: > > > > > > > > > > * Hans de Goede

Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Ingo Molnar
* Hans de Goede wrote: > Hi, > > On 07-10-2019 16:22, Ingo Molnar wrote: > > > > * Hans de Goede wrote: > > > > > Hi, > > > > > > On 07-10-2019 16:00, Ingo Molnar wrote: > > > > > > > > * Hans de Goede wrote: > > > > > > > > > The purgatory code now uses the shared lib/crypto/sha256.c s

Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Hans de Goede
Hi, On 07-10-2019 16:22, Ingo Molnar wrote: * Hans de Goede wrote: Hi, On 07-10-2019 16:00, Ingo Molnar wrote: * Hans de Goede wrote: The purgatory code now uses the shared lib/crypto/sha256.c sha256 implementation. This needs memzero_explicit, implement this. Reported-by: Arvind Sank

Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Ingo Molnar
* Hans de Goede wrote: > Hi, > > On 07-10-2019 16:00, Ingo Molnar wrote: > > > > * Hans de Goede wrote: > > > > > The purgatory code now uses the shared lib/crypto/sha256.c sha256 > > > implementation. This needs memzero_explicit, implement this. > > > > > > Reported-by: Arvind Sankar > >

Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Hans de Goede
Hi, On 07-10-2019 16:00, Ingo Molnar wrote: * Hans de Goede wrote: The purgatory code now uses the shared lib/crypto/sha256.c sha256 implementation. This needs memzero_explicit, implement this. Reported-by: Arvind Sankar Fixes: 906a4bb97f5d ("crypto: sha256 - Use get/put_unaligned_be32 to

Re: [PATCH v2 5.4 regression fix] x86/boot: Provide memzero_explicit

2019-10-07 Thread Ingo Molnar
* Hans de Goede wrote: > The purgatory code now uses the shared lib/crypto/sha256.c sha256 > implementation. This needs memzero_explicit, implement this. > > Reported-by: Arvind Sankar > Fixes: 906a4bb97f5d ("crypto: sha256 - Use get/put_unaligned_be32 to get > input, memzero_explicit") > Si