Re: [PATCH v2 5/5] crypto: ECDH SP800-56A rev 3 local public key validation

2020-07-15 Thread Marcelo Henrique Cerri
Reviewed-by: Marcelo Henrique Cerri Tested-by: Marcelo Henrique Cerri On Sun, Jul 12, 2020 at 06:42:14PM +0200, Stephan Müller wrote: > After the generation of a local public key, SP800-56A rev 3 section > 5.6.2.1.3 mandates a validation of that key with a full validation > compliant to section

Re: [PATCH v2 5/5] crypto: ECDH SP800-56A rev 3 local public key validation

2020-07-12 Thread Stephan Müller
Am Montag, 13. Juli 2020, 07:59:50 CEST schrieb Vitaly Chikunov: Hi Vitaly, > > > > +/* SP800-56A section 5.6.2.3.3 full verification */ > > > > > > Btw, 5.6.2.3.3 is partial validation, 5.6.2.3.2 is full validation > > > routine. > > > > Looking at SP800-56A revision 3 from April 2018 I see: >

Re: [PATCH v2 5/5] crypto: ECDH SP800-56A rev 3 local public key validation

2020-07-12 Thread Vitaly Chikunov
On Mon, Jul 13, 2020 at 07:04:39AM +0200, Stephan Mueller wrote: > Am Sonntag, 12. Juli 2020, 20:06:13 CEST schrieb Vitaly Chikunov: > > Hi Vitaly, > > > Stephan, > > > > On Sun, Jul 12, 2020 at 06:42:14PM +0200, Stephan Müller wrote: > > > After the generation of a local public key, SP800-56A r

Re: [PATCH v2 5/5] crypto: ECDH SP800-56A rev 3 local public key validation

2020-07-12 Thread Stephan Mueller
Am Sonntag, 12. Juli 2020, 20:06:13 CEST schrieb Vitaly Chikunov: Hi Vitaly, > Stephan, > > On Sun, Jul 12, 2020 at 06:42:14PM +0200, Stephan Müller wrote: > > After the generation of a local public key, SP800-56A rev 3 section > > 5.6.2.1.3 mandates a validation of that key with a full validati

Re: [PATCH v2 5/5] crypto: ECDH SP800-56A rev 3 local public key validation

2020-07-12 Thread Vitaly Chikunov
Stephan, On Sun, Jul 12, 2020 at 06:42:14PM +0200, Stephan Müller wrote: > After the generation of a local public key, SP800-56A rev 3 section > 5.6.2.1.3 mandates a validation of that key with a full validation > compliant to section 5.6.2.3.3. > > Only if the full validation passes, the key is