Re: [PATCH v2 3/6] crypto: x86/chacha20 - limit the preemption-disabled section

2018-12-04 Thread Eric Biggers
On Mon, Dec 03, 2018 at 03:13:37PM +0100, Ard Biesheuvel wrote: > On Sun, 2 Dec 2018 at 11:47, Martin Willi wrote: > > > > > > > To improve responsiveness, disable preemption for each step of the > > > walk (which is at most PAGE_SIZE) rather than for the entire > > > encryption/decryption operati

Re: [PATCH v2 3/6] crypto: x86/chacha20 - limit the preemption-disabled section

2018-12-03 Thread Ard Biesheuvel
On Sun, 2 Dec 2018 at 11:47, Martin Willi wrote: > > > > To improve responsiveness, disable preemption for each step of the > > walk (which is at most PAGE_SIZE) rather than for the entire > > encryption/decryption operation. > > It seems that it is not that uncommon for IPsec to get small inputs

Re: [PATCH v2 3/6] crypto: x86/chacha20 - limit the preemption-disabled section

2018-12-02 Thread Martin Willi
> To improve responsiveness, disable preemption for each step of the > walk (which is at most PAGE_SIZE) rather than for the entire > encryption/decryption operation. It seems that it is not that uncommon for IPsec to get small inputs scattered over multiple blocks. Doing FPU context saving for