Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-15 Thread Kalle Valo
"Pan, Miaoqing" writes: > The entropy was evaluated by crypto expert, the analysis report show > the ADC with at least 10bits and up to 22 bits of min-entropy for a 32 > bits value, we conservatively assume the min-entropy is 10 bits out of > 32 bits, so that's why set entropy quality to 320/1024

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-14 Thread Jason Cooper
Hey Ted, On Wed, Aug 10, 2016 at 07:44:25PM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 02:04:44PM +, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > > disasterous because despite most drivers having a default quality of 0, > > rngd assumes 1

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-10 Thread Theodore Ts'o
On Tue, Aug 09, 2016 at 02:04:44PM +, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > disasterous because despite most drivers having a default quality of 0, > rngd assumes 1 bit of entropy for every bit read? Sorry, what I was trying to say (but fail

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-09 Thread Jason Cooper
Hi Ted, On Tue, Aug 09, 2016 at 07:56:22AM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > > Agree with Jason's point, also understand Stephan's concern. The > > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > > 1000', the averag

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-09 Thread Theodore Ts'o
On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > Agree with Jason's point, also understand Stephan's concern. The > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > 1000', the average speed is .294Kibits/s. I will sent the patch > to disable ath9k RNG by def

RE: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Pan, Miaoqing
devel ; linux-wirel...@vger.kernel.org; ath9k-de...@lists.ath9k.org; Kalle Valo Subject: Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqi

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Jason Cooper
Hi Stephan, On Mon, Aug 08, 2016 at 05:29:30PM +, Jason Cooper wrote: > On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: ... > > If you think that this patch is a challenge because your driver starts to > > spin, please help and offer another solution. > > Well, I don't buy t

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Jason Cooper
Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: > > The entropy was evaluated by crypto expert, the analysis report show the > > ADC with at least 10bits and up to 22 bits of min-entropy f

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-07 Thread Stephan Mueller
Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: Hi Miaoqing, > The entropy was evaluated by crypto expert, the analysis report show the > ADC with at least 10bits and up to 22 bits of min-entropy for a 32 bits > value, we conservatively assume the min-entropy is 10 bits out of 32

RE: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-07 Thread Pan, Miaoqing
The entropy was evaluated by crypto expert, the analysis report show the ADC with at least 10bits and up to 22 bits of min-entropy for a 32 bits value, we conservatively assume the min-entropy is 10 bits out of 32 bits, so that's why set entropy quality to 320/1024 = 10/32. Also we have expl