Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-29 Thread AnilKumar Chimata
Hi Rob, Thanks for the comments, On 2018-10-25 20:58, Theodore Y. Ts'o wrote: On Thu, Oct 25, 2018 at 09:55:48AM -0500, Rob Herring wrote: > +Introduction: > += > +Storage encryption has been one of the most required feature from security > +point of view. QTI based storage encry

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-29 Thread AnilKumar Chimata
Hi Rob, Thanks for the review, On 2018-10-25 20:28, Rob Herring wrote: On Wed, Oct 24, 2018 at 04:44:37PM +0530, an...@codeaurora.org wrote: Hi, Thanks for the comments, response inline. FYI, this was from a bot. I have realized after I sent the mail. Thanks, AnilKumar On 2018-10-1

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-25 Thread Rob Herring
On Thu, Oct 25, 2018 at 10:29 AM Theodore Y. Ts'o wrote: > > On Thu, Oct 25, 2018 at 09:55:48AM -0500, Rob Herring wrote: > > > +Introduction: > > > += > > > +Storage encryption has been one of the most required feature from > > > security > > > +point of view. QTI based storage encry

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-25 Thread Theodore Y. Ts'o
On Thu, Oct 25, 2018 at 09:55:48AM -0500, Rob Herring wrote: > > +Introduction: > > += > > +Storage encryption has been one of the most required feature from security > > +point of view. QTI based storage encryption solution uses general purpose > > +crypto engine. While this kind of so

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-25 Thread Rob Herring
On Wed, Oct 24, 2018 at 04:44:37PM +0530, an...@codeaurora.org wrote: > Hi, > > Thanks for the comments, response inline. FYI, this was from a bot. > > Thanks, > AnilKumar > > > On 2018-10-18 17:13, kbuild test robot wrote: > > Hi AnilKumar, > > > > Thank you for the patch! Yet something to

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-25 Thread Rob Herring
On Wed, Oct 17, 2018 at 08:47:56PM +0530, AnilKumar Chimata wrote: > This patch adds support for Inline Crypto Engine (ICE), which > is embedded into storage device/controller such as UFS/eMMC. > ICE is intended for high throughput cryptographic encryption > or decryption of storage data. > > Sign

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-24 Thread AnilKumar Chimata
Hi Randy, Thanks for your comments, On 2018-10-17 23:09, Randy Dunlap wrote: On 10/17/18 8:17 AM, AnilKumar Chimata wrote: This patch adds support for Inline Crypto Engine (ICE), which is embedded into storage device/controller such as UFS/eMMC. ICE is intended for high throughput cryptographi

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-24 Thread AnilKumar Chimata
Hi Theodore, Thanks for the comments, On 2018-10-17 22:34, Theodore Y. Ts'o wrote: First, thanks for the effort for working on getting the core ICE driver support into upstreamable patches. On Wed, Oct 17, 2018 at 08:47:56PM +0530, AnilKumar Chimata wrote: +2) Per File Encryption (PFE) +Per F

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-24 Thread anilc
Hi, Thanks for the comments, response inline. Thanks, AnilKumar On 2018-10-18 17:13, kbuild test robot wrote: Hi AnilKumar, Thank you for the patch! Yet something to improve: [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.19-rc8 next-20181018] [if your patch is app

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-18 Thread kbuild test robot
Hi AnilKumar, Thank you for the patch! Yet something to improve: [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.19-rc8 next-20181018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-17 Thread Randy Dunlap
On 10/17/18 8:17 AM, AnilKumar Chimata wrote: > This patch adds support for Inline Crypto Engine (ICE), which > is embedded into storage device/controller such as UFS/eMMC. > ICE is intended for high throughput cryptographic encryption > or decryption of storage data. > > Signed-off-by: AnilKumar

Re: [PATCH 3/3] crypto: qce: ice: Add support for Inline Crypto Engine

2018-10-17 Thread Theodore Y. Ts'o
First, thanks for the effort for working on getting the core ICE driver support into upstreamable patches. On Wed, Oct 17, 2018 at 08:47:56PM +0530, AnilKumar Chimata wrote: > +2) Per File Encryption (PFE) > +Per File Manager(PFM) calls QSEECom api to create the key. PFM has a peer > comp- > +one