Re: [PATCH 2/6] crypto: algapi - use common mechanism for inheriting flags

2020-07-09 Thread Herbert Xu
On Thu, Jul 09, 2020 at 11:24:03PM -0700, Eric Biggers wrote: > > I decided to make crypto_check_attr_type() return the mask instead, and do so > via a pointer argument instead of the return value (so that we don't overload > an > errno return value and prevent flag 0x8000 from working). > Ple

Re: [PATCH 2/6] crypto: algapi - use common mechanism for inheriting flags

2020-07-09 Thread Eric Biggers
On Thu, Jul 09, 2020 at 03:31:26PM +1000, Herbert Xu wrote: > Eric Biggers wrote: > > > > @@ -875,14 +873,21 @@ static void cbcmac_exit_tfm(struct crypto_tfm *tfm) > > > > static int cbcmac_create(struct crypto_template *tmpl, struct rtattr **tb) > > { > > + struct crypto_attr_type *algt; >

Re: [PATCH 2/6] crypto: algapi - use common mechanism for inheriting flags

2020-07-08 Thread Herbert Xu
Eric Biggers wrote: > > @@ -875,14 +873,21 @@ static void cbcmac_exit_tfm(struct crypto_tfm *tfm) > > static int cbcmac_create(struct crypto_template *tmpl, struct rtattr **tb) > { > + struct crypto_attr_type *algt; >struct shash_instance *inst; >struct crypto_cipher_spawn *