Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2010-01-18 Thread Richard Zidlicky
Hi, > > ivseed = key_table[64] is nowhere declared. > > This is an implementation detail of Loop-AES, so I don't consider it > belonging to the description of the modes here. difficult to draw the line, but as it is something supplied as "external parameter" to the dm-crypt layer I think it

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2010-01-18 Thread Max Vozeler
Hello Richard, On Sun, Jan 17, 2010 at 11:02:34PM +0100, Richard Zidlicky wrote: > > diff --git a/Documentation/crypto/lmk.txt b/Documentation/crypto/lmk.txt > > new file mode 100644 > > index 000..91ca7f7 > > --- /dev/null > > +++ b/Documentation/crypto/lmk.txt > > @@ -0,0 +1,102 @@ > > +Loop

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2010-01-17 Thread Richard Zidlicky
Hi, > The format-magic is not mentioned in Jari's description, but > is indeed used by Loop-AES. > > Compare loop-AES-v3.2h/glue.c:402: > > /* 4024 bits == 31 * 128 bit plaintext blocks + 56 bits of sector number */ > /* For version 3 on-disk format this really should be 4536 bits, but can't

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2010-01-13 Thread Max Vozeler
Hi Richard, On Mon, Jan 11, 2010 at 10:28:39PM +0100, Richard Zidlicky wrote: > On Mon, Jan 04, 2010 at 04:25:42PM +0100, Max Vozeler wrote: > > + > > +These modes have two main characteristics compared to regular CBC > > +with sector IV. The first is implemented in dm-crypt, the second > > +is im

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2010-01-11 Thread Richard Zidlicky
On Mon, Jan 04, 2010 at 04:25:42PM +0100, Max Vozeler wrote: > + > +These modes have two main characteristics compared to regular CBC > +with sector IV. The first is implemented in dm-crypt, the second > +is implemented in the lmk2 and lmk3 blkciphers. the formulation is not very clear. Possibly

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2010-01-04 Thread Max Vozeler
On Tue, Dec 29, 2009 at 02:46:39AM +0100, Max Vozeler wrote: > On Mon, Dec 28, 2009 at 08:37:43PM +0100, Milan Broz wrote: > > But anyway, I see that the reason for this is to introduce multikey feature > > (compatible with loop-AES mode). That's interesting idea. > > > > But please can you add mo

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2009-12-29 Thread Richard Zidlicky
Hi, many thanks for the clarifications. Fedora has a very nice and unobstrusive crypto setup but finding out the technical details involves looking into quite a few places. The http://code.google.com/p/cryptsetup/ pages seems to have plenty of information for a start. > (If you think about c

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2009-12-29 Thread Milan Broz
On 12/29/2009 10:21 AM, Richard Zidlicky wrote: > On Mon, Dec 28, 2009 at 08:37:43PM +0100, Milan Broz wrote: > While we are at it - are you aware of any documentation of the "mainline" > dm-crypt > implementation? I have not seen anything, much less any explanation if it has > improved > any s

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2009-12-29 Thread Richard Zidlicky
On Mon, Dec 28, 2009 at 08:37:43PM +0100, Milan Broz wrote: Hi, > > But please can you add more explanation into documentation about this mode? > Is there any paper which analyses that mode - if so can you add link > to description? > (and yes, I know loop-AES documentation:-) I have some archi

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2009-12-28 Thread Max Vozeler
On Mon, Dec 28, 2009 at 08:37:43PM +0100, Milan Broz wrote: > On 12/28/2009 07:59 PM, Max Vozeler wrote: > > The original code used cc->cipher for two things: > > > @@ -1014,6 +1014,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned > > int argc, char **argv) > > char *ivopts; > > u

Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode

2009-12-28 Thread Milan Broz
On 12/28/2009 07:59 PM, Max Vozeler wrote: > The original code used cc->cipher for two things: > @@ -1014,6 +1014,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int > argc, char **argv) > char *ivopts; > unsigned int key_size; > unsigned long long tmpll; > + char c