Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-04-08 Thread Varad Gautam
On 4/8/21 4:29 AM, hongbo li wrote: > Hi Varad, > > Varad Gautam mailto:varad.gau...@suse.com>> > 于2021年4月8日周四 上午5:20写道: >> >> Hi Hongbo, >> >> On 4/7/21 10:27 AM, hongbo li wrote: >> > Hello Varad, >> > >> > I also made an implementation of rsa pss: "[PATCH v3 0/4] crypto: add >> > rsa pss suppo

Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-04-07 Thread Varad Gautam
Hi Hongbo, On 4/7/21 10:27 AM, hongbo li wrote: > Hello Varad, > > I also made an implementation of rsa pss: "[PATCH v3 0/4] crypto: add > rsa pss support for x509". > I notice your patches and did some review, find the following > differences between our patches: > 1. You rework the rsa pad fra

Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-04-07 Thread hongbo li
Hello Varad, I also made an implementation of rsa pss: "[PATCH v3 0/4] crypto: add rsa pss support for x509". I notice your patches and did some review, find the following differences between our patches: 1. You rework the rsa pad framework. This is reasonable. 2. You did some changes on the keyc

Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-04-01 Thread Varad Gautam
On 4/1/21 3:09 AM, Herbert Xu wrote: > On Tue, Mar 30, 2021 at 10:28:12PM +0200, Varad Gautam wrote: >> An X.509 wrapper for a RSASSA-PSS signature contains additional >> signature parameters over the PKCSv.15 encoding scheme. Extend the >> x509 parser to allow parsing RSASSA-PSS encoded certificat

Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-03-31 Thread Herbert Xu
On Tue, Mar 30, 2021 at 10:28:12PM +0200, Varad Gautam wrote: > An X.509 wrapper for a RSASSA-PSS signature contains additional > signature parameters over the PKCSv.15 encoding scheme. Extend the > x509 parser to allow parsing RSASSA-PSS encoded certificates, with > the defaults taken from RFC8017

Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-03-30 Thread kernel test robot
Hi Varad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on crypto/master security/next-testing linus/master v5.12-rc5 next-20210330] [If your patch is applied to the wrong git tree, kindly drop us a note. And when su