Re: [PATCH 0/9] crypto: fix alignmask handling

2021-02-09 Thread Herbert Xu
On Mon, Feb 01, 2021 at 07:02:28PM +0100, Ard Biesheuvel wrote: > Some generic implementations of vintage ciphers rely on alignmasks to > ensure that the input is presented with the right alignment. Given that > these are all C implementations, which may execute on architectures that > don't care a

Re: [PATCH 0/9] crypto: fix alignmask handling

2021-02-03 Thread Ard Biesheuvel
On Wed, 3 Feb 2021 at 12:19, Herbert Xu wrote: > > On Wed, Feb 03, 2021 at 10:37:10AM +0100, Ard Biesheuvel wrote: > > > > One thing that became apparent to me while looking into this stuff is > > that the skcipher encrypt/decrypt API ignores alignmasks altogether, > > so this is something we shou

Re: [PATCH 0/9] crypto: fix alignmask handling

2021-02-03 Thread Herbert Xu
On Wed, Feb 03, 2021 at 10:37:10AM +0100, Ard Biesheuvel wrote: > > One thing that became apparent to me while looking into this stuff is > that the skcipher encrypt/decrypt API ignores alignmasks altogether, > so this is something we should probably look into at some point, i.e., > whether the ali

Re: [PATCH 0/9] crypto: fix alignmask handling

2021-02-03 Thread Ard Biesheuvel
On Tue, 2 Feb 2021 at 23:20, Eric Biggers wrote: > > On Mon, Feb 01, 2021 at 07:02:28PM +0100, Ard Biesheuvel wrote: > > Some generic implementations of vintage ciphers rely on alignmasks to > > ensure that the input is presented with the right alignment. Given that > > these are all C implementat

Re: [PATCH 0/9] crypto: fix alignmask handling

2021-02-02 Thread Eric Biggers
On Mon, Feb 01, 2021 at 07:02:28PM +0100, Ard Biesheuvel wrote: > Some generic implementations of vintage ciphers rely on alignmasks to > ensure that the input is presented with the right alignment. Given that > these are all C implementations, which may execute on architectures that > don't care a