Re: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-11-12 Thread Miguel Ojeda
On Wed, Nov 11, 2020 at 8:19 AM Ard Biesheuvel wrote: > > I am still not convinced we need this change, as I don't see how the > concerns regarding __section apply to __alias. But if we do, can we > please use the same approach, i.e., revert the current patch, and > queue it again after v5.11-rc1

Re: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-11-10 Thread Ard Biesheuvel
(+ Russell) On Thu, 22 Oct 2020 at 18:20, Joe Perches wrote: > > On Thu, 2020-10-22 at 09:33 +0200, Peter Zijlstra wrote: > > On Wed, Oct 21, 2020 at 11:58:25AM -0700, Joe Perches wrote: > > > Like the __section macro, the __alias macro uses > > > macro # stringification to create quotes around >

Re: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-10-22 Thread Joe Perches
On Thu, 2020-10-22 at 09:33 +0200, Peter Zijlstra wrote: > On Wed, Oct 21, 2020 at 11:58:25AM -0700, Joe Perches wrote: > > Like the __section macro, the __alias macro uses > > macro # stringification to create quotes around > > the section name used in the __attribute__. > > > > Remove the string

Re: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-10-22 Thread Peter Zijlstra
On Wed, Oct 21, 2020 at 11:58:25AM -0700, Joe Perches wrote: > Like the __section macro, the __alias macro uses > macro # stringification to create quotes around > the section name used in the __attribute__. > > Remove the stringification and add quotes or a > stringification to the uses instead.

RE: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-10-21 Thread David Laight
From: Ard Biesheuvel > Sent: 21 October 2020 20:03 > > On Wed, 21 Oct 2020 at 20:58, Joe Perches wrote: > > > > Like the __section macro, the __alias macro uses > > macro # stringification to create quotes around > > the section name used in the __attribute__. > > > > Remove the stringification a

Re: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-10-21 Thread Miguel Ojeda
On Wed, Oct 21, 2020 at 9:07 PM Joe Perches wrote: > > Using quotes in __section caused/causes differences > between clang and gcc. Yeah, it is a good cleanup get. Thanks! > https://lkml.org/lkml/2020/9/29/2187 Can you please put this in a Link: like Ard suggested? (and ideally find the messag

Re: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-10-21 Thread Ard Biesheuvel
On Wed, 21 Oct 2020 at 21:07, Joe Perches wrote: > > On Wed, 2020-10-21 at 21:02 +0200, Ard Biesheuvel wrote: > > On Wed, 21 Oct 2020 at 20:58, Joe Perches wrote: > > > Like the __section macro, the __alias macro uses > > > macro # stringification to create quotes around > > > the section name us

Re: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-10-21 Thread Joe Perches
On Wed, 2020-10-21 at 21:02 +0200, Ard Biesheuvel wrote: > On Wed, 21 Oct 2020 at 20:58, Joe Perches wrote: > > Like the __section macro, the __alias macro uses > > macro # stringification to create quotes around > > the section name used in the __attribute__. > > > > Remove the stringification a

Re: [PATCH -next] treewide: Remove stringification from __alias macro definition

2020-10-21 Thread Ard Biesheuvel
On Wed, 21 Oct 2020 at 20:58, Joe Perches wrote: > > Like the __section macro, the __alias macro uses > macro # stringification to create quotes around > the section name used in the __attribute__. > > Remove the stringification and add quotes or a > stringification to the uses instead. > Why? >