Re: [PATCH] ixp4xx_crypto: avoid firmware loading during module initialisation

2008-10-29 Thread Herbert Xu
On Thu, Oct 23, 2008 at 02:28:32PM +0200, Christian Hohnstaedt wrote: > > atomic_set(&ctx->configuring, 0); > + switch ((image_id>>16) & 0xff) { > + case 3: > + if (cipher_cfg_enc(tfm) & MOD_AES) { > + printk(KERN_ERR "Firmware o

Re: [PATCH] ixp4xx_crypto: avoid firmware loading during module initialisation

2008-10-23 Thread Christian Hohnstaedt
On Tue, Aug 19, 2008 at 02:55:10PM +1000, Herbert Xu wrote: > Christian Hohnstaedt <[EMAIL PROTECTED]> wrote: > > By moving the firmware-loading to the transform initialisation, > > the driver may be compiled in. > > > > Notify the user if the firmware does not support AES, or even > > no crypto a

Re: [PATCH] ixp4xx_crypto: avoid firmware loading during module initialisation

2008-08-18 Thread Herbert Xu
Christian Hohnstaedt <[EMAIL PROTECTED]> wrote: > By moving the firmware-loading to the transform initialisation, > the driver may be compiled in. > > Notify the user if the firmware does not support AES, or even > no crypto at all. What happens when two tfms are constructed at the same time? Ch