Re: [PATCH] crypto: x86/chacha-sse3 - use unaligned loads for state array

2020-07-16 Thread Herbert Xu
On Wed, Jul 08, 2020 at 12:11:18PM +0300, Ard Biesheuvel wrote: > Due to the fact that the x86 port does not support allocating objects > on the stack with an alignment that exceeds 8 bytes, we have a rather > ugly hack in the x86 code for ChaCha to ensure that the state array is > aligned to 16 by

Re: [PATCH] crypto: x86/chacha-sse3 - use unaligned loads for state array

2020-07-08 Thread Eric Biggers
On Wed, Jul 08, 2020 at 12:11:18PM +0300, Ard Biesheuvel wrote: > Due to the fact that the x86 port does not support allocating objects > on the stack with an alignment that exceeds 8 bytes, we have a rather > ugly hack in the x86 code for ChaCha to ensure that the state array is > aligned to 16 by

Re: [PATCH] crypto: x86/chacha-sse3 - use unaligned loads for state array

2020-07-08 Thread Martin Willi
> Due to the fact that the x86 port does not support allocating objects > on the stack with an alignment that exceeds 8 bytes, we have a rather > ugly hack in the x86 code for ChaCha to ensure that the state array > is aligned to 16 bytes, allowing the SSE3 implementation of the > algorithm to us